From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=205.220.168.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792480717; b=JoydA51jC+qz8o0jmEA+AEq5wc0tEf4TfF+0Yl5tbPl6KZDK3AjlYlWZTn5OlhgaF0zH hIiB0rWWbg2d6fyDknYuPUd655/f+CmJw74iK1vLrGVVjJATrxhr4Mp1lGtALAUdh6aTf UwSoDlGJyyWZupT4no+W+2k/HWc/WgzpG2B4R0TPSpIwTM0SMP5kS0UaXZAM92ipziIsl ECMFOtD9YGJaeWJ1Ck1C2qRLmEbhfb7DoPxMt9tabFOE9uX6wvmhQw5WrhMM9qEabKHYP DCAR5XvD712WAuGoukGpzIsNhkER4848wib9h+VUxFqh4lSiZ+oFb9J7ST9u5wyVLjw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792480717; h=DMARC-Filter:Received:DKIM-Signature:Received:Received: DKIM-Signature:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:X-Received:Received:Message-ID: Date:MIME-Version:User-Agent:Subject:To:Cc:References: Content-Language:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:X-Authority-Analysis:X-Proofpoint-Spam-Info: X-Proofpoint-GUID:X-Proofpoint-ORIG-GUID: X-Proofpoint-Spam-Details-Enc:X-Proofpoint-Virus-Version: X-Proofpoint-Spam-Details; bh=ZXg29oI0BzMp9Wce8FtHMSF+MR/+HfdO6N47KyWprp0=; b=IzJPEU3ESCbKZcll2VFZPPuSgslbkZUGjFEwezps090mLAUe/Uz2itdfwh+ooIIVLSGA syDVZFGI5qvE+IBHZXu/7zJ6lsJwg6hRihxpXpcJerYhDsNAnMeIm9aMK6A+eOyXbeMkL u9oPLFzSqAxiJuTUAOj2EwCzOigWaBmYeyhWfEeuAh+JccOEmwi52Opi7WXh3ZPcqybm+ jQKwTnVzgmTbzL/e9FjRA8UtyieOm6sOzcYznHQYpnjZlzh2ognXHMyBjKZgzfGQ64yEq kmPNrvzwKM6Gyx63B6iPmy5va/p8/Cxb5RScJpFoVOvHIBYbQgMnO0wt0PLzRywoloA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=F2Y3gNdl; dkim=pass header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=Jut2JykM; arc=none smtp.remote-ip=205.220.168.131 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 959DE606A31C for ; Tue, 20 Oct 2026 07:18:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 959DE606A31C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=F2Y3gNdl; dkim=pass (2048-bit key, unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=Jut2JykM Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69K0t3Dd3485511 for ; Tue, 20 Oct 2026 07:18:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ZXg29oI0BzMp9Wce8FtHMSF+MR/+HfdO6N47KyWprp0=; b=F2Y3gNdlDoYAG2Xz O5R0doyZP2cg2KtNO8rz0yNUGuQ3JFKJmzVuS9PjkU8vDHuaxP6BC9R+gpjAfrN4 /vKvpu9yhhb6LoNSWjXPxbSWo8uHtUg5B0neFEOtdEPatSpvL/h8XMCbJeoppsGz SzIWalGdoQH5ryX8v+TP1t6uDwoQ80sjdH6+IyxypSK8UZkFuMx/xdZ5Eg/8p8Qk ujgSetVeoBDc/QdYpbfa7Qq5BkouLTKPKOVEybjNk6+Di1bNjivvvGJ3bp+VOtjg 7fhJ+aPWXrzeto5TiqsVAL5kuze7b1vbBA2LauXT0vHUZErOnF1lCZZGy8kl7L8a x3STAw== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hdw5n1bcv-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 20 Oct 2026 07:18:35 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-93a1de6d5c3so683845885a.3 for ; Tue, 20 Oct 2026 00:18:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1792480715; x=1793085515; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ZXg29oI0BzMp9Wce8FtHMSF+MR/+HfdO6N47KyWprp0=; b=Jut2JykMUxV/M7c5jRsMtDUgcrnyCjkXCebJSbExQUM17lmQMweXthTgXEh3in2nOc aaSlK7apGZC9bSJj748fMcO8h5j4a/JNLsNUmz+dEUfoSj3gBS2Bzkmzs3xc2yyu/McZ S1jiEx+gRNHoHXns854ZuhAwAR9JjDWjv9geLSyoVkzjLy4wj4bIIxnBrpesMWUv2525 SkN3n4FNG776u10WATuBQx1GYaSM8Qvh4bKpf1I7cmE7+4wG6sVOs1oa0kY0hL4Gg6OX X5nDA23Z7YFcITUFkeYOx6cmzzWkO5iMmtfGQN27PXJlHCE7MxjTyg3JxpQRGsrrsUhT ejOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792480715; x=1793085515; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ZXg29oI0BzMp9Wce8FtHMSF+MR/+HfdO6N47KyWprp0=; b=dJdutm6lLGXLlR4AwcXQwdf0PW8BG6ngtEitY/y8v6JC71da8XUbP9hd6ikUQh7CXO 4SId7cP7O6l9vT6rpsBzsdgw9ApCohTY2GRhTiykVfXN9OfVIhEWI73VuYrs0RJO75Hk wsgfC+GfXp429i6+A3CQ3VZ1tCCC4c/WiyRVtgvPzuSQTXjteYykfKmIRb5/sHth6JtW hDkxhDrkDbzaccwr59HhatYgyUe9oLDMndKg2MbVq2EuITzQ3d4AXSckXhRidLV1T9JH AtCeiFTQXwLKx8W1XMUWcrekNWHNTJVzRYVa0IBOmFF5igBh69JHg24cUJo+QuF8X135 elXg== X-Forwarded-Encrypted: i=1; AKwUvBxAwDbnetlXaZlLIaHdRBb46pb9URWj9Zc4DPT2EMbRj2ohWkvE5hhpeQ6PmfjtdimhtY2eX/WP0GAZHMg=@vger.kernel.org X-Gm-Message-State: AFq9FYJZssGyPSQjiN9YICnEVon+Ft5EQ0T3oaNdtGomI1a9H10LR+CL gHL+92/EX+e7v/F9/pNJW0Xqp767y+YzawcMVbUc8SKhi2KofVLsRjtZj9WizeCYfLveS28umaJ Rydx0pIT6ouhTmZXdD9p6gET21XUMOrZyFFjL5pYZPRcMdw38sz7p3/5SrHzVvWnhrzI= X-Gm-Gg: AYBFou10HdWtNc17u7ifDovAijFPhmBbFLCUEAw9dLN7GCD0ADWuUmpS8DoHcX0ft/C nw5Ivmw8vivQBiVsQ/BSp2XO9R6MzsatdWfP7CoQCV5JbEHn1TC32DTLoRM8bPDHrHtm//e5Jas OLnaaHhx5Fq6dhu6zJFLIOzntN3JXU9Qebwr4Q8f2LdyLGF3J4Wwu8TgZ7p08LmDyeeRuEpJaV9 /aI0KU6U7f7L1NfD9mwPQuHIVJ0bOU4PdaGWWjvMErtlpVPUXackZhrTXEx1HRj0JtGHkafZdmx 498Gp5JxO+layN6O/GnqKH42yqCF01nm2nZX8K/ZT33hjep7zv0exi289QvWqzfCmFvSWgwEX6X uHmiWSmZ9wnAnDcR7OoI6g169rQ== X-Received: by 2002:a05:620a:6e93:10b0:93f:34c9:9248 with SMTP id af79cd13be357-93f34c9951amr881008685a.22.1792480714839; Tue, 20 Oct 2026 00:18:34 -0700 (PDT) X-Received: by 2002:a05:620a:6e93:10b0:93f:34c9:9248 with SMTP id af79cd13be357-93f34c9951amr881007585a.22.1792480714420; Tue, 20 Oct 2026 00:18:34 -0700 (PDT) Received: from [192.168.68.120] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-4a1f2cc8e98sm54686715e9.9.2026.10.20.00.18.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Oct 2026 00:18:33 -0700 (PDT) Message-ID: Date: Tue, 20 Oct 2026 08:18:32 +0100 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/4] ASoC: SDCA: class_function: clear sconfig.bps on PDM data-port terminals To: Pierre-Louis Bossart , Charles Keepax Cc: Mark Brown , Bard Liao , Jaroslav Kysela , Liam Girdwood , Maciej Strozek , Takashi Iwai , patches@opensource.cirrus.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org References: <20261018192359.287987-1-srinivas.kandagatla@oss.qualcomm.com> <20261018192359.287987-5-srinivas.kandagatla@oss.qualcomm.com> Content-Language: en-US From: Srinivas Kandagatla In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=aIplOr9m c=1 sm=1 tr=0 ts=6ad715cb cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=vVX-E9A3s3TWsTXgiVwA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-Spam-Info: AW1haW4tMjYxMDIwMDAyOCBTYWx0ZWRfX+z1YEbEn1VlU 7mlS5kYVvbm+iYCg5E01Iolc1Ycu7ll5rPaKwAYzL8SWSlNq78a+m4zqhADtqG4WZyTh2WnwOpy 3Xr3SztJ3zvxCDp32/lKrtP2tc27rgw= X-Proofpoint-GUID: srCM4dt9aVTMkV6z4RVV8OdzLRawey02 X-Proofpoint-ORIG-GUID: srCM4dt9aVTMkV6z4RVV8OdzLRawey02 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDIwMDAyOCBTYWx0ZWRfX62FhPvvoQSNU PBPrUNaXp244JNE3hU7jSCvUQCee1fyvpVOYAfLJT3455A35pkSORZ6bDbUUxBRLGM5sk0EzXYC 8uZMinssoc81YIMn7PjVnFNRg6YbyzMpSecAPyeIxpkqvFEl0utiD4mrYmV/CG9tgT++ireXACu /5us5LP5XlezjrZq2DZ1dgNMoaGraUIF6cXRhaPUzzV44vPlm3BSFITL8wE32xA50ftJ8PkhRZu Ky6pQ2AOckcXGa9W/9ctLcffx3TxWg0SHBS7sQVz4jIh5dTy4kb8XUVqDcbn1BHsa3lpYytKBUL xmO29Z64OwQRS/dFMV5KUnenkUhNB9J39Es0ZI9O0lwYZ9J+wSEGwtLG2fneKlyx3AK1sgzl2Yj dJzihzujLoRn9HdJY2wVeNaqZ32uEeqLJggY8LHrii3HfDL2aaj95at3l+cW4UEbuROdPITG2tm 684iaTXV2kK+iqt3CaA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-20_01,2026-10-19_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 lowpriorityscore=0 adultscore=0 bulkscore=0 suspectscore=0 spamscore=0 impostorscore=0 phishscore=0 priorityscore=1501 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610190000 definitions=main-2610200028 On 10/19/26 5:19 PM, Pierre-Louis Bossart wrote: > >>> static int class_function_sdw_add_peripheral(struct snd_pcm_substream *substream, >>> struct snd_pcm_hw_params *params, >>> struct snd_soc_dai *dai) >>> @@ -133,6 +144,7 @@ static int class_function_sdw_add_peripheral(struct snd_pcm_substream *substream >>> struct class_function_drv *drv = snd_soc_component_get_drvdata(dai->component); >>> struct sdw_stream_runtime *sdw_stream = snd_soc_dai_get_dma_data(dai, substream); >>> struct sdw_slave *sdw = dev_to_sdw_dev(drv->dev->parent); >>> + struct sdca_entity *entity = &drv->function->entities[dai->id]; >>> struct sdw_stream_config sconfig = {0}; >>> struct sdw_port_config pconfig = {0}; >>> int ret; >>> @@ -152,6 +164,9 @@ static int class_function_sdw_add_peripheral(struct snd_pcm_substream *substream >>> >>> pconfig.num = ret; >>> >>> + if (class_function_terminal_is_pdm(entity->iot.type)) >>> + sconfig.bps = 0; >> >> I think this is fine, as you say bps makes no sense for a PDM >> stream but I might need to spend a little more time working out >> how this all propagates through the core. I guess my concern is >> if other drivers don't handle PDM in the same way. > > It's a bit odd to rely on bps when we already have a type for the stream > in struct sdw_stream_config: its the stream.c which checks bps without type check, i have now updated stream.c to use type check in this code path. --srini > > @type: Stream type PCM, PDM or BPT > > >