From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 185D9C4338F for ; Sun, 15 Aug 2021 18:25:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F0ED561244 for ; Sun, 15 Aug 2021 18:25:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230165AbhHOSZy (ORCPT ); Sun, 15 Aug 2021 14:25:54 -0400 Received: from 49-237-179-185.static.tentacle.fi ([185.179.237.49]:52482 "EHLO bitmer.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229502AbhHOSZu (ORCPT ); Sun, 15 Aug 2021 14:25:50 -0400 X-Greylist: delayed 1201 seconds by postgrey-1.27 at vger.kernel.org; Sun, 15 Aug 2021 14:25:50 EDT Received: from 88-114-184-142.elisa-laajakaista.fi ([88.114.184.142] helo=[192.168.1.42]) by bitmer.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1mFKVQ-00047Y-Nw; Sun, 15 Aug 2021 21:05:08 +0300 Subject: Re: [PATCH] bus: ti-sysc: Fix error handling for sysc_check_active_timer() To: Pavel Machek , Tony Lindgren Cc: linux-omap@vger.kernel.org, Dave Gerlach , Faiz Abbas , Greg Kroah-Hartman , Grygorii Strashko , Keerthy , Nishanth Menon , Suman Anna , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20210811061053.32081-1-tony@atomide.com> <20210811062231.GA16241@duo.ucw.cz> From: Jarkko Nikula Message-ID: Date: Sun, 15 Aug 2021 21:05:04 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210811062231.GA16241@duo.ucw.cz> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi On 8/11/21 9:22 AM, Pavel Machek wrote: > On Wed 2021-08-11 09:10:53, Tony Lindgren wrote: >> We have changed the return type for sysc_check_active_timer() from -EBUSY >> to -ENXIO, but the gpt12 system timer fix still checks for -EBUSY. We are >> also not returning on other errors like we did earlier as noted by >> Pavel Machek . >> >> Commit 3ff340e24c9d ("bus: ti-sysc: Fix gpt12 system timer issue with >> reserved status") should have been updated for commit 65fb73676112 >> ("bus: ti-sysc: suppress err msg for timers used as clockevent/source"). >> >> Let's fix the issue by checking for -ENXIO and returning on any other >> errors as suggested by Pavel Machek . >> >> Fixes: 3ff340e24c9d ("bus: ti-sysc: Fix gpt12 system timer issue with reserved status") >> Depends-on: 65fb73676112 ("bus: ti-sysc: suppress err msg for timers used as clockevent/source") >> Reported-by: Pavel Machek >> Cc: Grygorii Strashko >> Cc: Jarkko Nikula >> Signed-off-by: Tony Lindgren > > Reviewed-by: Pavel Machek (CIP) > I double checked but actually both plain 0aa78d17099b ("Merge tag 'scsi-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi") and with this patch boot fine on my Beagle C2. Anyway, Tested-by: jarkko.nikula@bitmer.com