mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Manikanta Mylavarapu <quic_mmanikan@quicinc.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: <andersson@kernel.org>, <mturquette@baylibre.com>,
	<sboyd@kernel.org>, <robh@kernel.org>, <krzk+dt@kernel.org>,
	<conor+dt@kernel.org>, <linux-arm-msm@vger.kernel.org>,
	<linux-clk@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <quic_srichara@quicinc.com>,
	<quic_varada@quicinc.com>
Subject: Re: [PATCH 1/2] dt-bindings: clock: qcom: gcc-ipq5424: remove apss_dbg clock macro
Date: Fri, 6 Dec 2024 13:58:47 +0530	[thread overview]
Message-ID: <d9ec7d8f-a187-4060-a197-c145a478b70f@quicinc.com> (raw)
In-Reply-To: <dahqtkq6o6vrzfrmr76x7yd6iia4ihhcjfsaskilzw44wcjxth@ql2bkxnv6n3k>



On 12/5/2024 3:56 PM, Krzysztof Kozlowski wrote:
> On Thu, Dec 05, 2024 at 12:10:36PM +0530, Manikanta Mylavarapu wrote:
>> Since gcc_apss_dbg_clk has no consumers, the linux kernel will turn it
> 
> That's not a reason to drop a binding.
> 

Thank you for reviewing the patch.
I will drop this statement.

>> off. This causes a kernel crash because this clock is access protected
> 
> This could be. Please rephrase stating that this clock should not be
> exposed to any user because trust zone handles it and any access would
> trigger faults.
> 

I will rephrase it and include the changes in the next version.

Thanks & Regards,
Manikanta.

> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> Best regards,
> Krzysztof
> 


  reply	other threads:[~2024-12-06  8:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-05  6:40 [PATCH 0/2] Remove apss_dbg clock from IPQ5424 gcc driver Manikanta Mylavarapu
2024-12-05  6:40 ` [PATCH 1/2] dt-bindings: clock: qcom: gcc-ipq5424: remove apss_dbg clock macro Manikanta Mylavarapu
2024-12-05 10:26   ` Krzysztof Kozlowski
2024-12-06  8:28     ` Manikanta Mylavarapu [this message]
2024-12-05 10:27   ` Krzysztof Kozlowski
2024-12-06  9:00     ` Manikanta Mylavarapu
2024-12-05  6:40 ` [PATCH 2/2] clk: qcom: ipq5424: remove apss_dbg clock Manikanta Mylavarapu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d9ec7d8f-a187-4060-a197-c145a478b70f@quicinc.com \
    --to=quic_mmanikan@quicinc.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=quic_srichara@quicinc.com \
    --cc=quic_varada@quicinc.com \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®