From: Andrew Lunn <andrew@lunn.ch>
To: Weiting Lee <weiting.lee@airoha.com>
Cc: netdev@vger.kernel.org, hkallweit1@gmail.com,
linux@armlinux.org.uk, davem@davemloft.net, kuba@kernel.org,
edumazet@google.com, pabeni@redhat.com,
linux-kernel@vger.kernel.org, bjorn@mork.no, ericwouds@gmail.com,
frank-w@public-files.de, joseph.lin@airoha.com,
wenshin.chung@airoha.com, lucien.jheng@airoha.com,
albert-al.lee@airoha.com
Subject: Re: [PATCH] net: phy: air_en8811h: add dedicated suspend callback for AN8811HB
Date: Thu, 17 Sep 2026 03:56:33 +0200 [thread overview]
Message-ID: <d9ec8019-0603-4884-9bbc-d20153dba204@lunn.ch> (raw)
In-Reply-To: <20260917012102.3103131-1-weiting.lee@airoha.com>
On Thu, Sep 17, 2026 at 09:21:02AM +0800, Weiting Lee wrote:
> The AN8811HB hardware requires a re-negotiation sequence before
> entering power-down to correctly restore the link upon resume.
> Add an8811hb_suspend() to handle this.
Is there an errata for this? Please mention it in the commit message.
> +static int an8811hb_suspend(struct phy_device *phydev)
> +{
> + int ret;
> +
> + clk_save_context();
> +
> + ret = phy_modify(phydev, MII_BMCR, 0, BMCR_ANRESTART);
Why use phy_modify() if you are going to pass a mask of 0?
Andrew
prev parent reply other threads:[~2026-09-17 1:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 1:21 Weiting Lee
2026-09-17 1:56 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9ec8019-0603-4884-9bbc-d20153dba204@lunn.ch \
--to=andrew@lunn.ch \
--cc=albert-al.lee@airoha.com \
--cc=bjorn@mork.no \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ericwouds@gmail.com \
--cc=frank-w@public-files.de \
--cc=hkallweit1@gmail.com \
--cc=joseph.lin@airoha.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lucien.jheng@airoha.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=weiting.lee@airoha.com \
--cc=wenshin.chung@airoha.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®