From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39D9BC4332F for ; Tue, 19 Apr 2022 12:21:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352225AbiDSMYe (ORCPT ); Tue, 19 Apr 2022 08:24:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233378AbiDSMYc (ORCPT ); Tue, 19 Apr 2022 08:24:32 -0400 Received: from outpost1.zedat.fu-berlin.de (outpost1.zedat.fu-berlin.de [130.133.4.66]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F99C2CC90; Tue, 19 Apr 2022 05:21:50 -0700 (PDT) Received: from inpost2.zedat.fu-berlin.de ([130.133.4.69]) by outpost.zedat.fu-berlin.de (Exim 4.95) with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (envelope-from ) id 1ngmrU-000RXz-5F; Tue, 19 Apr 2022 14:21:40 +0200 Received: from p57bd9f4f.dip0.t-ipconnect.de ([87.189.159.79] helo=[192.168.178.81]) by inpost2.zedat.fu-berlin.de (Exim 4.95) with esmtpsa (TLS1.3) tls TLS_AES_128_GCM_SHA256 (envelope-from ) id 1ngmrT-003azM-Uv; Tue, 19 Apr 2022 14:21:40 +0200 Message-ID: Date: Tue, 19 Apr 2022 14:21:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] sh: make !MMU iounmap an inline function Content-Language: en-US To: Geert Uytterhoeven , Rich Felker , Yoshinori Sato Cc: Vincent Whitchurch , kernel@axis.com, Christoph Hellwig , kernel test robot , Linux-sh list , Linux Kernel Mailing List , Rob Landley , Andrew Morton , Arnd Bergmann References: <20220414081257.1487499-1-vincent.whitchurch@axis.com> <76a7b33d-6f8b-e660-c64d-027b1bc8e308@landley.net> From: John Paul Adrian Glaubitz In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Original-Sender: glaubitz@physik.fu-berlin.de X-Originating-IP: 87.189.159.79 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Geert! On 4/19/22 11:42, Geert Uytterhoeven wrote: > Hi Rich, Sato-san, > > On Sat, Apr 16, 2022 at 12:01 AM Rob Landley wrote: >> On 4/14/22 03:12, Vincent Whitchurch wrote: >>> The current definition of sh's !MMU iounmap makes it unusable in certain >>> kinds of code, such as this instance caught by 0day on a patch posted to >>> the mailing lists: >>> >>> In file included from include/linux/io.h:13, >>> from drivers/mtd/devices/phram.c:21: >>> drivers/mtd/devices/phram.c: In function 'register_device': >>> arch/sh/include/asm/io.h:274:33: error: expected expression before 'do' >>> 274 | #define iounmap(addr) do { } while (0) >>> | ^~ >>> drivers/mtd/devices/phram.c:150:44: note: in expansion of macro 'iounmap' >>> 150 | cached ? memunmap(new->mtd.priv) : iounmap(new->mtd.priv); >>> | ^~~~~~~ >>> >>> Make it an inline function as it was earlier. >>> >>> Link: https://lore.kernel.org/lkml/202204131446.omJ5mC54-lkp@intel.com/ >>> Fixes: 13f1fc870dd747131 ("sh: move the ioremap implementation out of line") >>> Reported-by: kernel test robot >>> Signed-off-by: Vincent Whitchurch >> >> Tested-by: Rob Landley >> >> Worked For Me. > > Can we please get any of [1], [2], [3], or [4] applied and sent > upstream, so people can stop wasting time on recreating and > resubmitting similar patches all the time? I agree. Those patches shouldn't be sent in vain. I very much appreciate everyone sending in patches to improve Linux support for SH which is why I find it saddening that the maintainers don't find enough time to review the patches. Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaubitz@debian.org `. `' Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913