From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0461D2E401 for ; Tue, 31 Mar 2026 11:00:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774954830; cv=none; b=s91UP0DV6sm9LR2o+ZTSm97kiQafI8F+glhWTWrLzIEx4qHTciuaZC1uFPBzejiQEBpbY9QpyG78LL39o+InQ0Td2El75jbx1awGlCtxv5bCtLhXRUIq4reTllGAnHt7IpGrL5r4N4T5kfEYi6RYMaaHHj6CJq8YYxOaHlYLxrI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774954830; c=relaxed/simple; bh=hGiALNHuqe9lChW6zej1kx4xR06ikgMYVbl+kBtn1Rw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iopXO2zpKMCenVphewB1igQMVSLHJxVObAwdUeS/WotmBLquLRN/YMSKjy07xiTOX8SeffGE5UjT9nyxsvFNFJ8O1iXcr+usFBZeAoL5PzBvyj/X3emuihNoMKYzPFoNma8Or0NasV2N3h0o9rAlsbMZ+UivUdLvizbVNtLrvZg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=M7l6MSKJ; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="M7l6MSKJ" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-43cfbd17589so2169194f8f.0 for ; Tue, 31 Mar 2026 04:00:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1774954827; x=1775559627; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=4It0WZmVl5/qXPN0CzryvWQuSnTLqQkkeu2Hra/fxBs=; b=M7l6MSKJwPvH/Azf4ahwMjNY2YgvUnWtX9myBz8fW6USCVlmrbyVfBAUjNtdJ8h2bD WzGY1FB9sZXTYQqBJOlHXFztE5H4H9zo1alPc11YhWnTTfM0/YJ3QQCVSnafgfy17lJV rP170h9gDcToOCjWsEpXt7d35JYIoLTIFS6RFkqk32op6RoBlVHLL2Ty6uXV3RWDvLs7 /akWkMy4Zu4eDY5rFC1ANGmt/x6If0C6oYGg086JBTbKcrAJFD1ABXK1hJyHEn/5ChUF SHpjuTrmIZevq9SxEEJJUrW1cwmttZKvpmovX1gUCeL3USRYxNs5A+gjsrqnqA1Mkb0e Jk1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774954827; x=1775559627; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4It0WZmVl5/qXPN0CzryvWQuSnTLqQkkeu2Hra/fxBs=; b=po23yUXf71Ub/HGygM63WNzuCrcLXBkpkYNrcYhoxKMhPsHCZTFqG2jJmkfXRP6/RI yafqrZEnB++2DMZTLrc4zQ/sKRPD4cBcuFqFUK7xE9pDSEInW51i+GQUuJRMUUjbW3HM bYrVmYkxfaBPnprwOWMenDDp7iR/aPswFZdKoRzrteq8EeDfqoe1iDt9XJLMoGFhiZQR dAA/en/supxsI035E/eQk8ad69BHY5HOs5n4YiA5Bd9nC0FbSEMnSYH+4Sb4Cr8uiviV h918HhGdGOZcQMrE8L5F7P3Z/+2DmpFf+EJrng37MD3zkPr8P/Mna6ZLkRMOOZFN4m5x AFwA== X-Forwarded-Encrypted: i=1; AJvYcCV/J4EihGBp+0MtQ+vCq/T2Nm4p3h6PTBFk5/xcaJc7IliL4xCAP2fIz3SEAYiF/31S4XuHzguvzZxAVa4=@vger.kernel.org X-Gm-Message-State: AOJu0Yzj0RlKIZrucnRoFeVTIG/UxZDjhItO4BWUV1Y+wCKek2G9ZxLY 8HjO9+2KSMVF2nm3wzFx+/oapAaAWU8NgYuxflS+qSIenFNQmWfoxo8a4H2JZvlq6oY= X-Gm-Gg: ATEYQzwwqgswVdMTKdF52bb3cuZLOs9XJeN1xTri/GcXEj+eXrR7nD03UPZn2RhXg8L BO4KBkHnouExKwlrxvW+w23acCtvTOck7WOqmBCoLzbEhsjFIr0Ztcm6zvprhL2qVeWMGF+1IDh /Ry/xim5omK9ZKdMQb6wczmt0tM7KcshSUocQOs8tYEk/T0EGITbBXNwYf1GOJTqnj4a8K2CmaX MireOdAN7IFt2HDEYJkJ+vP3tr8iY+kOoEL0zQTU9KWMDQQ5UNI0ASOSxHl6GYl3G36e56dmlT/ kbTCjz0jV6OPcfR7uxxGjEqiZcMZAeVZ08vNGxhqWtJfw0tRDueF1y/RHSvXWXURirbZwyoffYD /ZJHf+2MTYT151jaH+PZr4omTqd5RmCgJr9vSgyTghfXYgfeKVFfTkR5jayWs3FHJ/hkXRuM02/ uXFo6Yeu/fmHYkVsBD2o20cHFu6Q== X-Received: by 2002:a05:6000:2505:b0:43b:962b:5314 with SMTP id ffacd0b85a97d-43b9e9e8f39mr27390891f8f.19.1774954827290; Tue, 31 Mar 2026 04:00:27 -0700 (PDT) Received: from [192.168.0.20] ([212.21.133.10]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43cf21ebef9sm27611019f8f.13.2026.03.31.04.00.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Mar 2026 04:00:26 -0700 (PDT) Message-ID: Date: Tue, 31 Mar 2026 14:00:25 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 10/31] x86/virt/tdx: Add extra memory to TDX Module for Extensions To: Xu Yilun , linux-coco@lists.linux.dev, linux-pci@vger.kernel.org, dan.j.williams@intel.com, x86@kernel.org Cc: chao.gao@intel.com, dave.jiang@intel.com, baolu.lu@linux.intel.com, yilun.xu@intel.com, zhenzhong.duan@intel.com, kvm@vger.kernel.org, rick.p.edgecombe@intel.com, dave.hansen@linux.intel.com, kas@kernel.org, xiaoyao.li@intel.com, vishal.l.verma@intel.com, linux-kernel@vger.kernel.org References: <20260327160132.2946114-1-yilun.xu@linux.intel.com> <20260327160132.2946114-11-yilun.xu@linux.intel.com> From: Nikolay Borisov Content-Language: en-US Autocrypt: addr=nik.borisov@suse.com; keydata= xsFNBGcrpvIBEAD5cAR5+qu30GnmPrK9veWX5RVzzbgtkk9C/EESHy9Yz0+HWgCVRoNyRQsZ 7DW7vE1KhioDLXjDmeu8/0A8u5nFMqv6d1Gt1lb7XzSAYw7uSWXLPEjFBtz9+fBJJLgbYU7G OpTKy6gRr6GaItZze+r04PGWjeyVUuHZuncTO7B2huxcwIk9tFtRX21gVSOOC96HcxSVVA7X N/LLM2EOL7kg4/yDWEhAdLQDChswhmdpHkp5g6ytj9TM8bNlq9I41hl/3cBEeAkxtb/eS5YR 88LBb/2FkcGnhxkGJPNB+4Siku7K8Mk2Y6elnkOctJcDvk29DajYbQnnW4nhfelZuLNupb1O M0912EvzOVI0dIVgR+xtosp66bYTOpX4Xb0fylED9kYGiuEAeoQZaDQ2eICDcHPiaLzh+6cc pkVTB0sXkWHUsPamtPum6/PgWLE9vGI5s+FaqBaqBYDKyvtJfLK4BdZng0Uc3ijycPs3bpbQ bOnK9LD8TYmYaeTenoNILQ7Ut54CCEXkP446skUMKrEo/HabvkykyWqWiIE/UlAYAx9+Ckho TT1d2QsmsAiYYWwjU8igXBecIbC0uRtF/cTfelNGrQwbICUT6kJjcOTpQDaVyIgRSlUMrlNZ XPVEQ6Zq3/aENA8ObhFxE5PLJPizJH6SC89BMKF3zg6SKx0qzQARAQABzSZOaWtvbGF5IEJv cmlzb3YgPG5pay5ib3Jpc292QHN1c2UuY29tPsLBkQQTAQoAOxYhBDuWB8EJLBUZCPjT3SRn XZEnyhfsBQJnK6byAhsDBQsJCAcCAiICBhUKCQgLAgQWAgMBAh4HAheAAAoJECRnXZEnyhfs XbIQAJxuUnelGdXbSbtovBNm+HF3LtT0XnZ0+DoR0DemUGuA1bZAlaOXGr5mvVbTgaoGUQIJ 3Ejx3UBEG7ZSJcfJobB34w1qHEDO0pN9orGIFT9Bic3lqhawD2r85QMcWwjsZH5FhyRx7P2o DTuUClLMO95GuHYQngBF2rHHl8QMJPVKsR18w4IWAhALpEApxa3luyV7pAAqKllfCNt7tmed uKmclf/Sz6qoP75CvEtRbfAOqYgG1Uk9A62C51iAPe35neMre3WGLsdgyMj4/15jPYi+tOUX Tc7AAWgc95LXyPJo8069MOU73htZmgH4OYy+S7f+ArXD7h8lTLT1niff2bCPi6eiAQq6b5CJ Ka4/27IiZo8tm1XjLYmoBmaCovqx5y5Xt2koibIWG3ZGD2I+qRwZ0UohKRH6kKVHGcrmCv0J YO8yIprxgoYmA7gq21BpTqw3D4+8xujn/6LgndLKmGESM1FuY3ymXgj5983eqaxicKpT9iq8 /a1j31tms4azR7+6Dt8H4SagfN6VbJ0luPzobrrNFxUgpjR4ZyQQ++G7oSRdwjfIh1wuCF6/ mDUNcb6/kA0JS9otiC3omfht47yQnvod+MxFk1lTNUu3hePJUwg1vT1te3vO5oln8lkUo9BU knlYpQ7QA2rDEKs+YWqUstr4pDtHzwQ6mo0rqP+zzsFNBGcrpvIBEADGYTFkNVttZkt6e7yA LNkv3Q39zQCt8qe7qkPdlj3CqygVXfw+h7GlcT9fuc4kd7YxFys4/Wd9icj9ZatGMwffONmi LnUotIq2N7+xvc4Xu76wv+QJpiuGEfCDB+VdZOmOzUPlmMkcJc/EDSH4qGogIYRu72uweKEq VfBI43PZIGpGJ7TjS3THX5WVI2YNSmuwqxnQF/iVqDtD2N72ObkBwIf9GnrOgxEyJ/SQq2R0 g7hd6IYk7SOKt1a8ZGCN6hXXKzmM6gHRC8fyWeTqJcK4BKSdX8PzEuYmAJjSfx4w6DoxdK5/ 9sVrNzaVgDHS0ThH/5kNkZ65KNR7K2nk45LT5Crjbg7w5/kKDY6/XiXDx7v/BOR/a+Ryo+lM MffN3XSnAex8cmIhNINl5Z8CAvDLUtItLcbDOv7hdXt6DSyb65CdyY8JwOt6CWno1tdjyDEG 5ANwVPYY878IFkOJLRTJuUd5ltybaSWjKIwjYJfIXuoyzE7OL63856MC/Os8PcLfY7vYY2LB cvKH1qOcs+an86DWX17+dkcKD/YLrpzwvRMur5+kTgVfXcC0TAl39N4YtaCKM/3ugAaVS1Mw MrbyGnGqVMqlCpjnpYREzapSk8XxbO2kYRsZQd8J9ei98OSqgPf8xM7NCULd/xaZLJUydql1 JdSREId2C15jut21aQARAQABwsF2BBgBCgAgFiEEO5YHwQksFRkI+NPdJGddkSfKF+wFAmcr pvICGwwACgkQJGddkSfKF+xuuxAA4F9iQc61wvAOAidktv4Rztn4QKy8TAyGN3M8zYf/A5Zx VcGgX4J4MhRUoPQNrzmVlrrtE2KILHxQZx5eQyPgixPXri42oG5ePEXZoLU5GFRYSPjjTYmP ypyTPN7uoWLfw4TxJqWCGRLsjnkwvyN3R4161Dty4Uhzqp1IkNhl3ifTDYEvbnmHaNvlvvna 7+9jjEBDEFYDMuO/CA8UtoVQXjy5gtOhZZkEsptfwQYc+E9U99yxGofDul7xH41VdXGpIhUj 4wjd3IbgaCiHxxj/M9eM99ybu5asvHyMo3EFPkyWxZsBlUN/riFXGspG4sT0cwOUhG2ZnExv XXhOGKs/y3VGhjZeCDWZ+0ZQHPCL3HUebLxW49wwLxvXU6sLNfYnTJxdqn58Aq4sBXW5Un0Q vfbd9VFV/bKFfvUscYk2UKPi9vgn1hY38IfmsnoS8b0uwDq75IBvup9pYFyNyPf5SutxhFfP JDjakbdjBoYDWVoaPbp5KAQ2VQRiR54lir/inyqGX+dwzPX/F4OHfB5RTiAFLJliCxniKFsM d8eHe88jWjm6/ilx4IlLl9/MdVUGjLpBi18X7ejLz3U2quYD8DBAGzCjy49wJ4Di4qQjblb2 pTXoEyM2L6E604NbDu0VDvHg7EXh1WwmijEu28c/hEB6DwtzslLpBSsJV0s1/jE= In-Reply-To: <20260327160132.2946114-11-yilun.xu@linux.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 27.03.26 г. 18:01 ч., Xu Yilun wrote: > Adding more memory to TDX Module is the first step to enable Extensions. > > Currently, TDX Module memory use is relatively static. But, some new > features (called "TDX Module Extensions") need to use memory more > dynamically. While 'static' here means the kernel provides necessary > amount of memory to TDX Module for its basic functionalities, 'dynamic' > means extra memory is needed only if new optional features are to be > enabled. So add a new memory feeding process backed by a new SEAMCALL > TDH.EXT.MEM.ADD. > > The process is mostly the same as adding PAMT. The kernel queries TDX > Module how much memory needed, allocates it, hands it over, and never > gets it back. > > TDH.EXT.MEM.ADD uses tdx_page_array to provide control (private) pages > to TDX Module. Introduce a tdx_clflush_page_array() helper to flush > shared cache before SEAMCALL, to avoid shared cache write back damages > these private pages. > > For now, TDX Module Extensions consume relatively large amount of > memory (~50MB). Use contiguous page allocation to avoid permanently > fragment too much memory. Print this readout value on TDX Module > Extensions initialization for visibility. > > Co-developed-by: Zhenzhong Duan > Signed-off-by: Zhenzhong Duan > Signed-off-by: Xu Yilun > --- > arch/x86/virt/vmx/tdx/tdx.h | 1 + > arch/x86/virt/vmx/tdx/tdx.c | 92 ++++++++++++++++++++++++++++++++++++- > 2 files changed, 91 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/virt/vmx/tdx/tdx.h b/arch/x86/virt/vmx/tdx/tdx.h > index 870bb75da3ba..31ccdfcf518c 100644 > --- a/arch/x86/virt/vmx/tdx/tdx.h > +++ b/arch/x86/virt/vmx/tdx/tdx.h > @@ -60,6 +60,7 @@ > #define TDH_VP_WR 43 > #define TDH_SYS_CONFIG_V0 45 > #define TDH_SYS_CONFIG SEAMCALL_LEAF_VER(TDH_SYS_CONFIG_V0, 1) > +#define TDH_EXT_MEM_ADD 61 > > /* TDX page types */ > #define PT_NDA 0x0 > diff --git a/arch/x86/virt/vmx/tdx/tdx.c b/arch/x86/virt/vmx/tdx/tdx.c > index 4fb56bb442f0..5fae17c13191 100644 > --- a/arch/x86/virt/vmx/tdx/tdx.c > +++ b/arch/x86/virt/vmx/tdx/tdx.c > @@ -560,7 +560,7 @@ static int tdx_alloc_pages_contig(unsigned int nr_pages, struct page **pages, > * Similar to tdx_page_array_alloc(), after allocating with this > * function, call tdx_page_array_populate() to populate the tdx_page_array. > */ > -static __maybe_unused struct tdx_page_array * > +static struct tdx_page_array * > tdx_page_array_alloc_contig(unsigned int nr_pages) > { > return tdx_page_array_alloc(nr_pages, tdx_alloc_pages_contig, NULL); > @@ -643,7 +643,7 @@ EXPORT_SYMBOL_GPL(tdx_page_array_create_iommu_mt); > #define HPA_LIST_INFO_PFN GENMASK_U64(51, 12) > #define HPA_LIST_INFO_LAST_ENTRY GENMASK_U64(63, 55) > > -static u64 __maybe_unused hpa_list_info_assign_raw(struct tdx_page_array *array) > +static u64 hpa_list_info_assign_raw(struct tdx_page_array *array) > { > return FIELD_PREP(HPA_LIST_INFO_FIRST_ENTRY, 0) | > FIELD_PREP(HPA_LIST_INFO_PFN, > @@ -1513,6 +1513,94 @@ static void tdx_clflush_page(struct page *page) > clflush_cache_range(page_to_virt(page), PAGE_SIZE); > } > > +static void tdx_clflush_page_array(struct tdx_page_array *array) > +{ > + for (int i = 0; i < array->nents; i++) shouldn't the actual number of entries be adjusted as per offset, similarly to how 'nents' in tdx_page_array_validate_release is calculated?