From: Icenowy Zheng <zhengxingda@iscas.ac.cn>
To: Doug Anderson <dianders@chromium.org>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
Jessica Zhang <jesszhan0024@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Cong Yang <yangcong5@huaqin.corp-partner.google.com>,
David Airlie <airlied@gmail.com>,
Simona Vetter <simona@ffwll.ch>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] drm/panel: himax-hx83102: restore MODE_LPM after sending disable cmds
Date: Tue, 28 Apr 2026 13:49:50 +0800 [thread overview]
Message-ID: <d9faab05aab120fee367394edcb35bd131c97646.camel@iscas.ac.cn> (raw)
In-Reply-To: <CAD=FV=VXD34ZZTH4MJUtZ6xifbbjp1cLRBd_xvz=3T12G4tKYw@mail.gmail.com>
在 2026-04-27一的 11:24 -0700,Doug Anderson写道:
> Hi,
>
> On Sat, Apr 25, 2026 at 9:58 AM Icenowy Zheng
> <zhengxingda@iscas.ac.cn> wrote:
> >
> > When preparing the panel, it seems that it always expects commands
> > to be
> > transferred in LP mode. However, the disable function removes the
> > MIPI_DSI_MODE_LPM flag, and no other function re-adds it.
> >
> > As the unprepare function contains no DSI commands, re-adding the
> > flag
> > just after disabling the panel should be safe. Add the code re-
> > adding
> > the flag after the two commands for disabling the panel are sent.
> >
> > This fixes screen unblanking (after blanking once) on
> > mt8188-geralt-ciri-sku1 device.
> >
> > Cc: stable@vger.kernel.org # 6.11+
> > Fixes: 0ef94554dc40 ("drm/panel: himax-hx83102: Break out as
> > separate driver")
>
> This "Fixes" looks wrong. The bug was still there even before the
> driver was broken out. ...and it looks like the driver that this was
> broken out of (panel-boe-tv101wum-nl6.c) still has the same bug?
Yes, but I think the fix shouldn't be propagated to the other driver
because of the same reason with breaking out the original driver.
I have a device with a panel driven by the nl6 driver (device is
mt8183-kukui-kodama-sku32, panel is boe,tv101wum-n53), it shows the
same DSI timeout error message with ciri sku1, but the screen do come
back to life when unblanking. Maybe this fix should propagate there,
but I need more confirmation.
Thanks,
Icenowy
>
> -Doug
next prev parent reply other threads:[~2026-04-28 5:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-25 16:57 Icenowy Zheng
2026-04-27 7:46 ` Neil Armstrong
2026-04-27 18:24 ` Doug Anderson
2026-04-28 5:49 ` Icenowy Zheng [this message]
2026-04-28 15:48 ` Doug Anderson
2026-04-28 15:53 ` Icenowy Zheng
2026-04-28 15:56 ` Doug Anderson
2026-04-28 16:12 ` Icenowy Zheng
2026-04-28 20:52 ` Doug Anderson
2026-05-04 22:47 ` Doug Anderson
2026-05-05 12:51 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9faab05aab120fee367394edcb35bd131c97646.camel@iscas.ac.cn \
--to=zhengxingda@iscas.ac.cn \
--cc=airlied@gmail.com \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jesszhan0024@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=simona@ffwll.ch \
--cc=stable@vger.kernel.org \
--cc=tzimmermann@suse.de \
--cc=yangcong5@huaqin.corp-partner.google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®