From: Shuah Khan <skhan@linuxfoundation.org>
To: David Gow <davidgow@google.com>,
Rikard Falkeborn <rikard.falkeborn@gmail.com>,
Shuah Khan <shuah@kernel.org>
Cc: "open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
Brendan Higgins <brendanhiggins@google.com>,
masahiroy@kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
skhan@linuxfoundation.org
Subject: Re: [PATCH] kunit: kunit_config: Fix parsing of CONFIG options with space
Date: Wed, 1 Jul 2020 13:10:34 -0600 [thread overview]
Message-ID: <da025a82-17ee-e8bb-61dd-e655f0087d8f@linuxfoundation.org> (raw)
In-Reply-To: <CABVgOSnqyqg8xPT2wM=taN2=pPTAm_ySD-WscHuBW175QipuEw@mail.gmail.com>
On 6/30/20 1:15 AM, David Gow wrote:
> On Mon, Jun 8, 2020 at 5:57 AM Rikard Falkeborn
> <rikard.falkeborn@gmail.com> wrote:
>>
>> Commit 8b59cd81dc5e ("kbuild: ensure full rebuild when the compiler is
>> updated") introduced a new CONFIG option CONFIG_CC_VERSION_TEXT. On my
>> system, this is set to "gcc (GCC) 10.1.0" which breaks KUnit config
>> parsing which did not like the spaces in the string.
>>
>> Fix this by updating the regex to allow strings containing spaces.
>>
>> Fixes: 8b59cd81dc5e ("kbuild: ensure full rebuild when the compiler is updated")
>> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
>
> Tested-by: David Gow <davidgow@google.com>
>
> I've been using this patch quite a bit, and haven't hit any problems.
>
> +Shuah: Any chance we get this into the kunit branch sooner rather
> than later? The KUnit tooling is quite broken without it.
>
Applied to linux-kselftest kunit
https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/log/?h=kunit
thanks,
-- Shuah
prev parent reply other threads:[~2020-07-01 19:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-07 21:57 Rikard Falkeborn
2020-06-09 19:58 ` Brendan Higgins
2020-06-30 7:15 ` David Gow
2020-07-01 19:10 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da025a82-17ee-e8bb-61dd-e655f0087d8f@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=brendanhiggins@google.com \
--cc=davidgow@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=rikard.falkeborn@gmail.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome