From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8972B3090CB for ; Mon, 5 Jan 2026 16:47:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767631648; cv=none; b=UZc8hFPhGouKjfTWutlA0NfIfo8RMbdQmUx3bIOVUY2EQ6y81vx4pLta20McBu5U0/I1LveUOjXy3Sf1R6TGVokGXtXt5iROXJj0OQ9h/3Y9WXijYVLUNWYotEtxSsPyMHSd2/CwfTf4zD1ZDRHkh7pO2SVOTPnwWgnBeFQob+M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767631648; c=relaxed/simple; bh=ERyjgMpetsSV7HmNF4hsqF0bdrmrio7r57PRd234Lqw=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=TknjoxpKBi3wHrmmwAIRvsjZ18hqe+uH3tUkUAOSkWkVOEFKGwiK5E24wDN5tbeBztV33XMn69baKc0iuEmJvD5m58EwitL7xPwZJzS/lWGoG9OqunBxxell2sxbMA9eVCB/4RsXzRxeUHrfhFFYwe0GXCDct9EKZI9OvbWwXUw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=hXQSiz1I; arc=none smtp.client-ip=209.85.218.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="hXQSiz1I" Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-b73161849e1so31168566b.2 for ; Mon, 05 Jan 2026 08:47:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767631644; x=1768236444; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=ERyjgMpetsSV7HmNF4hsqF0bdrmrio7r57PRd234Lqw=; b=hXQSiz1IbgYsEUmS8z5i1yZH/6aox1AulKzNjsOIcwLeXzKFL8WYcNRDbje1eKtLu7 d0M795RfyUcvz1hZnCS0HR1MK9lXhNgtrh08XBh8SEGeJtN6+zuhFu8FTKyV1Wn80YdI sbSjd7QtQIArli8keY6GmS+GgpUkT9EpqCuDU9jVVogmarmZk3YK4mM+rF6KDTuors55 buWUKbbtnovQTnZ5lIVgSMW6ngZHVU/IMV9leuTQtU1y+MyWkh9KNFXKhG6PgTwTIlej uYg+FbrbY6v36jSRnQmouRcitZZB4wJjYA/oI1h6YgR2NPPHcJ30HIYx3h75eSJpQ4z+ oVwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767631644; x=1768236444; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ERyjgMpetsSV7HmNF4hsqF0bdrmrio7r57PRd234Lqw=; b=gdh200D03ExwRlqepReS5xdnQdFFlOZ04D+bfhPbHBil2slLnqv78vfe9dUIiU9FGZ G/GJKgHv6Uq6XMCVHXindBmkl3T0he/7R8JeaXuol0MCEPPuCdL+gbIxkhyJdtH8zSes IL0/Gk0zEHIPyhsvOXiDzPgz4shqu0FTGPzSQaOiHonCBx6kd5KpRxE68ALz9KQ72Z9h bbPBDijQXSbhd6qHfXJUnZ34zqcK/wp0Wje33RvfFQVVeIv/+ixH/DwEzwsj70YZHE9C pGjjZgEwbKJFFtLf9bPM6F3oikaH/bvvJBU0bK7rulkZ9L2WOhbA32Lvu3/3DlaQf5iO YRnA== X-Gm-Message-State: AOJu0YxEc1KUyub4KeuGmdSZP1zo2XvlLUUU0Nhgh0vqqpxSXtrv3UdN B70fjX80j0ZM0ge4FJtcmcx3/AvNkU4g1rdGfbAZ6TN5f7yLuEZ3tpcCWd03gKqfsns= X-Gm-Gg: AY/fxX6KxHmp0sBrLOHCGiFhnmi67DOWSA73i+t0HE1F77fzhZFnKNJhXxV/8gtaH4g aRy0ntI3MX0W5nHJsbP6W1xOjoug5/9knZZRgMnajuw1Oi5zUxfdUbtn68jJPb2lzfoNv/lOtY7 ie5RDOASkE1KEDb33OjgSHw6AcLVLjefgtVQBbm///SxCBGZkKMnNxHs6c8UX7xF5cbSQvSkPmi fCZ7jYkpffyFNbOJFrRW1RTYI/RRrqvRyWvZft10YnO76iB0agCx4xzYXN4JV0tSmY/wtaufoed UdcJXfzBBzLja9dv6s3C1720GFJvfhfovKyAOAvL544rO12B5nMp2HddzIE0Avm9Yd5E9Rtd6kf HqQrN4/8wN3sC59NEqXvi7sF0FSvE/raCcXgGq2jCuVLC7yjFC5ZDsmBfSxcAXARWMR5W0I0AC1 CalgWfVNKJUGhGD1cx/A== X-Google-Smtp-Source: AGHT+IH8PrChGbBe3ifcPMF0XNauYBYKXVAb42mE0WG2Oe4GF884wrbNFmqGeNp3hqqHYpAdiAIsJg== X-Received: by 2002:a17:907:706:b0:b77:f4a:ca1b with SMTP id a640c23a62f3a-b8426a6c79amr36443666b.16.1767631643937; Mon, 05 Jan 2026 08:47:23 -0800 (PST) Received: from draszik.lan ([212.129.74.225]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6507618cc59sm255498a12.28.2026.01.05.08.47.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Jan 2026 08:47:23 -0800 (PST) Message-ID: Subject: Re: [PATCH v3 5/5] usb: typec: tcpm/tcpci_maxim: deprecate WAR for setting charger mode From: =?ISO-8859-1?Q?Andr=E9?= Draszik To: amitsd@google.com, Sebastian Reichel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lee Jones , Greg Kroah-Hartman , Badhri Jagan Sridharan , Heikki Krogerus , Peter Griffin , Tudor Ambarus , Alim Akhtar Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, RD Babiera , Kyle Tso Date: Mon, 05 Jan 2026 16:47:58 +0000 In-Reply-To: <20251227-max77759-charger-v3-5-54e664f5ca92@google.com> References: <20251227-max77759-charger-v3-0-54e664f5ca92@google.com> <20251227-max77759-charger-v3-5-54e664f5ca92@google.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2-2+build3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Sat, 2025-12-27 at 00:04 +0000, Amit Sunil Dhamne via B4 Relay wrote: > From: Amit Sunil Dhamne >=20 > TCPCI maxim driver directly writes to the charger's register space to > set charger mode depending on the power role. As MAX77759 chg driver > exists, this WAR is not required. >=20 > Instead, use a regulator interface to source vbus when typec is in > source power mode. In other power modes, this regulator will be turned > off if active. >=20 > Signed-off-by: Amit Sunil Dhamne > --- > =C2=A0drivers/usb/typec/tcpm/tcpci_maxim.h=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 = |=C2=A0 1 + > =C2=A0drivers/usb/typec/tcpm/tcpci_maxim_core.c | 54 +++++++++++++++++++-= ----------- > =C2=A02 files changed, 34 insertions(+), 21 deletions(-) Reviewed-by: Andr=C3=A9 Draszik