From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B95193148D3 for ; Fri, 13 Mar 2026 10:48:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773398894; cv=none; b=K6R71PJ3BS8XvhJVHzQulUyNRSWg/qRoBaXuqpreBe5a7tAUTxE2MiGejM3ie2zVCwQVtk4oGPOgjOZggmgaexKT58gFrAPgmaMqGkPvukp4v163gQ9bPBO79PoBdjAIrHi+psxOkumK2JxBJd6lKB6dJQ4ewF1odibuGGXU9Io= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773398894; c=relaxed/simple; bh=zzplZJ4Qyk51rYHGGTOx2eXlOHiYAraldVZ2IfKSWm0=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=Ypu65+L6kOwShw71HfEDGUIbzBzCKtGyny0Dem+trRMoM0Mz8uWonsD/7kkDjMWufz7I7MWVK8VNHyJjrM76RK+hubCg7TsFur4gWDDwL6t+mHSUKFJMlJ8zpYex1Ld/n3gJAZCapPDB+UxDEUZlsT5CFYsPwWIa/Sulc+yFZAk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=fQfqXbF3; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fQfqXbF3" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-439b9cf8cb5so2292223f8f.0 for ; Fri, 13 Mar 2026 03:48:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773398891; x=1774003691; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=zzplZJ4Qyk51rYHGGTOx2eXlOHiYAraldVZ2IfKSWm0=; b=fQfqXbF3hXT91xZVm4lwyVdXMB2ZYGv2r6RtxrqBmzJzZmL8zLLHGZlhOeY9RTFHXs YVi8VRkcWNiGQFfvO4lW2syuRnxBVQiE8Qm+xyBIyfnezP1K42bVBnNa6Fpbbr/aedM9 wY9GvGNiinCYZlBKH1MeWicNKtkaN3j3sne2l3IAcfzKF5CQVzd//1847fbo8Dg2Y9ng fRtPAHlBPl/0+hRshaq+LhRhJrgIVKDj9IpSrwbjrfGhJXaUF11E+tXa6XZo4sVNZQp/ o9oZlZPy5gd1t9tWymKlDpTtIdc3o9uFG7QZoOAHFFoNnx1KLNWAgUKftvVlA4i1Zgeo imKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773398891; x=1774003691; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zzplZJ4Qyk51rYHGGTOx2eXlOHiYAraldVZ2IfKSWm0=; b=GC+GqMwPdjJhc8X8JMOHvQ5r4KipGwspZi+fSMx+QyIFfKsfqRZzxBRvtf2hNMnYTt UgSNQdVt44PVJgFrHJrJGW3sKpWVdsPKKqdkcYcQ6hwG8lV6zVcdv7rVx3jZR8CJd7FU odaCrp4WRZT7kbTJmcpX9x7sOcOf8uSkCqE4dUhvTjsK6Febjxig+iW/b2xjr2F8U0MS LxtYPu0W8wecLFbdtt+ZlsKnRoVyupWvYoEhpzPNuDjNUYJmtcpsGgrl5Qy+wYRFBtli 3JkbLcx+uzJ5QNxU/kYQPV/ULjon3cD3xhCYXzrBzwn5B0F3OReaPW2wtP8TAzxcPjP9 vLBA== X-Forwarded-Encrypted: i=1; AJvYcCUHwtr8TzPiMBD17UGlQHvYdoHKlYy6qZheDapbaYqqBQTb0R6PKBU3msO9ZJf2Aa8UKx+4z2Hrnj9MEpk=@vger.kernel.org X-Gm-Message-State: AOJu0YxkzH87kAUa6+LXQsEBb49ROx1LoBxhKz2dKE/c5pHPc75w9jp2 6UrfEZHFFxiLVZQ9OiA7szRsifMdqNE1c9Av/stDgzNhSVUI9jHAJPlffTxi2BDlSD8= X-Gm-Gg: ATEYQzzzheBGCO7Svb06rG8jgE5ChQqrs1tDWuRMK9/XC6e5l2MNefZayOMYLDn/cOV tUau+6rPyxp3Rge0p0l0w2kYrwFONPBYDjYRzgi+/GjzGwKi9zOxHXfndN+7iFh+hUaPqkhzDW9 XmfGuMNZaR2bQY93YQ9uKynai5f/awLCtZwYdvui+XY70sa6X60DCmoFfGg67oiKhttPhyseXBA 0rYaQvml1EA/pROs3o+kxbNShGEbcQI/QW93D3FGTi73tQNr/DxKfA2pjYi5+RlwgCwBS4hMCOZ ll0eQSC7Nfms46N5ZiJNxAkR6qd9v6KDAkzB8DhMfx+KJA5Fk0CDq3kIetFWMy9wIh1WcxQ1cUJ 0JtvvVH5huecFn5fvGv06fVONASrIMqRTt8ukZk23V1QDtatwpg63MaMXamAo4M/IM6qtKkWH13 80tA0bcJYIbBNXIvbJkFwvC8qcEAMKnz1B10gA8qOj X-Received: by 2002:a5d:588b:0:b0:439:b114:60c2 with SMTP id ffacd0b85a97d-43a04db64b2mr5501570f8f.34.1773398890938; Fri, 13 Mar 2026 03:48:10 -0700 (PDT) Received: from draszik.lan ([212.129.81.187]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439fe19b936sm19109536f8f.5.2026.03.13.03.48.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Mar 2026 03:48:10 -0700 (PDT) Message-ID: Subject: Re: [PATCH v7 04/10] dt-bindings: soc: google: gs101-pmu: allow power domains as children From: =?ISO-8859-1?Q?Andr=E9?= Draszik To: Rob Herring Cc: Krzysztof Kozlowski , Alim Akhtar , Conor Dooley , Krzysztof Kozlowski , Ulf Hansson , Liam Girdwood , Mark Brown , Peter Griffin , Tudor Ambarus , Juan Yescas , Will McVicker , kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Date: Fri, 13 Mar 2026 10:48:55 +0000 In-Reply-To: <20260312151228.GA3136988-robh@kernel.org> References: <20260306-gs101-pd-v7-0-03f7c7965ba5@linaro.org> <20260306-gs101-pd-v7-4-03f7c7965ba5@linaro.org> <20260312151228.GA3136988-robh@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2-8+build1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Thu, 2026-03-12 at 10:12 -0500, Rob Herring wrote: > On Fri, Mar 06, 2026 at 10:29:55AM +0000, Andr=C3=A9 Draszik wrote: >=20 > > =C2=A0=C2=A0=C2=A0=C2=A0 system-controller@17460000 { > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 compatible =3D "google= ,gs101-pmu"; > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 reg =3D <0x17460000 0x= 10000>; > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 #address-cells =3D <1>; > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 #size-cells =3D <1>; > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ranges; > > =C2=A0 > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 google,pmu-intr-gen-sy= scon =3D <&pmu_intr_gen>; > > + > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 pd_g3d: power-domain@1e00 { > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 com= patible =3D "google,gs101-pd"; > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 reg= =3D <0x1e00 0x80>; >=20 > I'm assuming 0x1e00 is an offset from 0x17460000. That's not what ranges= =20 > says though. It says both addresses are in the same address space=20 > (system-controller@17460000 parent's address space). You need: >=20 > ranges =3D <0x0 0x17460000 0x10000>; Thanks Rob! On gs101, the PD driver can not do direct mmio. Instead it needs to use the regmap that the parent has created and apply the offset from the PD's reg property (using struct resource::start) (patch 7). When using ranges as per your suggestion that doesn't work anymore, as resource->start isn't the offset anymore but the final physical address, and using that in combination with the parent's regmap doesn't give us the right address anymore. Is there an alternative other than using completely arbitrary indices like e.g. rockchip is doing? Cheers, Andre'