mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Manuel Traut <manut@mecka.net>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Jessica Zhang <quic_jesszhan@quicinc.com>,
	Sam Ravnborg <sam@ravnborg.org>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Heiko Stuebner <heiko@sntech.de>,
	Sandy Huang <hjc@rock-chips.com>,
	Mark Yao <markyao0591@gmail.com>,
	Diederik de Haas <didi.debian@cknow.org>,
	Segfault <awarnecke002@hotmail.com>,
	Arnaud Ferraris <aferraris@debian.org>
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org
Subject: Re: [PATCH 6/6] dt-bindings: display: rockchip: dw-hdmi: Add missing sound-dai-cells property
Date: Fri, 22 Dec 2023 17:05:26 +0100	[thread overview]
Message-ID: <da0ba7fd-4704-42d5-8d7b-f033cb68d259@linaro.org> (raw)
In-Reply-To: <20231222-pinetab2-v1-6-e148a7f61bd1@mecka.net>

On 22/12/2023 12:05, Manuel Traut wrote:
> The sound-dai-cells property is used, e.g. in rk356x.dtsi

Better to see here rather explanation why dai cells are needed, unless
you aren't sure and just want to fix warning.

> 
> Signed-off-by: Manuel Traut <manut@mecka.net>
> ---
>  .../devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml        | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml
> index 7e59dee15a5f..43250255fb6f 100644
> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml
> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml
> @@ -94,6 +94,9 @@ properties:
>        - const: default
>        - const: unwedge
>  

Please add $ref to dai-common.yaml in allOf.

	
> +  '#sound-dai-cells':
> +    const: 0
> +

Best regards,
Krzysztof


  reply	other threads:[~2023-12-22 16:05 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-22 11:05 [PATCH 0/6] arm64: rockchip: Pine64 pinetab2 support Manuel Traut
2023-12-22 11:05 ` [PATCH 1/6] dt-bindings: display: panel: Add BOE TH101MB31IG002-28A panel Manuel Traut
2023-12-22 16:01   ` Krzysztof Kozlowski
2023-12-22 16:30   ` Diederik de Haas
2023-12-22 11:05 ` [PATCH 2/6] drm/panel: Add driver for " Manuel Traut
2023-12-22 18:25   ` Fabio Estevam
2023-12-26 22:51   ` Jessica Zhang
2023-12-22 11:05 ` [PATCH 3/6] dt-bindings: arm64: rockchip: Add Pine64 Pinetab2 Manuel Traut
2023-12-22 16:02   ` Krzysztof Kozlowski
2023-12-22 11:05 ` [PATCH 4/6] arm64: dts: rockchip: Add devicetree for " Manuel Traut
2023-12-22 16:49   ` Diederik de Haas
2023-12-23 14:03     ` Manuel Traut
2023-12-22 17:01   ` Diederik de Haas
2023-12-23 13:59     ` Manuel Traut
2023-12-23 14:17       ` Diederik de Haas
2023-12-23  9:48   ` Dang Huynh
2023-12-22 11:05 ` [PATCH 5/6] arm64: dts: rockchip: Fix some dtb-check warnings Manuel Traut
2023-12-22 16:07   ` Krzysztof Kozlowski
2023-12-23 11:43   ` Heiko Stübner
2023-12-22 11:05 ` [PATCH 6/6] dt-bindings: display: rockchip: dw-hdmi: Add missing sound-dai-cells property Manuel Traut
2023-12-22 16:05   ` Krzysztof Kozlowski [this message]
2023-12-22 16:51 ` [PATCH 0/6] arm64: rockchip: Pine64 pinetab2 support Diederik de Haas
2023-12-23 11:01   ` Manuel Traut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=da0ba7fd-4704-42d5-8d7b-f033cb68d259@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=aferraris@debian.org \
    --cc=airlied@gmail.com \
    --cc=awarnecke002@hotmail.com \
    --cc=conor+dt@kernel.org \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=didi.debian@cknow.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=heiko@sntech.de \
    --cc=hjc@rock-chips.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=manut@mecka.net \
    --cc=markyao0591@gmail.com \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=quic_jesszhan@quicinc.com \
    --cc=robh+dt@kernel.org \
    --cc=sam@ravnborg.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®