From: Andrew Lunn <andrew@lunn.ch>
To: Simon Horman <horms@kernel.org>
Cc: Masahiro Yamada <masahiroy@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ethernet: remove duplicated CONFIG_SUNGEM_PHY entry
Date: Thu, 8 Feb 2024 00:39:01 +0100 [thread overview]
Message-ID: <da0e7982-9aa7-4b02-97da-7f580085a1d6@lunn.ch> (raw)
In-Reply-To: <20240206174130.GF1104779@kernel.org>
On Tue, Feb 06, 2024 at 05:41:30PM +0000, Simon Horman wrote:
> On Sun, Feb 04, 2024 at 09:31:51PM +0900, Masahiro Yamada wrote:
> > Both drivers/net/Kconfig and drivers/net/ethernet/Kconfig contain the
> > same config entry:
> >
> > config SUNGEM_PHY
> > tristate
> >
> > Commit f860b0522f65 ("drivers/net: Kconfig and Makefile cleanup") moved
> > SUNGEM_PHY from drivers/net/Kconfig to drivers/net/ethernet/Kconfig.
> >
> > Shortly after it was applied, commit 19e2f6fe9601 ("net: Fix sungem_phy
> > sharing.") added the second one to drivers/net/Kconfig.
> >
> > I kept the one in drivers/net/Kconfig because this CONFIG option controls
> > the compilation of drivers/net/sungem_phy.c.
> >
> > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
>
> Thanks Yamada-san,
>
> This looks good to me as-is,
> but I guess a follow-up question is if sungem_phy.c
> should move to drivers/net/phy.
It is not a phylib PHY driver. So i would say no.
It would however be nice to port the MAC drivers using this to
phylib. The PHY devices this sungem_phy.c supports don't look
particularly exotic, just Marvell and Broadcom PHYs which phylib
probably already supports.
Andrew
next prev parent reply other threads:[~2024-02-07 23:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-04 12:31 Masahiro Yamada
2024-02-06 17:41 ` Simon Horman
2024-02-07 23:39 ` Andrew Lunn [this message]
2024-02-07 13:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da0e7982-9aa7-4b02-97da-7f580085a1d6@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®