From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FF1BC433EF for ; Thu, 10 Feb 2022 10:01:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239279AbiBJKBA (ORCPT ); Thu, 10 Feb 2022 05:01:00 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:46824 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239249AbiBJKA5 (ORCPT ); Thu, 10 Feb 2022 05:00:57 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 6EAF6BE0 for ; Thu, 10 Feb 2022 02:00:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644487258; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=j6iG/zRSXBJr0V+KQL6qsWdT16lcc2ezAm1Oyf7IUXI=; b=F1FQTSpv8TfYIcVmibJX+UszlxwUkqwnZnJBYkLxlHdocWC+UY1cebpq1+gOCjnt9xLkaN FELRDC4haOiCBdukmuP/4s7c24rekpytAJmlqck9HQOWr3E808TvT+FZtA6sN7ysYvuyeD nPiAmv4auYFwiZ0gfFukU2DbQlfDJmU= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-624-8nlRKQcHNmibzDQZ7Zw8NA-1; Thu, 10 Feb 2022 05:00:57 -0500 X-MC-Unique: 8nlRKQcHNmibzDQZ7Zw8NA-1 Received: by mail-ej1-f71.google.com with SMTP id o4-20020a170906768400b006a981625756so2510426ejm.0 for ; Thu, 10 Feb 2022 02:00:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=j6iG/zRSXBJr0V+KQL6qsWdT16lcc2ezAm1Oyf7IUXI=; b=jRwOmE/G3k7FxiDjy4J/tKqwTvEIiQeihvNhvAveSVzIPzcNlB2xoiMLVtJhMtsDc+ mlLGNMtt6Cz7rHbBgEshzQcdX6+5v47HW4CkqayT07h7oa6kCtprNcW8WVdFd6eC5IVl QAD+PIYO5pymPROQi0i4YepiHFoW0tF1BvFEyFBvLUDQn/3w9kuf0mKtorDNPaP7vEBo sB4LwE73KtrEuSxDCo49kuaoZo4zXssaT1zipKhpzFFH4jvVno0boFpVxArA1GNY3dpd U77m7vFPW1UxKR/tZ7m9q0tQJwFL6eoPdJKRxcJjfkZzD/alfCDZ24LPLhbY5RsCkRRu Cq2Q== X-Gm-Message-State: AOAM530cXVwbqP7IvXNMnmsY2wJ3QNI81MwhJpI2aJElG1giVcN30VgB 0Zm8SmVedaMZvzguDsuo+RIfUeaxsf1vt/7rHvbOPPyJzzmB4CQDlyy6EBnEj41qc2wJLZBXYRx G9dsZR9J8EhYseMQLkz5FM/gJ X-Received: by 2002:a50:ed89:: with SMTP id h9mr7693435edr.130.1644487256281; Thu, 10 Feb 2022 02:00:56 -0800 (PST) X-Google-Smtp-Source: ABdhPJy29EIF5dLlj4EgzKveWm+vfQmoyV88rAwDkSQcW7lKexRy8Kajda6TOEEQq/JheLqpWVvS1Q== X-Received: by 2002:a50:ed89:: with SMTP id h9mr7693422edr.130.1644487256142; Thu, 10 Feb 2022 02:00:56 -0800 (PST) Received: from ?IPV6:2001:1c00:c1e:bf00:1db8:22d3:1bc9:8ca1? (2001-1c00-0c1e-bf00-1db8-22d3-1bc9-8ca1.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:1db8:22d3:1bc9:8ca1]) by smtp.gmail.com with ESMTPSA id f28sm2053275ejl.46.2022.02.10.02.00.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Feb 2022 02:00:55 -0800 (PST) Message-ID: Date: Thu, 10 Feb 2022 11:00:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH v2 0/6] typec: mux: Introduce support for multiple TypeC muxes Content-Language: en-US To: Bjorn Andersson , Rob Herring , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , "Rafael J. Wysocki" Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, Dmitry Baryshkov References: <20220208031944.3444-1-bjorn.andersson@linaro.org> From: Hans de Goede In-Reply-To: <20220208031944.3444-1-bjorn.andersson@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 2/8/22 04:19, Bjorn Andersson wrote: > This series introduces a level of indirection between the controller's view of > a typec_mux/switch and the implementation and then expands that to support > multiple drivers. > > This is needed in order to support devices such as the Qualcomm Snapdragon 888 > HDK, which does muxing and orientation handling in the QMP (USB+DP) PHY and SBU > muxing in the external FSA4480 chip. > > Included in the series is a the new FSA4480 driver. This is done to deal with > the renaming of the driver-side typec_mux -> typec_mux_dev. I have tested patches 1-4 on a GPD win which uses a fusb302 TCPM with a pi3usb30532 mux and superspeed orientation switching as well as DP over Type-C still works fine there, so you may add my: Tested-by: Hans de Goede Regards, Hans > > Changes since v1: > - Omitted QMP changes from this series, as the muxing implementation needs a > little bit more debugging. > > Bjorn Andersson (6): > device property: Helper to match multiple connections > device property: Use multi-connection matchers for single case > typec: mux: Introduce indirection > typec: mux: Allow multiple mux_devs per mux > dt-bindings: usb: Add binding for fcs,fsa4480 > usb: typec: mux: Add On Semi fsa4480 driver > > .../devicetree/bindings/usb/fcs,fsa4480.yaml | 72 +++++ > drivers/base/property.c | 85 ++++-- > drivers/usb/typec/bus.c | 2 +- > drivers/usb/typec/mux.c | 261 +++++++++++++----- > drivers/usb/typec/mux.h | 12 +- > drivers/usb/typec/mux/Kconfig | 9 + > drivers/usb/typec/mux/Makefile | 1 + > drivers/usb/typec/mux/fsa4480.c | 220 +++++++++++++++ > drivers/usb/typec/mux/intel_pmc_mux.c | 8 +- > drivers/usb/typec/mux/pi3usb30532.c | 8 +- > include/linux/property.h | 5 + > include/linux/usb/typec_mux.h | 22 +- > 12 files changed, 595 insertions(+), 110 deletions(-) > create mode 100644 Documentation/devicetree/bindings/usb/fcs,fsa4480.yaml > create mode 100644 drivers/usb/typec/mux/fsa4480.c >