From: Cliff Cai <cliffcai.sh@gmail.com>
To: Mike Frysinger <vapier.adi@gmail.com>
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
cliff.cai@analog.com
Subject: Re: [PATCH v2] [mmc/host]:Blackfin SD Host Controller Driver
Date: Wed, 25 Nov 2009 11:58:40 +0800 [thread overview]
Message-ID: <da1989290911241958o88d49a8i14a2c9b39f1f101b@mail.gmail.com> (raw)
In-Reply-To: <8bd0f97a0911241951o5394972dl65c48371f4149b7d@mail.gmail.com>
On Wed, Nov 25, 2009 at 11:51 AM, Mike Frysinger <vapier.adi@gmail.com> wrote:
> On Wed, Nov 25, 2009 at 06:25, <cliffcai.sh@gmail.com> wrote:
>> From: Cliff Cai <cliffcai.sh@gmail.com>
>>
>> v2-v1 change:remove mmc host before releasing it in sdh_probe().
>>
>> Signed-off-by: Cliff Cai <cliffcai.sh@gmail.com>
>> ---
>
> changelog info should be below the ---, not above.
is this true?
> you're also missing the s-o-b's:
> Signed-off-by: Bryan Wu <cooloney@kernel.org>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> -mike
>
Ok,I will do it.
Cliff
next prev parent reply other threads:[~2009-11-25 3:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-25 11:25 cliffcai.sh
2009-11-25 3:51 ` Mike Frysinger
2009-11-25 3:58 ` Cliff Cai [this message]
2009-11-25 6:06 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da1989290911241958o88d49a8i14a2c9b39f1f101b@mail.gmail.com \
--to=cliffcai.sh@gmail.com \
--cc=cliff.cai@analog.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®