From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: hypmean.kim@samsung.com,
"bzolnier@gmail.com" <bzolnier@gmail.com>,
"krzk@kernel.org" <krzk@kernel.org>,
"rafael@kernel.org" <rafael@kernel.org>,
"daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>,
"amitk@kernel.org" <amitk@kernel.org>,
"rui.zhang@intel.com" <rui.zhang@intel.com>,
ALIM AKHTAR <alim.akhtar@samsung.com>
Cc: "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] thermal: exynos: fix masking value for artpec7 temp_error
Date: Wed, 30 Mar 2022 19:05:42 +0200 [thread overview]
Message-ID: <da21cafc-4e5e-cb5f-e7e5-ac9f223616a6@linaro.org> (raw)
In-Reply-To: <20220330094328epcms2p35a3346066ae7b3e8a489e2c81d44f8c9@epcms2p3>
On 30/03/2022 11:43, Sang Min Kim wrote:
> This patch is a modification related to masking of the temp_error value
> in the sanitize_temp_error() function.
Don't use "This patch" please.
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95
>
> For SOC_ARCH_EXYNOS7, the temp_error1, 2 value should be masked as
> EXYNOS7_TMU_TEMP_MASK(0x1ff).
> The current code masks temp_error2 with EXYNOS_TMU_TEMP_MASK(0xff)
> value even in the case of EXYNOS7.
> In addition, when entering the if statement, both temp_error1 and 2
> are masked with EXYNOS_TMU_TEMP_MASK(0xff).
>
> By modifying to use the previously declared local variable tmu_temp_mask,
> the mask value suitable for the SOC can be applied.
>
> Signed-off-by: sangmin kim <hypmean.kim@samsung.com>
Fixes tag?
Code looks itself good, so with changes above:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
prev parent reply other threads:[~2022-03-30 17:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220330093905.191315-1-hypmean.kim@samsung.com>
[not found] ` <CGME20220330093842epcas2p11a4e220245298c5729e4a37d1484d4d5@epcms2p3>
2022-03-30 9:43 ` Sang Min Kim
2022-03-30 17:05 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da21cafc-4e5e-cb5f-e7e5-ac9f223616a6@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=amitk@kernel.org \
--cc=bzolnier@gmail.com \
--cc=daniel.lezcano@linaro.org \
--cc=hypmean.kim@samsung.com \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®