From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB92B214223 for ; Wed, 30 Apr 2025 13:11:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746018695; cv=none; b=o0JVMkyCCjFCNTvwuW3Q+WpbsgFk2qJ9G5vkiN99XwEvhoSFNPukUqSIvvkTUChn10Qej/lAoR7xePfNiCUgWnJTM0PGcjUhADvfp38XYW99mm0g+8SyYlP9w+EcxTYjr8YL58FWODVVJre4NjMjaqeg6+LuLZilixi4Bjmwywc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746018695; c=relaxed/simple; bh=+/m1EO8rUeJJjaoBuQtZjmRLIAdtNaubX7o78vy8dUU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=R7AX57vlReHzlPuYDhtwG9j2uxO2rcsbnfIC9NhbgJ6r1zJeNq+KlvQUGWaEqNvagW17AsgQW/vSh9uWsLXyhGPvKNlL7g5HoqiPqoPCHuaQWUlYAHfjr0ZNkvkINKleiaP8HbpspQW2JNozWts6Z1sndgkmqgw6MmahdL9dS7Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=oKZA07iX; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="oKZA07iX" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-43ce4e47a85so7313195e9.0 for ; Wed, 30 Apr 2025 06:11:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1746018692; x=1746623492; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=dCzPkxxbMsEZi4gmxHLeQbawBsdYMbjxEQFely+C8W4=; b=oKZA07iXoopkbfmgbAPojdQmmmgodHbft+1kfIn2smutScJZPlc+57zEPubbgFsAPF 4ucwzxbf/sZEvqT36clWp2/99QuE92vm0DKm9aiWu9pBG/Xy8TSgpUAgMD4D5wijCK+2 8QtDd7G29aVVGlNVOx6RSXROCXl3YiggXsuyK1JRu+fSjt/rip+2fTQEDo3Zz04JKZL2 3clNLqLKsfJVP/rdIuH3uYVwjaA9HLeMhpxpcY/kWAFT2m3eO6+fLpnyR38z5d+XJKvU MkXova/1lX4IXNkL0MxhIW1DQnywcR88HQk1C2aqh/4JVeHQs8rN/whrtOijNxYrHBhO ynIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746018692; x=1746623492; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dCzPkxxbMsEZi4gmxHLeQbawBsdYMbjxEQFely+C8W4=; b=tcBgISNjDlRU8eDzEN2q9jmeWPWZGJFEoeSeRzhBokKGw0d+FvOrDRlohLo+uZbRKm HjtcG1iPnEcCD/ITRZsxw4rxIwddgCk81DeNe8c1+gOmGaccmIVzppBkjWXyRCFL5Gs0 /e+SuCmqUamYS+29hHdfJSwtHqN7+G+YxNrjpLFoxp7NJ1K3O9F6vilszj7vdq3QSKz8 YdeB1i04secbJlUVSnzT6SpsqwBjodvj1AEQcw/dGSwW2Bj0lDG5tIWbTlEseH6IcLoD PzOIdGYdlvrakeG+PeiMLyFlq7Ic5tH6eooGoe2YHRIdqajWSDUhzia8bDjwKPzB0qiB C/9A== X-Forwarded-Encrypted: i=1; AJvYcCWhOXwY6XZsK+4uCZdh8WLna4KLxrPVhI8nt4QHil3g/fDlvU3SCF1SqBauQyO3PdBrrnOw3uSqrVmTi8Y=@vger.kernel.org X-Gm-Message-State: AOJu0Ywkv07SVvMNPs+CIIbGWesP1W+9P5kX3WFVGpz7bnxmvMeLQ7se V4IgXxEDyJFszOs2tM1JAgyCxQIiuCFzRKrtYlKZ/AdwUf51MpFcHzpCUBqhGAk= X-Gm-Gg: ASbGncv3T+HBWce+RAtIzOOFyHM5U6DmFFkCKyUyg3+rihQE3j0mo/6oEuRUBbWmZxM kskOeoGjKeNAycxodCloWlZ1rpV0khdbymt6/h2VC9EXIAM4f9w/a7LIcv3Qs6DX5iDoVP3cfT5 DwqlATQQRad+H9iCgpAJt5tmGzY9BS7BTPjL8GO1Pp5UYDqToogQ6AcxClQii8biKfADaRekz14 qm8guTxB03iAleajtaYIphJ8JEnKLSW1MP6/shQ22HuROpjrpn0CSwvuJS8w6OI+IJGkOotGv/5 QpKINWjfLF5zdLmQT7NgqS1VivqGPeN2dbfYwnQ7JqJ3eUIMLbOj607PKPU= X-Google-Smtp-Source: AGHT+IFeJjyPF7UsvMCvY/E4zkImQ+r2GCvPnZaHFrfG4ufXz7hO2J0dOlapl0Ez63IyCYU7IZAfQQ== X-Received: by 2002:a05:600c:5488:b0:439:9c0e:36e6 with SMTP id 5b1f17b1804b1-441b2c93eabmr7783915e9.3.1746018692002; Wed, 30 Apr 2025 06:11:32 -0700 (PDT) Received: from [192.168.1.28] ([178.197.207.88]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-441b2ad7931sm24947395e9.1.2025.04.30.06.11.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Apr 2025 06:11:31 -0700 (PDT) Message-ID: Date: Wed, 30 Apr 2025 15:11:29 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 16/24] drm/msm/dsi/phy: Fix reading zero as PLL rates when unprepared To: Abhinav Kumar , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Krishna Manikandan , Jonathan Marek , Kuogee Hsieh , Neil Armstrong , Dmitry Baryshkov , Rob Clark , Bjorn Andersson , Michael Turquette , Stephen Boyd Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Clark , linux-clk@vger.kernel.org, Srinivas Kandagatla References: <20250430-b4-sm8750-display-v5-0-8cab30c3e4df@linaro.org> <20250430-b4-sm8750-display-v5-16-8cab30c3e4df@linaro.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20250430-b4-sm8750-display-v5-16-8cab30c3e4df@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 30/04/2025 15:00, Krzysztof Kozlowski wrote: > > @@ -361,21 +373,46 @@ static int dsi_pll_7nm_lock_status(struct dsi_pll_7nm *pll) > > static void dsi_pll_disable_pll_bias(struct dsi_pll_7nm *pll) > { > - u32 data = readl(pll->phy->base + REG_DSI_7nm_PHY_CMN_CTRL_0); > + unsigned long flags; > + u32 data; > + > + spin_lock_irqsave(&pll->pll_enable_lock, flags); > + --pll->pll_enable_cnt; > + if (pll->pll_enable_cnt < 0) { I removed too much from debugging - this should be WARN_ON or dev_err > + spin_unlock_irqrestore(&pll->pll_enable_lock, flags); > + return; > + } else if (pll->pll_enable_cnt > 0) { > + spin_unlock_irqrestore(&pll->pll_enable_lock, flags); > + return; > + } /* else: == 0 */ Best regards, Krzysztof