From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta0.migadu.com (out-143.mta0.migadu.com [91.218.175.143]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADC5836729D for ; Fri, 2 Oct 2026 13:50:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.143 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790949021; cv=none; b=bDh/tDaY+ZFVS/3PxosW6VhMX/Mz1ONZ9OI6P20aqjVjD2UEWsS1Qcl41AlVocwLBTY/QmI9EJI/vl/cx7xscGajW6m52RvwrzDYflU0zG0JAHaq4EB5DZJEvX9OSUaGpbgbHxORxnvfpus80GjXeded5VG4GdgX+dqcx6YYJHY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790949021; c=relaxed/simple; bh=C/wAt1LQIExSHw4S8KqSvpcjB37pdcwAu4E/VAWQEvg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ch/jhknnlD5EU65RGfH07YfL0RS0iwSNkD+O0AmmjCvQUM4oFRdWGatm17vrpCbkaF6GcGfFucVLWkQNVwun60f8U7TAaVGZYwNVVz0winI9FGldXf3QVquDoi2jVv6f6uSNg3hBHl3J7PF+dqUQotgjsEQR7YdoIMOPA2yICFs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=AMTmlkUp; arc=none smtp.client-ip=91.218.175.143 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="AMTmlkUp" X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=C/wAt1LQIExSHw4S8KqSvpcjB37pdcwAu4E/VAWQEvg=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1790949016; v=1; x=1791553816; b=AMTmlkUpx3s0dwype5xvcZPoVwgrSXQNunrb3UhBHwGSiy5fMKP6BPbx67gjywiqYvQq986i avIaycSSnipJIOw4mUYE5VnSfC1U0eEV67m2ab9drsJXHwkXhN4AKlD9kx/Nga0OLKSfHXbUI+a 7ggToBwaeWkzBk1d4zkjbL54= X-Envelope-To: linux-kernel@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 6242a16857386e04; Fri, 02 Oct 2026 13:50:12 +0000 X-Mizu-Trace-ID: 6242a16857386e04 X-Migadu-Flow: FLOW_OUT Message-ID: Date: Fri, 2 Oct 2026 21:50:02 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] selftests/bpf: Use the new NMI_BITS definition To: Boqun Feng , Peter Zijlstra Cc: Ingo Molnar , Will Deacon , Waiman Long , Gary Guo , Alice Ryhl , Lyude Paul , Daniel Almeida , =?UTF-8?Q?Onur_=C3=96zkan?= , Miguel Ojeda , Danilo Krummrich , Thomas Gleixner , linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Daniel Borkmann , Andrii Nakryiko , Eduard Zingerman , Kumar Kartikeya Dwivedi , Martin KaFai Lau , Song Liu , Yonghong Song , Jiri Olsa , Emil Tsalapatis , Ihor Solodrai , Shuah Khan , bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, Shrikanth Hegde , Alexei Starovoitov References: <20261002102923.45846-1-boqun@kernel.org> Content-Language: en-US From: Leon Hwang In-Reply-To: <20261002102923.45846-1-boqun@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2026/10/2 18:29, Boqun Feng wrote: > The definition of NMI_BITS was out of sync after the introduction of > HAS_SEPARATE_PREEMPT_RESCHED_BITS, hence adjust it. > > Reported-by: Shrikanth Hegde > Fixes: 3b0e2a22d408 ("preempt: Introduce HAS_SEPARATE_PREEMPT_RESCHED_BITS") > Reviewed-by: Shrikanth Hegde > Cc: Leon Hwang > Cc: Alexei Starovoitov > Signed-off-by: Boqun Feng lgtm, Acked-by: Leon Hwang One nit below. > --- > v2: https://lore.kernel.org/lkml/20261001082519.16195-4-boqun@kernel.org/ > v2 -> v3: > > * Add Fixes tag. > * Add CONFIG_HAS_SEPARATE_PREEMPT_RESCHED_BITS weak symbol because > CONFIG_* is not available in bpf programs. > > > tools/testing/selftests/bpf/bpf_experimental.h | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/bpf/bpf_experimental.h b/tools/testing/selftests/bpf/bpf_experimental.h > index 2893bf06ff25..a09448347966 100644 > --- a/tools/testing/selftests/bpf/bpf_experimental.h > +++ b/tools/testing/selftests/bpf/bpf_experimental.h > @@ -367,11 +367,16 @@ extern int bpf_cgroup_read_xattr(struct cgroup *cgroup, const char *name__str, > extern int bpf_sock_read_xattr(struct socket *sock, const char *name__str, > struct bpf_dynptr *value_p) __weak __ksym; > > +extern bool CONFIG_HAS_SEPARATE_PREEMPT_RESCHED_BITS __kconfig __weak; > + > +/* A trivial macro to make NMI_BITS exactly the same as in */ > +#define IS_ENABLED(cfg) (cfg) NIT: change this to ((cfg) ? 1 : 0) to match IS_ENABLED() semantics. Thanks, Leon > + > #define PREEMPT_BITS 8 > #define SOFTIRQ_BITS 8 > #define HARDIRQ_DISABLE_BITS 8 > #define HARDIRQ_BITS 4 > -#define NMI_BITS 1 > +#define NMI_BITS (1 + 3*IS_ENABLED(CONFIG_HAS_SEPARATE_PREEMPT_RESCHED_BITS)) > > #define PREEMPT_SHIFT 0 > #define SOFTIRQ_SHIFT (PREEMPT_SHIFT + PREEMPT_BITS)