From: James Clark <james.clark@linaro.org>
To: Leo Yan <leo.yan@arm.com>, Kuan-Wei Chiu <visitorckw@gmail.com>
Cc: suzuki.poulose@arm.com, mike.leach@linaro.org,
alexander.shishkin@linux.intel.com, pratikp@codeaurora.org,
mathieu.poirier@linaro.org, gregkh@linuxfoundation.org,
jserv@ccns.ncku.edu.tw, marscheng@google.com,
ericchancf@google.com, milesjiang@google.com, nickpan@google.com,
coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] coresight: etm3x: Fix buffer overwrite in cntr_val_show()
Date: Wed, 26 Nov 2025 12:11:05 +0000 [thread overview]
Message-ID: <da2a3e18-80e0-4aca-bbc7-45c1353217d3@linaro.org> (raw)
In-Reply-To: <20251126120914.GH724103@e132581.arm.com>
On 26/11/2025 12:09 pm, Leo Yan wrote:
> On Fri, Nov 21, 2025 at 12:23:50AM +0000, Kuan-Wei Chiu wrote:
>
> [...]
>
>> I noticed this issue while browsing the coresight code after attending
>> a technical talk on the subject. This code dates back to the initial
>> driver submission over 10 years ago, so I was surprised it hadn't been
>> caught earlier. Although I cannot perform runtime testing, the logic
>> error seems obvious to me, so I still decided to submit this patch.
>
> I have a question for maintainers.
>
> The ETMv4 architecture specification shows that ETMv4 was released as
> a non-confidential module in May 2013 (with the confidential release
> even a year earlier). So ETMv4 has been a public IP for more than 12+
> years, and ETMv3 has been gradually retired since then.
>
> This fix can still be applied to older kernels, but seems to me that
> now might be an appropriate time to consider removing the ETMv3 driver
> from the mainline kernel?
>
> Thanks,
> Leo
Yeah, if anyone is using it it would be on an old kernel surely?
next prev parent reply other threads:[~2025-11-26 12:11 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-21 0:23 Kuan-Wei Chiu
2025-11-21 9:50 ` James Clark
2025-11-21 17:02 ` Kuan-Wei Chiu
2025-11-24 16:12 ` James Clark
2025-11-26 10:49 ` Mike Leach
2025-11-26 10:57 ` James Clark
2025-11-27 8:44 ` Kuan-Wei Chiu
2025-11-27 9:17 ` James Clark
2025-11-27 9:22 ` Leo Yan
2025-11-27 9:30 ` James Clark
2025-11-27 9:57 ` Leo Yan
2025-11-27 14:30 ` Mike Leach
2025-11-26 12:09 ` Leo Yan
2025-11-26 12:11 ` James Clark [this message]
2025-11-26 12:31 ` Leo Yan
2025-11-26 13:42 ` Mike Leach
2025-11-26 15:33 ` James Clark
2025-11-26 16:14 ` Mike Leach
2025-11-27 9:29 ` Leo Yan
2025-11-28 14:53 ` James Clark
2025-11-28 15:14 ` Al Grant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da2a3e18-80e0-4aca-bbc7-45c1353217d3@linaro.org \
--to=james.clark@linaro.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=coresight@lists.linaro.org \
--cc=ericchancf@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=jserv@ccns.ncku.edu.tw \
--cc=leo.yan@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marscheng@google.com \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=milesjiang@google.com \
--cc=nickpan@google.com \
--cc=pratikp@codeaurora.org \
--cc=suzuki.poulose@arm.com \
--cc=visitorckw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®