From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABC77C433E0 for ; Wed, 20 Jan 2021 10:30:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 62E6A2333C for ; Wed, 20 Jan 2021 10:30:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732645AbhATKT2 (ORCPT ); Wed, 20 Jan 2021 05:19:28 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:60053 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731055AbhATKFy (ORCPT ); Wed, 20 Jan 2021 05:05:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611137067; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qAdk/pvhgqfEVThJWQE5px+oTI2f6GAbmEr8AilhvWI=; b=FeT0Sl+LyMBP1ffZZBzewk3w1NBY17jTW7i9jTYtbL1KvSWB4dUUkTdjwX1XkVK0EnXluE bWWPOvg/n+amd+zRjCROIWkI9PRhcTPmZnI+hEI6temMeDULbMvlXHzYyUcg3kuiDSb23V g4Lc+ESsO26sFvRT1Y3nFN0YO907J9w= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-163-0TXQz0SNMQmaOrhQss8RVw-1; Wed, 20 Jan 2021 05:04:25 -0500 X-MC-Unique: 0TXQz0SNMQmaOrhQss8RVw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BB494107ACE8; Wed, 20 Jan 2021 10:04:23 +0000 (UTC) Received: from [10.36.115.161] (ovpn-115-161.ams2.redhat.com [10.36.115.161]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9B7B719CA8; Wed, 20 Jan 2021 10:04:18 +0000 (UTC) Subject: Re: [PATCH] virtio-mem: Assign boolean values to a bool variable To: "Michael S. Tsirkin" Cc: Jiapeng Zhong , jasowang@redhat.com, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Tian Tao References: <1611129031-82818-1-git-send-email-abaci-bugfix@linux.alibaba.com> <81a1817d-a1f5-dfca-550c-3e3f62cf3a9d@redhat.com> <20210120045736-mutt-send-email-mst@kernel.org> From: David Hildenbrand Organization: Red Hat GmbH Message-ID: Date: Wed, 20 Jan 2021 11:04:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20210120045736-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20.01.21 10:57, Michael S. Tsirkin wrote: > On Wed, Jan 20, 2021 at 10:40:37AM +0100, David Hildenbrand wrote: >> On 20.01.21 08:50, Jiapeng Zhong wrote: >>> Fix the following coccicheck warnings: >>> >>> ./drivers/virtio/virtio_mem.c:2580:2-25: WARNING: Assignment >>> of 0/1 to bool variable. >>> >>> Reported-by: Abaci Robot >>> Signed-off-by: Jiapeng Zhong >>> --- >>> drivers/virtio/virtio_mem.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c >>> index 9fc9ec4..85a272c 100644 >>> --- a/drivers/virtio/virtio_mem.c >>> +++ b/drivers/virtio/virtio_mem.c >>> @@ -2577,7 +2577,7 @@ static int virtio_mem_probe(struct virtio_device *vdev) >>> * actually in use (e.g., trying to reload the driver). >>> */ >>> if (vm->plugged_size) { >>> - vm->unplug_all_required = 1; >>> + vm->unplug_all_required = true; >>> dev_info(&vm->vdev->dev, "unplugging all memory is required\n"); >>> } >>> >>> >> >> Hi, >> >> we already had a fix on the list for quite a while: >> >> https://lkml.kernel.org/r/1609233239-60313-1-git-send-email-tiantao6@hisilicon.com > > Can't find that one. Looks like it was only on virtualization@ and a couple of people on cc. https://lists.linuxfoundation.org/pipermail/virtualization/2020-December/051662.html Interestingly, I cannot find the follow-up ("[PATCH] virtio-mem: use boolean value when setting vm->unplug_all_required") in the mailing list archives, even though it has virtualization@ on cc. -- Thanks, David / dhildenb