From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 365ECEB64D8 for ; Wed, 21 Jun 2023 16:39:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230115AbjFUQjB (ORCPT ); Wed, 21 Jun 2023 12:39:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229513AbjFUQik (ORCPT ); Wed, 21 Jun 2023 12:38:40 -0400 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4505A1BE3 for ; Wed, 21 Jun 2023 09:38:12 -0700 (PDT) Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-970028cfb6cso937304166b.1 for ; Wed, 21 Jun 2023 09:38:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687365484; x=1689957484; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kHT0xkRPj/tHL2KhcXjDvfPGYpV6DV94rE8fbAVVN3g=; b=OuIf/Hk8Z6ZNeL5MTS+7vZTCeT+7y44aCN21cSuhvvHxvmGKL9onTLPW+IbnI9a5y5 mlpV9SlP91WvG262OezJ/Ggywgt2WRILVvI7LWesxWa7U7Kp4wWHg2aRtwOkIG9xTYxI YpZhIV5WhQDhb9Zx1JXuNFy+YMgZ+jxeAKUoHG3qAwq1a5QxeB8IBwxtHNvOpad5xCjK QRQwiRjgglxH/qutqzAVg5xLJuorhIGhZ/GIynSYGrVcvlbSC3FueXm8nygKzCL06RNU den+lYE4UgFRCIWv09jZ9DvbXcoaBVDrSMTZlR/mlaHsxzgeC8fmHDSVNQ3kfW4oTZoO dWlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687365484; x=1689957484; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kHT0xkRPj/tHL2KhcXjDvfPGYpV6DV94rE8fbAVVN3g=; b=E+4ZCTZZ22kapXcbu4orCC3xo/2+1z6dyadvPTn35O/4xJvuMBrtfMf2fgZNzkZZDN 5Tu/8EKuTuYTkxvXXT7fkssFAF8m7KkXE7yuhZCJoPYR9WkcjMov8udYAPRGL1nXMEbQ YmlY6WucAFeJxQ5XmB2Xcuyd4UOnddkd10IR3YQoVHawFp5cLskqTaCLvhEgt6RUxPe6 NNPdpXpHqX8rXFaeimX6mbqQuLYEw764HvfSVs2x2YaNwpD1g6rNa411J5X30P+8YjH3 /cyyoc2uyE38VSkT4dnnw/6DOI8lCJmkOlCZQYynyl3GGIvVZNm9KkL+Uc4geMKMEHrp RNeQ== X-Gm-Message-State: AC+VfDwX13wi3F5XzPC31hdc+D5gPYQauQjm6OiJakP2pUtrpQLDEAca BMzRjqkc0b3J4HMWmT8uVnG1ewUpUJR0tP6iWnQ= X-Google-Smtp-Source: ACHHUZ74pD5lWhZRri048RG4p/7SNG3Sl7EjZJfgYf3y4RRrD12qSUSfXikA6LBchkNrVcsv/EkWKg== X-Received: by 2002:a17:906:9b86:b0:982:21a1:c4e0 with SMTP id dd6-20020a1709069b8600b0098221a1c4e0mr16135482ejc.56.1687365484337; Wed, 21 Jun 2023 09:38:04 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id z19-20020a170906669300b00977c7566ccbsm3378068ejo.164.2023.06.21.09.38.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Jun 2023 09:38:03 -0700 (PDT) Message-ID: Date: Wed, 21 Jun 2023 18:38:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 2/3] dt-bindings: power: supply: Document Mitsumi MM8013 fuel gauge Content-Language: en-US To: Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sebastian Reichel , Konrad Dybcio Cc: Marijn Suijten , Rob Herring , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org References: <20230621-topic-mm8013-v1-0-4407c6260053@linaro.org> <20230621-topic-mm8013-v1-2-4407c6260053@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20230621-topic-mm8013-v1-2-4407c6260053@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/06/2023 17:39, Konrad Dybcio wrote: > The Mitsumie MM8013 is an I2C fuel gauge for Li-Ion cells. The partial Mitsumi > datasheet is available at [1]. Add bindings for this chip. > > [1] https://www.mitsumi.co.jp/latest-M/Catalog/pdf/battery_mm_8013_e.pdf > Signed-off-by: Konrad Dybcio > --- > .../bindings/power/supply/mitsumi,mm8013.yaml | 35 ++++++++++++++++++++++ > 1 file changed, 35 insertions(+) > > diff --git a/Documentation/devicetree/bindings/power/supply/mitsumi,mm8013.yaml b/Documentation/devicetree/bindings/power/supply/mitsumi,mm8013.yaml > new file mode 100644 > index 000000000000..080fd44083ac > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/supply/mitsumi,mm8013.yaml > @@ -0,0 +1,35 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/power/supply/mitsumi,mm8013.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Mitsumi MM8013 fuel gauge > + > +maintainers: > + - Konrad Dybcio > + > +properties: > + compatible: > + const: mitsumi,mm8013 > + > + reg: > + maxItems: 1 I think you miss several properties: three power supplies (although not all might be needed) and most likely monitored-battery. One regulator output and output GPIO probably can be skipped. Best regards, Krzysztof