From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 913643CEBA7 for ; Fri, 29 May 2026 15:22:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780068152; cv=none; b=Oi/KZRjdkM8Ww/iisGvhSw8dHRUoS5dj0Bwob0OieIx7WU/qOb7Zu8YQ6iaUKPKJ9tazT/C2XOV4yEjZVSlAXDpkEpq1srCa9sXbIoLxBTcwCK6Gls/l5dSXTHD+UcuMb8axQHMmQB3Ka6OSx+PiBR7gsqz9WH5Ih8FP1Hb1dWw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780068152; c=relaxed/simple; bh=sa7tjyyH5w82gQsWdnwXLh3+WpyPoKY2RLFi26AWDX4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bEx84kr98Ygit8l9sIfOCrdYLPA9S9u0llgrQYLBwsOTIbeM3b76oxNJSGqyFt8ywK2F5Wl0nxI1MxpCFpUd6vUThmSrk0tQVIfQNmWAb3rUYpSVj664nulrhqa6PQxgsKDmh1y61AjhxsIw1vHMwQ070XHxN0xgoeekenw43TI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=JrbCeweW; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=L6bGD92Q; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JrbCeweW"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="L6bGD92Q" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780068149; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CGpf7NEGXo6YXa4YKC+LNXdeGyms+G/W0uzlFnpQv6k=; b=JrbCeweWk5sp1syjirB0rb6zL7vlzHhm1xqrmT+Wtuh1grsRlYtAYiLOWeSc5gbWZ22DF8 0IKukvclsZeKD0EyV5YoxG6i3WgWEqAxLK2nqOWjmq5eGBjVdAHHFT+8jJ2CpU4zYNUvpJ bd4g0LyZ53ZFQEs99TYgw1qIcjB+ULo= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-12-SCybJitAMmakhQQlsAyAWw-1; Fri, 29 May 2026 11:22:28 -0400 X-MC-Unique: SCybJitAMmakhQQlsAyAWw-1 X-Mimecast-MFC-AGG-ID: SCybJitAMmakhQQlsAyAWw_1780068147 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-49081106196so27064655e9.1 for ; Fri, 29 May 2026 08:22:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1780068147; x=1780672947; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=CGpf7NEGXo6YXa4YKC+LNXdeGyms+G/W0uzlFnpQv6k=; b=L6bGD92QKORPF/0LBOdHglcp50+VxP3VMjjJyjzab5Avh2OL7PUubFaadFHDVBksVF ehi4c8Xv4C8qsnLbzRHW6W9SB8wai+brN7hf6QpZWJhz7CPdbcfq6ZhEYUhhautI9ps/ m/ddXVaXoe6jEHpfX1vCrBKrf2gi4MU6nSZMAbO6HQXDWIZh8Ge7m+cCyw7uWHEOI00R pxRY+nIVGFSYbdg2mCSFHqnA+5UAkCHA3ubHW7F0aoNErDnb2whLYB3W0e4BjPoe9q8k n/sJ/e99D1I96hmzWrccGE821LoIRh5rW2YGNtaLUQq/I8WLDMb6+ZGfTuwHrqANh04Q 0iCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780068147; x=1780672947; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CGpf7NEGXo6YXa4YKC+LNXdeGyms+G/W0uzlFnpQv6k=; b=OPSaT5OsMf2Oir4FL2F2b/PZJBrgLji5socTutX/il4zycGktDIhoqx+VJVOpRjKvt AzKBNUt618BrhYp7cwABTu1FQgMl7K/yO6/3kf54f5gwLvOEqXzbzK2/qz7HhBjJKn2e YT3TjreYJC2DV05gh2sJIGjiOV4I3/sQIaaVbLQ1ps1G65OI4aS/K24LvlkhCjnXrnMP KmFzKBGLbNzKU6yImWFCjhp3L4DjZCkxyqHI5x7Jr80BlUc//LkOKmylcQdEGGZuAnqa sS/CLNjCoW2JLkbN5bZkJoVXWDr26Oezou+5u7zuMPG2xUFpV7vlJ/Yos8B9yTqcIkuG Tmiw== X-Gm-Message-State: AOJu0Yze+2MqcnF7haMN1UILWxvHDDcjrX8G0IqHAsairfH3G79wjXSP yMJQu64CzTJOOcRBL8PIYqb+wnks0qyHivukzta341IQOsEHbbA85msESQ4THczgubCNiU2sVPd IE6cibfdyxvnB9phZGoBJwTFxvfcHcAjtwUFSU7ARo0yxysbRAs1ew5KXyzL1ZlcW5hmySkc4v9 9+ML8C5k+lDbEkW1IpVazZplt1JQCwldFhy73yeds8Ikw= X-Gm-Gg: Acq92OGDSg1Efk6b3lZJfJDNbSBxn+L/3JBKxt9AHCKrimHNtMS2iZGeUP/vh/VMkN1 Z+KtR0/aKaaKOt/9kxohxJxTleiEYPwMdZuO/vB0dARqO/hmVWJVohHoisFipd9GgYcdssEMGs0 MBI8RgEv/liwGjXoj5zEUtfxF+Bo3NBGswVrPrj7sycA4rCrAAGueQqU8JUh5yJjU42oLkTePxT es4IKP2XTPT6QPTmylXnk+ercIboKwACMX3oCHHJb1NXiGiuF8rBHdld3Eo9lRXbZhd+p3JvHBE NYg+l4L6DRnn9W+tBf/tPgOGdGKgr1fUcuhQJ6rN9otMz7za2klf6UJHr2W6cHNH4Y64RMm4TcE xKfsZh04vz4rj8uBCXQN4Egsy4CxUXA+VxM5+omY/D6NHW3flu1tP+g== X-Received: by 2002:a05:600c:34cf:b0:490:5e2a:f924 with SMTP id 5b1f17b1804b1-490a2900e81mr2221545e9.7.1780068146896; Fri, 29 May 2026 08:22:26 -0700 (PDT) X-Received: by 2002:a05:600c:34cf:b0:490:5e2a:f924 with SMTP id 5b1f17b1804b1-490a2900e81mr2220045e9.7.1780068146235; Fri, 29 May 2026 08:22:26 -0700 (PDT) Received: from redhat.com (IGLD-80-230-25-45.inter.net.il. [80.230.25.45]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4909caa7e17sm56125215e9.9.2026.05.29.08.22.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 May 2026 08:22:25 -0700 (PDT) Date: Fri, 29 May 2026 11:22:21 -0400 From: "Michael S. Tsirkin" To: linux-kernel@vger.kernel.org Cc: "David Hildenbrand (Arm)" , Jason Wang , Xuan Zhuo , Eugenio =?utf-8?B?UMOpcmV6?= , Muchun Song , Oscar Salvador , Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Hugh Dickins , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Christoph Lameter , David Rientjes , Roman Gushchin , Harry Yoo , Axel Rasmussen , Yuanchu Xie , Wei Xu , Chris Li , Kairui Song , Kemeng Shi , Nhat Pham , Baoquan He , virtualization@lists.linux.dev, linux-mm@kvack.org, Andrea Arcangeli Subject: [PATCH v9 04/37] mm: page_reporting: allow driver to set batch capacity Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent Add a capacity field to page_reporting_dev_info so drivers can control the maximum number of pages per report batch. This is useful when the driver needs to reserve virtqueue descriptors for metadata (e.g., a bitmap buffer) alongside the page buffers. The value is capped at PAGE_REPORTING_CAPACITY and rounded down to a power of 2. If unset (0), defaults to PAGE_REPORTING_CAPACITY. The virtio_balloon driver sets capacity to the reporting virtqueue size, letting page_reporting adapt to whatever the device provides. Signed-off-by: Michael S. Tsirkin Assisted-by: Claude:claude-opus-4-6 --- drivers/virtio/virtio_balloon.c | 5 +---- include/linux/page_reporting.h | 3 +++ mm/page_reporting.c | 25 ++++++++++++++----------- 3 files changed, 18 insertions(+), 15 deletions(-) diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c index f6c2dff33f8a..6a1a610c2cb1 100644 --- a/drivers/virtio/virtio_balloon.c +++ b/drivers/virtio/virtio_balloon.c @@ -1017,10 +1017,6 @@ static int virtballoon_probe(struct virtio_device *vdev) unsigned int capacity; capacity = virtqueue_get_vring_size(vb->reporting_vq); - if (capacity < PAGE_REPORTING_CAPACITY) { - err = -ENOSPC; - goto out_unregister_oom; - } vb->pr_dev_info.order = PAGE_REPORTING_ORDER_UNSPECIFIED; @@ -1041,6 +1037,7 @@ static int virtballoon_probe(struct virtio_device *vdev) vb->pr_dev_info.order = 5; #endif + vb->pr_dev_info.capacity = capacity; err = page_reporting_register(&vb->pr_dev_info); if (err) goto out_unregister_oom; diff --git a/include/linux/page_reporting.h b/include/linux/page_reporting.h index 9d4ca5c218a0..5ab5be02fa15 100644 --- a/include/linux/page_reporting.h +++ b/include/linux/page_reporting.h @@ -22,6 +22,9 @@ struct page_reporting_dev_info { /* Minimal order of page reporting */ unsigned int order; + + /* Max pages per report batch (default PAGE_REPORTING_CAPACITY) */ + unsigned int capacity; }; /* Tear-down and bring-up for page reporting devices */ diff --git a/mm/page_reporting.c b/mm/page_reporting.c index 7418f2e500bb..a6ddf6fafc20 100644 --- a/mm/page_reporting.c +++ b/mm/page_reporting.c @@ -174,10 +174,10 @@ page_reporting_cycle(struct page_reporting_dev_info *prdev, struct zone *zone, * list processed. This should result in us reporting all pages on * an idle system in about 30 seconds. * - * The division here should be cheap since PAGE_REPORTING_CAPACITY - * should always be a power of 2. + * The division here should be cheap since capacity should + * always be a power of 2. */ - budget = DIV_ROUND_UP(area->nr_free, PAGE_REPORTING_CAPACITY * 16); + budget = DIV_ROUND_UP(area->nr_free, prdev->capacity * 16); /* loop through free list adding unreported pages to sg list */ list_for_each_entry_safe(page, next, list, lru) { @@ -222,10 +222,10 @@ page_reporting_cycle(struct page_reporting_dev_info *prdev, struct zone *zone, spin_unlock_irq(&zone->lock); /* begin processing pages in local list */ - err = prdev->report(prdev, sgl, PAGE_REPORTING_CAPACITY); + err = prdev->report(prdev, sgl, prdev->capacity); /* reset offset since the full list was reported */ - *offset = PAGE_REPORTING_CAPACITY; + *offset = prdev->capacity; /* update budget to reflect call to report function */ budget--; @@ -234,7 +234,7 @@ page_reporting_cycle(struct page_reporting_dev_info *prdev, struct zone *zone, spin_lock_irq(&zone->lock); /* flush reported pages from the sg list */ - page_reporting_drain(prdev, sgl, PAGE_REPORTING_CAPACITY, !err); + page_reporting_drain(prdev, sgl, prdev->capacity, !err); /* * Reset next to first entry, the old next isn't valid @@ -260,13 +260,13 @@ static int page_reporting_process_zone(struct page_reporting_dev_info *prdev, struct scatterlist *sgl, struct zone *zone) { - unsigned int order, mt, leftover, offset = PAGE_REPORTING_CAPACITY; + unsigned int order, mt, leftover, offset = prdev->capacity; unsigned long watermark; int err = 0; /* Generate minimum watermark to be able to guarantee progress */ watermark = low_wmark_pages(zone) + - (PAGE_REPORTING_CAPACITY << page_reporting_order); + (prdev->capacity << page_reporting_order); /* * Cancel request if insufficient free memory or if we failed @@ -290,7 +290,7 @@ page_reporting_process_zone(struct page_reporting_dev_info *prdev, } /* report the leftover pages before going idle */ - leftover = PAGE_REPORTING_CAPACITY - offset; + leftover = prdev->capacity - offset; if (leftover) { sgl = &sgl[offset]; err = prdev->report(prdev, sgl, leftover); @@ -322,11 +322,11 @@ static void page_reporting_process(struct work_struct *work) atomic_set(&prdev->state, state); /* allocate scatterlist to store pages being reported on */ - sgl = kmalloc_objs(*sgl, PAGE_REPORTING_CAPACITY); + sgl = kmalloc_objs(*sgl, prdev->capacity); if (!sgl) goto err_out; - sg_init_table(sgl, PAGE_REPORTING_CAPACITY); + sg_init_table(sgl, prdev->capacity); for_each_zone(zone) { err = page_reporting_process_zone(prdev, sgl, zone); @@ -377,6 +377,9 @@ int page_reporting_register(struct page_reporting_dev_info *prdev) page_reporting_order = pageblock_order; } + if (!prdev->capacity || prdev->capacity > PAGE_REPORTING_CAPACITY) + prdev->capacity = PAGE_REPORTING_CAPACITY; + /* initialize state and work structures */ atomic_set(&prdev->state, PAGE_REPORTING_IDLE); INIT_DELAYED_WORK(&prdev->work, &page_reporting_process); -- MST