From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 420603E023C for ; Wed, 11 Mar 2026 12:18:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773231543; cv=none; b=KFdTH9hd5rt3abxYAJQd9r+hgXmTkMQtG5UGVO9uJp1UlwL4qnGkOEUUTYmEcTrT3F/mTfl8ipzEQWKIjEmhnnBy47aoDJqP3uK/PqrWjiN5D5z0nmM92yiRrcyCHhaDotBPWo0ffsuaPtFS5J3l0UazAdFHQLItoZPBWQDYBy0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773231543; c=relaxed/simple; bh=N30Lz7nVe0uw3WByT1rg3IOD0/PkIdMburMpZsdZdUo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cJYy8couPfMG0XH8C+DWcM8WymFA4P95KeD9uOKhC0whpL/NDUI5ZgbLe98yf460sXdZL7Z3dDuxI9QM3WT1EoNRIsB+egJPWksC85Ey28UuncPECSPaVGHmtgTchCcZRhehbqWhdQWuojYG+jFDUmjw7muec4nd9H+mzQYtS3I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=MTVGaRvH; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=eObNDgb8; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="MTVGaRvH"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="eObNDgb8" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62BBIYho2677070 for ; Wed, 11 Mar 2026 12:18:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= +yzE3afVc0lHLIoIsllI3qXSm+JCzhYjFOpyIhYmtxE=; b=MTVGaRvHcZJtKolv Ooi0e0goxDTK4JxbvnisM2zZETXAXutWDfSLgDbCfbHqjNQNwby9dU1ZzVp+1ivg 4O0cVtnhoqtAuNfVs54t9R7PIlya38SsDmBPUGlO8igb/DhBSJsprHdwGeL6G1oI RhzHg0D15JkVxzM5XJiS5ZEgls2L8+s/v5CqbwBoyhU3tXIC+yXOt+eOpa5pfKDt HFkAcf5vns06c/xP4/r3u0Zi13DfYrq8tbY2RmwU6PwGU6vD/DMt/hdrTnSvU2hg Y/rKKMz1FyiVcqdYkWeEOB1KYLowPfz7agkXIQeQalLveszxeHwXP9n0c3WzLir9 XkpWUg== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cu3cd18n3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 11 Mar 2026 12:18:59 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2ae44db60c2so106812625ad.2 for ; Wed, 11 Mar 2026 05:18:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773231538; x=1773836338; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+yzE3afVc0lHLIoIsllI3qXSm+JCzhYjFOpyIhYmtxE=; b=eObNDgb8lyG1N3cPJIrK1suyiSq0XOT/QZ9zL1SAzUuiSkNQUzM24kGSt0ue85LedY W1cfC3mIxj0blXzJe7TSj4OrXwdIf6KGt4TE4cZR6s9LXkK4UUy67fxtCASAAmsU89Ag gBIoFdZ0h0OHTUUTyXqpR395VCX1AS9AkyVFP6scL8zVJU01GALtN/NqhRPe7SMidJmC zL8KyPeeGaOQO49/VTUHhjea+yGiUX+n0YrBVubKOm9GkzPiVnkbtR5WHHaAmUXQkE+3 d4SfvQ4bWyCyDa2r3aoz/J3ROnxxJqTh4bwZhzj78UzOQbHfq3mPz1FN0dEPg30avMQh 0Rfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773231538; x=1773836338; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+yzE3afVc0lHLIoIsllI3qXSm+JCzhYjFOpyIhYmtxE=; b=B9VoNBJ2YfcpRtF/rAua6OupC2yD9oNmflJQpxoOkXRCMbCbc5+dn4Auwv43P4R/Bx JuRecJaeQ9lzYJS3teRN5h7JXYV8jhQGMBnfzEXH7F46srUZ1BmV/yf4uPURIjLa6opO qex1cipNBMFj22lvs/v1XldSiSIfSdIgGtBgbz4KMGPfplBoD/yH3RgK+PxUnA6gCl4F c8kk/eNne8Sh87yWYPim2tdHjT59AmrmMG/h1ImYonSmZYt+KMGUDK1xDhhAa9C4sQFn i8dotCWk7559qECV0ioFwbFjQibZU+6lk0ZltFZ03pAdoo6MXE9Z33aFKmF3iRj4gXrC +P9g== X-Forwarded-Encrypted: i=1; AJvYcCUMFosZmxu5UIWiOzF8p5wtBkOX2B08JCbFEQZnL9ifau7Sk77NaooS6COJCjyp2QjdYY9sh72kl6A4fPc=@vger.kernel.org X-Gm-Message-State: AOJu0Yzr85KMlpz9d9nUOjEggYXP7e8MGf4A72raruWM1Uhrlz2R8pst yKe5hBe2A+5uhZvutARTJz99TIr7MEqC3Sq68vr5EV0KBB9Xvl9pQTpsAgHHwqV5fjh16dXTxPA 5tiJnuGhwWNeXJm8QeneHBkYOhfJGnVLY0L+MAMlqONE0xqgJPhYJZFrZNOm6Q4GeEaY= X-Gm-Gg: ATEYQzzU7FoJSiOK1/GLpgso08azoqFgW1KrxAu/p5CXBKhGxVLhkhp7J9M3hW3u50W Tmd9AeuwDKcYDhlkI9YQlf0d9wj5s33xOFUzXoI7EUpfugNoUWogmTvKMK1YnhX3AZxijE0cAZN h7V5vaoNrGD/3cClxyQUyGESeJatnOSeURrbiOD8qnVAMYX82FitxDEBpsAA5QDpmZ7czv+y9OA 4djDe5YMCLQdn/MwMAfvuTpzQdVSfoG896fgLEblspNxZoCRqiYuC+1srJQMn1jzmJi/ze0w6PG VEhYbTNdehLq6AkL+0tR+ytHP54vv+jA2DyBOODRA6uWmt366gstarVHzGBV5duRtWxYLPoWJYw JP1PWOxnx6DBl+m3FInCAjezZ9/sQKLKCiVwXtwr98eMpFbPpgVoNCQ== X-Received: by 2002:a17:903:3910:b0:2ae:471b:e55 with SMTP id d9443c01a7336-2aeae88dfcamr24076035ad.30.1773231538463; Wed, 11 Mar 2026 05:18:58 -0700 (PDT) X-Received: by 2002:a17:903:3910:b0:2ae:471b:e55 with SMTP id d9443c01a7336-2aeae88dfcamr24075805ad.30.1773231537945; Wed, 11 Mar 2026 05:18:57 -0700 (PDT) Received: from [10.0.0.3] ([106.222.228.112]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2aeae376653sm23408375ad.81.2026.03.11.05.18.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Mar 2026 05:18:57 -0700 (PDT) Message-ID: Date: Wed, 11 Mar 2026 17:48:53 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v3 5/8] media: qcom: iris: merge hfi_response_ops and hfi_command_ops Content-Language: en-US To: Dmitry Baryshkov , Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260311-iris-platform-data-v3-0-f02258c4d4ed@oss.qualcomm.com> <20260311-iris-platform-data-v3-5-f02258c4d4ed@oss.qualcomm.com> From: Dikshita Agarwal In-Reply-To: <20260311-iris-platform-data-v3-5-f02258c4d4ed@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzExMDEwNCBTYWx0ZWRfX/kj1CdrCM16T b97zNcvJ15JtHw4R/Gu/dUnSZyQrd84t68HaLU0IEqTyD/fBqWi9J+9rxXaamHdSoKgJq5PVzqv rlmJ1RgEWhQWnkxzT7bhn7UIH46FosgAntZU6jxBh1kOZmiIL5alrkwmerOVd76ivdSvpow/lRZ DYBKhtdKpORrOG9PtBoVwuut4ZjG38q1me9aUp0ARz22fUd5v9kQvE2o0Mt5H6rXc+NtTC+4XId nwm60RT/RFZ84mvomdeYL/lPvZpl2/RggIsXzHpyyXDX7MvNVUjNqEnEWPQfly8K163qhTyP1kT AEtuvq4sNMqTMrlb2o1IhYvoMerIL3IXyPHZAa44yIqwGsp6XJxdBlDAMqetyFeCFQMvUwjHz/Q uFjXzyOznRZM0VIE2jvcGOrkoGQRU8QJimrjMMhePZl6ZlA+7dTiwbc5w/FbZmVQKEcfkg76wcu aYENjyMY/SYaK3DhB0w== X-Authority-Analysis: v=2.4 cv=O/U0fR9W c=1 sm=1 tr=0 ts=69b15db3 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=eRBfbRx1O6b1X7uP3MjCRw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=Hz433T7JF1t1JIG_SOoA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-GUID: ImjvxI0z5bAiY6xbU8esxJM3GCFKIan_ X-Proofpoint-ORIG-GUID: ImjvxI0z5bAiY6xbU8esxJM3GCFKIan_ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-11_01,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 malwarescore=0 phishscore=0 impostorscore=0 bulkscore=0 clxscore=1015 priorityscore=1501 spamscore=0 suspectscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603110104 On 3/11/2026 10:35 AM, Dmitry Baryshkov wrote: > There is little point in having two different structures for HFI-related > core ops. Merge both of them into the new iris_hfi_ops structure. > > Signed-off-by: Dmitry Baryshkov > --- > drivers/media/platform/qcom/iris/iris_core.h | 3 +-- > drivers/media/platform/qcom/iris/iris_hfi_common.c | 6 +++--- > drivers/media/platform/qcom/iris/iris_hfi_common.h | 8 +++----- > drivers/media/platform/qcom/iris/iris_hfi_gen1.h | 4 ++-- > drivers/media/platform/qcom/iris/iris_hfi_gen1_command.c | 8 +++++--- > drivers/media/platform/qcom/iris/iris_hfi_gen1_response.c | 11 +---------- > drivers/media/platform/qcom/iris/iris_hfi_gen2.h | 4 ++-- > drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c | 8 +++++--- > drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c | 11 +---------- > drivers/media/platform/qcom/iris/iris_platform_common.h | 3 +-- > drivers/media/platform/qcom/iris/iris_platform_gen1.c | 6 ++---- > drivers/media/platform/qcom/iris/iris_platform_gen2.c | 12 ++++-------- > drivers/media/platform/qcom/iris/iris_probe.c | 3 +-- > drivers/media/platform/qcom/iris/iris_vpu_common.c | 2 +- > 14 files changed, 32 insertions(+), 57 deletions(-) > > diff --git a/drivers/media/platform/qcom/iris/iris_core.h b/drivers/media/platform/qcom/iris/iris_core.h > index d10a03aa5685..1d9a435ee747 100644 > --- a/drivers/media/platform/qcom/iris/iris_core.h > +++ b/drivers/media/platform/qcom/iris/iris_core.h > @@ -112,8 +112,7 @@ struct iris_core { > u32 header_id; > u32 packet_id; > struct iris_core_power power; > - const struct iris_hfi_command_ops *hfi_ops; > - const struct iris_hfi_response_ops *hfi_response_ops; > + const struct iris_hfi_sys_ops *hfi_sys_ops; > struct completion core_init_done; > u32 intr_status; > struct delayed_work sys_error_handler; > diff --git a/drivers/media/platform/qcom/iris/iris_hfi_common.c b/drivers/media/platform/qcom/iris/iris_hfi_common.c > index 92112eb16c11..ad8e4ecb8605 100644 > --- a/drivers/media/platform/qcom/iris/iris_hfi_common.c > +++ b/drivers/media/platform/qcom/iris/iris_hfi_common.c > @@ -76,7 +76,7 @@ u32 iris_hfi_get_v4l2_matrix_coefficients(u32 hfi_coefficients) > > int iris_hfi_core_init(struct iris_core *core) > { > - const struct iris_hfi_command_ops *hfi_ops = core->hfi_ops; > + const struct iris_hfi_sys_ops *hfi_ops = core->hfi_sys_ops; > int ret; > > ret = hfi_ops->sys_init(core); > @@ -109,7 +109,7 @@ irqreturn_t iris_hfi_isr_handler(int irq, void *data) > iris_vpu_clear_interrupt(core); > mutex_unlock(&core->lock); > > - core->hfi_response_ops->hfi_response_handler(core); > + core->hfi_sys_ops->sys_hfi_response_handler(core); > > if (!iris_vpu_watchdog(core, core->intr_status)) > enable_irq(irq); > @@ -144,7 +144,7 @@ int iris_hfi_pm_suspend(struct iris_core *core) > > int iris_hfi_pm_resume(struct iris_core *core) > { > - const struct iris_hfi_command_ops *ops = core->hfi_ops; > + const struct iris_hfi_sys_ops *ops = core->hfi_sys_ops; > int ret; > > ret = iris_vpu_power_on(core); > diff --git a/drivers/media/platform/qcom/iris/iris_hfi_common.h b/drivers/media/platform/qcom/iris/iris_hfi_common.h > index 18684ada78b2..9aa84a1d8f95 100644 > --- a/drivers/media/platform/qcom/iris/iris_hfi_common.h > +++ b/drivers/media/platform/qcom/iris/iris_hfi_common.h > @@ -105,11 +105,13 @@ struct iris_hfi_prop_type_handle { > int (*handle)(struct iris_inst *inst, u32 plane); > }; > > -struct iris_hfi_command_ops { > +struct iris_hfi_sys_ops { > int (*sys_init)(struct iris_core *core); > int (*sys_image_version)(struct iris_core *core); > int (*sys_interframe_powercollapse)(struct iris_core *core); > int (*sys_pc_prep)(struct iris_core *core); > + > + void (*sys_hfi_response_handler)(struct iris_core *core); > }; > > struct iris_hfi_session_ops { > @@ -129,10 +131,6 @@ struct iris_hfi_session_ops { > int (*session_close)(struct iris_inst *inst); > }; > > -struct iris_hfi_response_ops { > - void (*hfi_response_handler)(struct iris_core *core); > -}; > - > struct hfi_subscription_params { > u32 bitstream_resolution; > u32 crop_offsets[2]; > diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen1.h b/drivers/media/platform/qcom/iris/iris_hfi_gen1.h > index 19b8e9054a75..1c970243532a 100644 > --- a/drivers/media/platform/qcom/iris/iris_hfi_gen1.h > +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen1.h > @@ -9,8 +9,8 @@ > struct iris_core; > struct iris_inst; > > -void iris_hfi_gen1_command_ops_init(struct iris_core *core); > -void iris_hfi_gen1_response_ops_init(struct iris_core *core); > +void iris_hfi_gen1_ops_init(struct iris_core *core); s/iris_hfi_gen1_ops_init/iris_hfi_gen1_sys_ops_init > +void iris_hfi_gen1_response_handler(struct iris_core *core); > struct iris_inst *iris_hfi_gen1_get_instance(void); > > #endif > diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen1_command.c b/drivers/media/platform/qcom/iris/iris_hfi_gen1_command.c > index a28b0c7ebbad..eea9cc3e5904 100644 > --- a/drivers/media/platform/qcom/iris/iris_hfi_gen1_command.c > +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen1_command.c > @@ -1076,16 +1076,18 @@ static const struct iris_hfi_session_ops iris_hfi_gen1_session_ops = { > .session_close = iris_hfi_gen1_session_close, > }; > > -static const struct iris_hfi_command_ops iris_hfi_gen1_command_ops = { > +static const struct iris_hfi_sys_ops iris_hfi_gen1_ops = { s/iris_hfi_gen1_ops/iris_hfi_gen1_sys_ops to keep it consistent with hfi_gen1_session_ops. Same comment is applicable to other places as well. Thanks, Dikshita