From: Andrew Lunn <andrew@lunn.ch>
To: "Radu Pirea (OSS)" <radu-nicolae.pirea@oss.nxp.com>
Cc: hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC net-next] net: phy: introduce phy_reg_field interface
Date: Fri, 31 Mar 2023 14:52:26 +0200 [thread overview]
Message-ID: <da3937bc-8ea7-4f44-85d7-ed452d93ba9b@lunn.ch> (raw)
In-Reply-To: <20230331123259.567627-1-radu-nicolae.pirea@oss.nxp.com>
On Fri, Mar 31, 2023 at 03:32:59PM +0300, Radu Pirea (OSS) wrote:
> Some PHYs can be heavily modified between revisions, and the addresses of
> the registers are changed and the register fields are moved from one
> register to another.
>
> To integrate more PHYs in the same driver with the same register fields,
> but these register fields were located in different registers at
> different offsets, I introduced the phy_reg_fied structure.
>
> phy_reg_fied structure abstracts the register fields differences.
Hi Radu
You should always include a user of a new API. It makes it easier to
understand and review if you see both sides of an API.
Please turn this into a patchset, and make use of this new functions
in a driver.
Andrew
next prev parent reply other threads:[~2023-03-31 12:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-31 12:32 Radu Pirea (OSS)
2023-03-31 12:46 ` Russell King (Oracle)
2023-03-31 12:47 ` Florian Fainelli
2023-03-31 12:52 ` Andrew Lunn [this message]
2023-03-31 13:07 ` Andrew Lunn
2023-03-31 14:38 ` Radu Nicolae Pirea (OSS)
2023-03-31 15:25 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da3937bc-8ea7-4f44-85d7-ed452d93ba9b@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=radu-nicolae.pirea@oss.nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®