From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932150AbYDUNXb (ORCPT ); Mon, 21 Apr 2008 09:23:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759965AbYDUNTG (ORCPT ); Mon, 21 Apr 2008 09:19:06 -0400 Received: from el-out-1112.google.com ([209.85.162.183]:25531 "EHLO el-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759889AbYDUNS7 (ORCPT ); Mon, 21 Apr 2008 09:18:59 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:in-reply-to:references:date:subject:cc:from; b=u3VcqJfw2Ny8UMoI2Gv5Oq2EJ7N4gY6i2k64L+kS6foZIT/pGlSsv+NEaJ42rYVpkyBJWYr7e8bm3rxsjEAtIT/t1nfulCRI/YOy5qmKahtmFcxiTrQSXmSxed2tlp2E6zZaGBA0PtfOn0YAC3lsNCV/cFFXb7yYhQjqghPDSAk= Message-Id: In-Reply-To: References: Date: Tue, 15 Apr 2008 01:31:33 -0400 Subject: [PATCH 24/37] Input: omap-keypad - fix build warning Cc: linux-kernel@vger.kernel.org, jkosina@suse.cz, akpm@linux-foundation.org From: David Brownell To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix the following build warning: drivers/input/keyboard/omap-keypad.c: In function 'omap_kp_probe': drivers/input/keyboard/omap-keypad.c:418: warning: 'row_idx' is used uninitialized in this function drivers/input/keyboard/omap-keypad.c:421: warning: 'col_idx' is used uninitialized in this function These variables are useful when cpu_is_omap24xx(), and otherwise just for useless cleanup. Signed-off-by: David Brownell Signed-off-by: Tony Lindgren Signed-off-by: Dmitry Torokhov --- drivers/input/keyboard/omap-keypad.c | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/input/keyboard/omap-keypad.c b/drivers/input/keyboard/omap-keypad.c index babc913..eec3281 100644 --- a/drivers/input/keyboard/omap-keypad.c +++ b/drivers/input/keyboard/omap-keypad.c @@ -352,6 +352,9 @@ static int __init omap_kp_probe(struct platform_device *pdev) } omap_set_gpio_direction(row_gpios[row_idx], 1); } + } else { + col_idx = 0; + row_idx = 0; } setup_timer(&omap_kp->timer, omap_kp_timer, (unsigned long)omap_kp); @@ -415,10 +418,10 @@ err4: err3: device_remove_file(&pdev->dev, &dev_attr_enable); err2: - for (i = row_idx-1; i >=0; i--) + for (i = row_idx - 1; i >=0; i--) omap_free_gpio(row_gpios[i]); err1: - for (i = col_idx-1; i >=0; i--) + for (i = col_idx - 1; i >=0; i--) omap_free_gpio(col_gpios[i]); kfree(omap_kp); -- 1.5.5.rc2.6.gf58d