From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1245476035; Thu, 12 Dec 2024 01:23:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733966641; cv=none; b=bwgE6yEXCqR+801SlVoLv4T5c9gFjpS17IWGlDf0RLl/KR5ltvyR5P+0WcJJfPU7m4sjUjXb55n890PRMThaRimZBk543NWbnOPevKVDUzf2nUYqa7CqgokAq1cADjnrtT4QaJAfrzF0+/chrYLTk/UoJoI66denGaBzdCN3LPk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733966641; c=relaxed/simple; bh=0zkDqKTdUwWKjR9CMajr60oNbtbumLuu3GcDmcc7t5Y=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=XPX3ZNG8ZofkaAfgtG65vFvEd+aN2IF+dTz+0xkQMj7L0dN+CNrP75ijS+OdaLimvvAYkWR/LGsefhAxs8k5B3ZK5njFgs0WpnkmvZy2kS1trdCmVMZEmOre3cQb3R69uP7V04jHfxmxqtp0xUTT51vX3cJlMlkqXpjelBmWHCE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=Isi0KC4y; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="Isi0KC4y" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BBHDBce002233; Thu, 12 Dec 2024 01:23:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= t9FzI3OxwMsr/TS4ouDSxNI28F3IJQQ1eFR7oeoNKpA=; b=Isi0KC4yk5SUox7G IMqIriILSS1PjceMxhKB2xL9iacwsyrnUcIgU1Rb3uzyKO2NK992jeMumLqptitZ 0iBiLYksAL3N/ytC4+RB3HCaHUsKVzFGo7hhLbkPHup/TUmdBJAMApzGylkHu8EI LhpQDm+duCCFuHztrmq5gePRzQE6MmA/G9nQ08pfcl5McI92IzwFuqt9AH6Kgf5A TeiluT5C59rvYSkzID4DuG5tTRJ4LPZPqNuUvFL0uh7UdneTAux2tCNrlBCkEjjq Xk7IZxfsLfVEDMkYoD895BvN9ea75UyQs4GipkpKlpDBf7FC+bwdN4gHqlwib/Yj C48LIQ== Received: from nalasppmta01.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 43eyg63uce-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 12 Dec 2024 01:23:53 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA01.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 4BC1Nq2N001500 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 12 Dec 2024 01:23:52 GMT Received: from [10.110.5.240] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Wed, 11 Dec 2024 17:23:49 -0800 Message-ID: Date: Wed, 11 Dec 2024 17:23:47 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 02/14] drm/msm/dp: fix msm_dp_utils_pack_sdp_header interface To: Dmitry Baryshkov , Rob Clark , Sean Paul , Marijn Suijten , David Airlie , "Simona Vetter" , Paloma Arellano CC: Douglas Anderson , Stephen Boyd , , , , References: <20241212-fd-dp-audio-fixup-v3-0-0b1c65e7dba3@linaro.org> <20241212-fd-dp-audio-fixup-v3-2-0b1c65e7dba3@linaro.org> Content-Language: en-US From: Abhinav Kumar In-Reply-To: <20241212-fd-dp-audio-fixup-v3-2-0b1c65e7dba3@linaro.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: BfK71XSNox-iQ5uX0bl5jcrD17rSCi72 X-Proofpoint-ORIG-GUID: BfK71XSNox-iQ5uX0bl5jcrD17rSCi72 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 bulkscore=0 lowpriorityscore=0 priorityscore=1501 adultscore=0 impostorscore=0 mlxlogscore=779 phishscore=0 suspectscore=0 mlxscore=0 clxscore=1015 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2412120008 On 12/11/2024 3:41 PM, Dmitry Baryshkov wrote: > The msm_dp_utils_pack_sdp_header() accepts an unlimited-size u32 pointer > for the header output, while it expects a two-element array. It performs > a sizeof check which is always true on 64-bit platforms (since > sizeof(u32*) is 8) and is always false on 32-bit platforms. It returns > an error code which nobody actually checks. > > Fix the function interface to accept u32[2] and return void, skipping > all the checks. > > Fixes: 55fb8ffc1802 ("drm/msm/dp: add VSC SDP support for YUV420 over DP") > Reviewed-by: Abhinav Kumar > Reviewed-by: Stephen Boyd > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/dp/dp_utils.c | 10 +--------- > drivers/gpu/drm/msm/dp/dp_utils.h | 2 +- > 2 files changed, 2 insertions(+), 10 deletions(-) > This was included in -fixes as well. So no need to include.