From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932635AbeEaAL7 (ORCPT ); Wed, 30 May 2018 20:11:59 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:42622 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932450AbeEaAL4 (ORCPT ); Wed, 30 May 2018 20:11:56 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org EA8956063F Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=collinsd@codeaurora.org Subject: Re: [PATCH v4 0/2] regulator: add QCOM RPMh regulator driver To: Mark Brown Cc: lgirdwood@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, rnayak@codeaurora.org, sboyd@kernel.org, dianders@chromium.org References: <20180530163343.GV6920@sirena.org.uk> From: David Collins Message-ID: Date: Wed, 30 May 2018 17:11:54 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20180530163343.GV6920@sirena.org.uk> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Mark, On 05/30/2018 09:33 AM, Mark Brown wrote: > On Tue, May 22, 2018 at 07:43:16PM -0700, David Collins wrote: >> This patch series adds a driver and device tree binding documentation for >> PMIC regulator control via Resource Power Manager-hardened (RPMh) on some >> Qualcomm Technologies, Inc. SoCs such as SDM845. RPMh is a hardware block > > So, this is a very big driver and obviously it being RPM based it > doesn't look like other regulators which is causing problems, especially > when coupled with the desire to implement a bunch of more exotic > features like the mode setting. I think this review is going to go a > lot more smoothly if you split this up into a base driver with just > normal, standard stuff that doesn't add too many custom properties or > unusual ways of working and then a series of patches on top of that > adding things like the mode adjustment and interaction with other RPM > clients. > > We've got other RPM based regulators in tree already so the baseline bit > shouldn't be too hard, that'll make the rest of the patches much smaller > and easier to review and mean that the bits that are simpler and easier > to cope with don't need to be reposted. I'll split up the patches so that reviewing is easier. For the base patch, would you prefer that I remove *all* mode support (handled by generic regulator framework DT properties) or only remove the special purpose drms mode handling support (i.e. qcom,regulator-drms-modes and qcom,drms-mode-max-microamps)? Thanks, David -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project