From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9602C54FB9 for ; Thu, 16 Nov 2023 10:48:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345051AbjKPKsJ (ORCPT ); Thu, 16 Nov 2023 05:48:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58480 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230193AbjKPKsH (ORCPT ); Thu, 16 Nov 2023 05:48:07 -0500 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 35AFF18B; Thu, 16 Nov 2023 02:48:04 -0800 (PST) Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3AGAU3I0015936; Thu, 16 Nov 2023 10:47:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=PG1zXjM6smP55FHAGfkzq20pC99RpgLWqnjbwEKPGLg=; b=jQHul2sVzKN79SqfshkffGUS+8USzz4NxwTUn3LybWmqIkY4eJhGWSSS1EN584u6v6RF 3GLpDLboMdv3XWwHkQozmwU+9vZFCXdPWBNPbCVVUo7K7vhaWlsgu7JJ0D23pPZgSgIm qAFmaVgJddg1wXHn4gkQwzVtjHyqxtbG3O0WxafW3dYVko5RVPEnCR1C50sNh8vGMDq0 qSdyxgxbvUOUl9cAsqwrUH8iGgSZa2IicIqeR0W9/5/nS+WoYMoijKSHsfs4Tx7Dt4yY 6r+Ujfxbe+/2ZU02srjJxj/QjbrWBXRB1C9imrAF+4czjzX3Yx99e87v0mDtNQSAVxtK oA== Received: from nasanppmta01.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3ucuac32jy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 16 Nov 2023 10:47:52 +0000 Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3AGAlqUa029385 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 16 Nov 2023 10:47:52 GMT Received: from [10.253.72.184] (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.39; Thu, 16 Nov 2023 02:47:47 -0800 Message-ID: Date: Thu, 16 Nov 2023 18:47:47 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/9] net: mdio: ipq4019: support MDIO clock frequency divider Content-Language: en-US To: Andrew Lunn CC: , , , , , , , , , , , , , , , , , References: <20231115032515.4249-1-quic_luoj@quicinc.com> <20231115032515.4249-6-quic_luoj@quicinc.com> <3471f665-f935-4091-b870-a42cf2b1eb96@lunn.ch> From: Jie Luo In-Reply-To: <3471f665-f935-4091-b870-a42cf2b1eb96@lunn.ch> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: gZ01dlr2ECSUVWjikFhmj6tCxCQrh-p_ X-Proofpoint-GUID: gZ01dlr2ECSUVWjikFhmj6tCxCQrh-p_ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-16_09,2023-11-16_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 mlxlogscore=666 spamscore=0 malwarescore=0 mlxscore=0 bulkscore=0 clxscore=1015 adultscore=0 lowpriorityscore=0 impostorscore=0 priorityscore=1501 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311160086 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/15/2023 11:22 PM, Andrew Lunn wrote: >> + /* MDIO default frequency is 6.25MHz */ >> + priv->clk_div = 0xf; > > 802.3 says MDC should be 2.5Mhz. Its O.K. to support faster clocks, > but it should be an optional DT property, clock-frequency as described > in the binding. > > Andrew Ok, Andrew, will add the DT property "clock-frequency" to support this clock divider in the next patch set, thanks.