From: Shuah Khan <skhan@linuxfoundation.org>
To: Xiong Nandi <xndchn@gmail.com>,
Valentina Manea <valentina.manea.m@gmail.com>,
Shuah Khan <shuah@kernel.org>, Hongren Zheng <i@zenithal.me>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "open list:USB OVER IP DRIVER" <linux-usb@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH 2/2] usbip: Correct format specifier for seqnum from %d to %u
Date: Thu, 2 Jan 2025 15:09:27 -0700 [thread overview]
Message-ID: <da4b2710-f36e-40ad-addb-6b114e60b187@linuxfoundation.org> (raw)
In-Reply-To: <20241231161539.20192-3-xndchn@gmail.com>
On 12/31/24 09:15, Xiong Nandi wrote:
> The seqnum field in USBIP protocol is an unsigned value.
> So we fix the format specifier from %d to %u to correctly
> display the value.
>
How did you find the problem? Include log from the tool
or compiler output.
> Signed-off-by: Xiong Nandi <xndchn@gmail.com>
> ---
> drivers/usb/usbip/stub_rx.c | 2 +-
> drivers/usb/usbip/stub_tx.c | 2 +-
> drivers/usb/usbip/vhci_rx.c | 6 +++---
> drivers/usb/usbip/vudc_tx.c | 2 +-
> 4 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/usb/usbip/stub_rx.c b/drivers/usb/usbip/stub_rx.c
> index 6338d818bc8b..9aa30ef76f3b 100644
> --- a/drivers/usb/usbip/stub_rx.c
> +++ b/drivers/usb/usbip/stub_rx.c
> @@ -269,7 +269,7 @@ static int stub_recv_cmd_unlink(struct stub_device *sdev,
> return 0;
> }
>
> - usbip_dbg_stub_rx("seqnum %d is not pending\n",
> + usbip_dbg_stub_rx("seqnum %u is not pending\n",
> pdu->u.cmd_unlink.seqnum);
seqnum is unsigned long - don't you have to use %ul?
>
> /*
> diff --git a/drivers/usb/usbip/stub_tx.c b/drivers/usb/usbip/stub_tx.c
> index b1c2f6781cb3..7eb2e074012a 100644
> --- a/drivers/usb/usbip/stub_tx.c
> +++ b/drivers/usb/usbip/stub_tx.c
> @@ -201,7 +201,7 @@ static int stub_send_ret_submit(struct stub_device *sdev)
>
> /* 1. setup usbip_header */
> setup_ret_submit_pdu(&pdu_header, urb);
> - usbip_dbg_stub_tx("setup txdata seqnum: %d\n",
> + usbip_dbg_stub_tx("setup txdata seqnum: %u\n",
> pdu_header.base.seqnum);
>
> if (priv->sgl) {
> diff --git a/drivers/usb/usbip/vhci_rx.c b/drivers/usb/usbip/vhci_rx.c
> index 7f2d1c241559..a75f4a898a41 100644
> --- a/drivers/usb/usbip/vhci_rx.c
> +++ b/drivers/usb/usbip/vhci_rx.c
> @@ -66,7 +66,7 @@ static void vhci_recv_ret_submit(struct vhci_device *vdev,
> spin_unlock_irqrestore(&vdev->priv_lock, flags);
>
> if (!urb) {
> - pr_err("cannot find a urb of seqnum %u max seqnum %d\n",
> + pr_err("cannot find a urb of seqnum %u max seqnum %u\n",
> pdu->base.seqnum,
> atomic_read(&vhci_hcd->seqnum));
> usbip_event_add(ud, VDEV_EVENT_ERROR_TCP);
> @@ -162,10 +162,10 @@ static void vhci_recv_ret_unlink(struct vhci_device *vdev,
> * already received the result of its submit result and gave
> * back the URB.
> */
> - pr_info("the urb (seqnum %d) was already given back\n",
> + pr_info("the urb (seqnum %u) was already given back\n",
> pdu->base.seqnum);
> } else {
> - usbip_dbg_vhci_rx("now giveback urb %d\n", pdu->base.seqnum);
> + usbip_dbg_vhci_rx("now giveback urb %u\n", pdu->base.seqnum);
>
> /* If unlink is successful, status is -ECONNRESET */
> urb->status = pdu->u.ret_unlink.status;
> diff --git a/drivers/usb/usbip/vudc_tx.c b/drivers/usb/usbip/vudc_tx.c
> index 3ccb17c3e840..30c11bf9f4e7 100644
> --- a/drivers/usb/usbip/vudc_tx.c
> +++ b/drivers/usb/usbip/vudc_tx.c
> @@ -107,7 +107,7 @@ static int v_send_ret_submit(struct vudc *udc, struct urbp *urb_p)
>
> /* 1. setup usbip_header */
> setup_ret_submit_pdu(&pdu_header, urb_p);
> - usbip_dbg_stub_tx("setup txdata seqnum: %d\n",
> + usbip_dbg_stub_tx("setup txdata seqnum: %u\n",
> pdu_header.base.seqnum);
> usbip_header_correct_endian(&pdu_header, 1);
>
thanks,
-- Shuah
next prev parent reply other threads:[~2025-01-02 22:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-31 16:15 [PATCH 0/2] usbip: Fix seqnum sign extension and format specifier issues Xiong Nandi
2024-12-31 16:15 ` [PATCH 1/2] usbip: Fix seqnum sign extension issue in vhci_tx_urb Xiong Nandi
2025-01-02 22:06 ` Shuah Khan
2025-01-03 15:18 ` xndcn
2025-01-09 16:02 ` Shuah Khan
2025-01-13 13:29 ` xndcn
2025-01-15 21:14 ` Shuah Khan
2024-12-31 16:15 ` [PATCH 2/2] usbip: Correct format specifier for seqnum from %d to %u Xiong Nandi
2025-01-02 22:09 ` Shuah Khan [this message]
2025-01-03 15:25 ` xndcn
2025-01-15 21:14 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da4b2710-f36e-40ad-addb-6b114e60b187@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=i@zenithal.me \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=valentina.manea.m@gmail.com \
--cc=xndchn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®