From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B3D438551E for ; Mon, 9 Feb 2026 17:12:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770657175; cv=none; b=usdrURl5zR/IgJm38i4hYaG7AiyGJk5inQjs2AaN56xvMH0KJxf6nQcyuNrwTQz4MKylOW2PtW+YapfGXFmYIqh+ZMhiUX1akq5rTTsRCrWzwWqdfVhyv/Rn37zdjQIrUNPUK0PKV6WxGasoiSXW1U1PXQ2efPcq9RE2YrSdoBI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770657175; c=relaxed/simple; bh=Y+YbrNjx8nOdu2kUv1BRKaDQpMLOJXV6rYAzcJJR8iE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=IvtlE9X+5lEKh8KIqat/1guZmyngMDCEP7XLVXLVoTJpvXAJjp8Un6OMkv2182rWbgTJknbt8wEtX7u6wRQV/rzq6SR7RxUBH7WrsEGtlcpBKTXyWOzDM6CHFTVB6xmGEciY3ufzloNnjU1i81YYDV5or0ND+dqdcpyhNfhwfPg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=czwDN088; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=MS60M7Du; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="czwDN088"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="MS60M7Du" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 619H0jie1656099 for ; Mon, 9 Feb 2026 17:12:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ADX6EWNWZU97KWZj8Gy1UYUheARm5i1jrlb4teDa6GU=; b=czwDN088pKAgLR2y 90LGsYgHrNRkOOetg4D/VNlsI+1UevidVME0Pg6Xih3XWXBrVtUXyqtjfeYCx3M1 u0K0HbsdGozOAYxKO4fJhgMd2Psd2l0SIarXVE5Q2zXmQT3vOif9jjWN2DA/dIGa Olg3Lgen0Wi3grc8KHpUiaxxWkcMQR2FqTvSBFQJOiJWjaXxrlpqoqSEK/oitRod iF7R5VNmgnYWI2jik8OmutgrAfJJD3S4HEl1RImTRTMAi3wsN8qJ+kDi3jb+8XcP uD1iuRKXdULhLt2EB2kdHUFTTuqTtM2+tRAcLdlobJIigNp99HvUZ6kTs83un4aC dFFWkw== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c7862tk9d-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 09 Feb 2026 17:12:54 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8cb0595def4so884796885a.0 for ; Mon, 09 Feb 2026 09:12:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770657173; x=1771261973; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ADX6EWNWZU97KWZj8Gy1UYUheARm5i1jrlb4teDa6GU=; b=MS60M7DuJa+mVCEGF0nG/cZoC5p8NZwzIIRakRBL1s+OLY92HRZ3ohG9CgcD0cBfP/ ABVIqegfVT9+IDX/LWEOScOg7jCLpSprMBogLbd9sErGW8bR0GnmrURuD2orxYQ8G428 UTb1mdUF0Qs8lR2qh+lu5RU+WW2eSu7fnGATaHdqmffHayB6ExJBP0pOeNth1jFnLyff 0GQcLcvitBi+j7oYfXIottf1qfy7GHxXYR0NbPLEdbuK3cuYC0I5E+iKG05ah4GEFAab XKnPSYL9Z3jlHKQfg1EbBIxLgZnRRZqQfBcZlIapoR6wslgoceZz90gajU3FGU4QF3on d4Mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770657173; x=1771261973; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ADX6EWNWZU97KWZj8Gy1UYUheARm5i1jrlb4teDa6GU=; b=JxS56mLsQFHCrSGBDMQ8zKhVdOogf22cfvwVIkgFoDp6bXqh3K1DukVFxYec4FLDnx VSWtr91R0LWy41ISqo44CsNeR7XsfkAxKIgTJgdeCbAtqxAOSzIGnKPdfXiWRYNGyB8I n087XtPSPj74LKe4xItIJLpbAxkzWrX8+Bx4YsayYKWUEaP24a0Y6/CG/IQUuOaMgajh GEaih8HyPu9w3jdPpZPG0NwtVMLTIJN/os3Q+TxevPU0vobMUK1VV0N4bEnlUq56lyS9 GTKHtglM4DVRCMdFphm3ehQXJ+V+qL1XaNGXOzZ60UMyG+qV1zWgofKZoVPhc5czufyw TFcw== X-Forwarded-Encrypted: i=1; AJvYcCWAdv+7FQ01axemJ6NUy1S/KgweKk/wR7rW2Le0iMEAVZLS/jSpnvaBhwP6C0o7B6Qh/TBovUbxZ/1V+dk=@vger.kernel.org X-Gm-Message-State: AOJu0Yx+6hMq0+R+hwao5mdv1fke/jd2qjMSTnCbjHzoZf9lqiAEsZZ9 FGK7ZN5PzrQ2s/4nHEfESYi31aZhhDqUlXVcZuLwkc64FYz4s1rcisLPYchfW9MS0iJCZoqr4Kx xV0+Q9YHQAMDhaAvBE55jAJ32GsHlScdm5KxVIPvwHs9oDWno69UHc8rgNI911ar91NE= X-Gm-Gg: AZuq6aIjoLvKIR2uR1L1mH33ktgSev0ihqeVI3uRaLp0zZNziZkhdtGJNkQ0nM5ZQZR 7W3OmN3EmboqzJB1l5C3Nyso+wt5qsSrP5BBK7PlktSjch1SRgaX7eFqIQmvAyZ1R2fK3d/VNsS leNZ9ciea3H2wzaKih8qlDZ1irra/QZuau5bCs+cWS9ug7bYVBHjJ89dmlf/0SSc1xiMWNAY+JY O+IIs8UOpCsUr0cDLPiZmUMqaADzt0MM1dqgseVab0YmwB43D0GJ5V4altNmMXWMAMeOvaWfpD9 /4JoTKnO99vkmXc8UlLJ/CeEXsb/QK6M2Pw6w3jBUAquOsAN2TvU444meUfjWHhg5HT+amDZAB+ ca1Rc/dvxOEp4SycaOB4JSGdgZPhKFMPYsA9G X-Received: by 2002:a05:620a:31a7:b0:8c7:79d:f91b with SMTP id af79cd13be357-8cb1e0a0fcdmr22231885a.6.1770657173382; Mon, 09 Feb 2026 09:12:53 -0800 (PST) X-Received: by 2002:a05:620a:31a7:b0:8c7:79d:f91b with SMTP id af79cd13be357-8cb1e0a0fcdmr22227085a.6.1770657172830; Mon, 09 Feb 2026 09:12:52 -0800 (PST) Received: from [192.168.68.114] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-4834d5d8ebfsm4446795e9.2.2026.02.09.09.12.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Feb 2026 09:12:52 -0800 (PST) Message-ID: Date: Mon, 9 Feb 2026 17:12:51 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/4] arm64: dts: qcom: agatti: add LPASS devices To: Dmitry Baryshkov Cc: lee@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andersson@kernel.org, konradybcio@kernel.org, sboyd@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alexey.klimov@linaro.org, r.mereu@arduino.cc References: <20260209142428.214428-1-srinivas.kandagatla@oss.qualcomm.com> <20260209142428.214428-3-srinivas.kandagatla@oss.qualcomm.com> Content-Language: en-US From: Srinivas Kandagatla In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjA5MDE0NSBTYWx0ZWRfX/WbNAOYBl+Sb bKbPFTC206XjhN7U20PJL2CjjVYD3udro01IBdpmsF5PRsj03bkr2BGPdI4G7lGxgdmxaSDo53Q WyGVq703KIsvtZz1z8XnRRD31ANXQ96Qn+NEvp9F2UAZ5EFgpgBftTUYRPIZxp5nw/NdIVLTchw MUkinM0JQLI8/Uh+vICgb0tPOVi8Uya2+jqQjvBphSJmVmcT2Nz5FnlyAOlG6O+C7mWwwfnNkKc xTPPWzm0qQqgwi2qvwHwa3DJnnKVzwSmTdYkk6wJDD8d66pTNpwWmctO91xTk03jMk++Fy37V7t pYUG0AYn0M1MSzEJZ2VnDhu9G60F1t2wbgFOc5FHvqejnV6Vd2UzBH21fGhr9GD//X0XjLj4bzY +Dm+Mvtb1huddG8k5/NgZVtk2L79+FQmCytwCF/Vw8/Ey2/zHjIavIttymrDltvNcZ+iLN74QLW xGDg1L9+BoHzb9Ivb7Q== X-Authority-Analysis: v=2.4 cv=bZhmkePB c=1 sm=1 tr=0 ts=698a1596 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=MpFykiw6ONw43vFGCnsA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: ULrni85GEEOTHbKnP7p1FoRVSIhwVXOd X-Proofpoint-GUID: ULrni85GEEOTHbKnP7p1FoRVSIhwVXOd X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-09_01,2026-02-09_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 impostorscore=0 bulkscore=0 lowpriorityscore=0 malwarescore=0 spamscore=0 phishscore=0 suspectscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602090145 On 2/9/26 3:28 PM, Dmitry Baryshkov wrote: > On Mon, Feb 09, 2026 at 02:24:26PM +0000, Srinivas Kandagatla wrote: >> From: Alexey Klimov >> >> The rxmacro, txmacro, vamacro, soundwire nodes, lpass clock >> controllers are required to support audio playback and >> audio capture on sm6115 and its derivatives. >> >> Signed-off-by: Alexey Klimov >> Signed-off-by: Srinivas Kandagatla >> --- >> arch/arm64/boot/dts/qcom/agatti.dtsi | 189 +++++++++++++++++++++++++++ >> 1 file changed, 189 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/agatti.dtsi b/arch/arm64/boot/dts/qcom/agatti.dtsi >> index 76b93b7bd50f..79cd8bb8e02c 100644 >> --- a/arch/arm64/boot/dts/qcom/agatti.dtsi >> +++ b/arch/arm64/boot/dts/qcom/agatti.dtsi >> @@ -758,6 +758,42 @@ data-pins { >> drive-strength = <8>; >> }; >> }; >> + >> + lpass_tx_swr_active: lpass-tx-swr-active-state { >> + clk-pins { >> + pins = "gpio0"; >> + function = "swr_tx_clk"; >> + drive-strength = <10>; >> + slew-rate = <3>; >> + bias-disable; >> + }; >> + >> + data-pins { >> + pins = "gpio1", "gpio2"; >> + function = "swr_tx_data"; >> + drive-strength = <10>; >> + slew-rate = <3>; >> + bias-bus-hold; >> + }; >> + }; >> + >> + lpass_rx_swr_active: lpass-rx-swr-active-state { >> + clk-pins { >> + pins = "gpio3"; >> + function = "swr_rx_clk"; >> + drive-strength = <10>; >> + slew-rate = <3>; >> + bias-disable; >> + }; >> + >> + data-pins { >> + pins = "gpio4", "gpio5"; >> + function = "swr_rx_data"; >> + drive-strength = <10>; >> + slew-rate = <3>; >> + bias-bus-hold; >> + }; >> + }; >> }; >> >> gcc: clock-controller@1400000 { >> @@ -2188,6 +2224,159 @@ glink-edge { >> }; >> }; >> >> + rxmacro: codec@a600000 { >> + compatible = "qcom,sm6115-lpass-rx-macro"; >> + reg = <0x0 0xa600000 0x0 0x1000>; >> + >> + clocks = <&q6afecc LPASS_CLK_ID_RX_CORE_MCLK >> + LPASS_CLK_ATTRIBUTE_COUPLE_NO>, > > Plesae correct the indentation (or just use single line for each entry). Checkpatch was not happy with more than 100 chars, which is why I folded this out, I will fix the indent in next spin. --srini > >> + <&q6afecc LPASS_CLK_ID_RX_CORE_NPL_MCLK >> + LPASS_CLK_ATTRIBUTE_COUPLE_NO>, >> + <&q6afecc LPASS_HW_DCODEC_VOTE >> + LPASS_CLK_ATTRIBUTE_COUPLE_NO>, >> + <&vamacro>; > > The rest LGTM. >