From: Phil Elwell <phil@raspberrypi.org>
To: Stefan Wahren <stefan.wahren@i2se.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Eric Anholt <eric@anholt.net>,
Florian Fainelli <f.fainelli@gmail.com>,
bcm-kernel-feedback-list@broadcom.com,
Geert Uytterhoeven <geert+renesas@glider.be>,
linux-pm@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] thermal: bcm2835: Fix crash in bcm2835_thermal_debugfs
Date: Tue, 29 Jan 2019 09:54:18 +0000 [thread overview]
Message-ID: <da514645-51ab-47ac-8377-dfadfd783897@raspberrypi.org> (raw)
In-Reply-To: <dd7a1467-9252-ac13-204a-b069e5fba13a@i2se.com>
Hi Stefan,
On 29/01/2019 09:44, Stefan Wahren wrote:
> Hi Phil,
>
> Am 29.01.2019 um 10:10 schrieb Phil Elwell:
>> "cat /sys/kernel/debug/bcm2835_thermal/regset" causes a NULL pointer
>> dereference in bcm2835_thermal_debugfs. The driver makes use of the
>> implementation details of the thermal framework to retrieve a pointer
>> to its private data from a struct thermal_zone_device, and gets it
>> wrong - leading to the crash. Instead, store its private data as the
>> drvdata and retrieve the thermal_zone_device pointer from it.
>>
>> Fixes: bcb7dd9ef206 ("thermal: bcm2835: add thermal driver for bcm2835 SoC")
>>
>> Signed-off-by: Phil Elwell <phil@raspberrypi.org>
>
> thanks for this patch.
>
> Could you please resend this patch to the thermal maintainers Zhang Rui and Eduardo Valentin?||||
>
> Regards
> Stefan
>
I blame the get_maintainer script - a "Supporter" sounds less invested and less authoritative
than a "Maintainer".
A resend is imminent.
Phil
prev parent reply other threads:[~2019-01-29 10:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 9:10 Phil Elwell
2019-01-29 9:52 ` Daniel Lezcano
2019-01-29 10:16 ` Phil Elwell
[not found] ` <dd7a1467-9252-ac13-204a-b069e5fba13a@i2se.com>
2019-01-29 9:54 ` Phil Elwell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da514645-51ab-47ac-8377-dfadfd783897@raspberrypi.org \
--to=phil@raspberrypi.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=daniel.lezcano@linaro.org \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=geert+renesas@glider.be \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome