From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Kris Chaplin <kris.chaplin@amd.com>
Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
gregkh@linuxfoundation.org, Conor Dooley <conor@kernel.org>
Subject: Re: w1: coding-style - naming for master/slave for new driver and dt binding
Date: Tue, 17 Oct 2023 15:56:47 +0200 [thread overview]
Message-ID: <da534343-419d-4fb1-a50a-cf5da19b08c5@linaro.org> (raw)
In-Reply-To: <91104ef7-c9a6-4c65-aad0-61ecb3c29ea0@amd.com>
On 17/10/2023 11:38, Kris Chaplin wrote:
> Hello Krzystof,
>
> During review of my dt-bindings patches for a new w1 driver
> (https://lkml.org/lkml/2023/10/13/959), there was mention that the use
> of 'master' is not considered great terminology nowadays. Are there any
> plans to replace the usage of master/slave in w1 as mentioned in
> Documentation/process/coding-style.rst ?
I am not aware of any plans to rework/rename existing code in w1.
> As we are in the final stages
> of our W1 soft IP development, I believe there is a small window in
> which we can align on our new IP name if appropriate, prior to my next
> round of patch submission for amd,axi-w1-master and get the binding to
> match.
Naming of your products is little concern to us. How you name it, it is
your call.
The naming used in Linux matters.
>
> If there is a preferred choice from the example alternatives in the
> docs, I can look to see if we can align the naming and update my next
> patch round accordingly - however if the guidance is to keep to the
> specification-defined terminology (pre-2020) then we can do so.
The first diagram on
https://www.analog.com/en/technical-articles/guide-to-1wire-communication.html
suggests to use master->host and slave->device naming.
https://www.analog.com/en/product-category/1wire-devices.html also uses
"host" term.
Best regards,
Krzysztof
prev parent reply other threads:[~2023-10-17 13:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-17 9:38 Kris Chaplin
2023-10-17 13:14 ` Greg KH
2023-10-17 13:56 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da534343-419d-4fb1-a50a-cf5da19b08c5@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kris.chaplin@amd.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®