Re: [PATCH] USB Audio Class 2 Mixer unit support for GET_CUR, SET_CUR and RANGE

[Zipdox <zipdox@zipdox.net>]

On 9/15/26 4:19 PM, Takashi Iwai wrote:
> But your code also blindly assumes the MU_MIXER_CONTROL that doesn't
> fit with other units like feature unit?  I guess we have to set the
> proper Control Selector value depending on the unit type.
> 
> After all, this is about the correct setup of wValue.  Let's try to be
> minimalistic at first -- just tweak wValue in get_ctl_value_v2() and
> snd_usb_mixer_set_ctl_value() at first.  If this becomes too ugly, we
> can think of redesigning.
I assumed that mixer.c was just for the mixer unit, and I seem to have 
completely overlooked the fact that that it also controls feature units. 
I'm not sure how to proceed from here. Do you have any suggestions for 
how we can store the control selector in the usb_mixer_elem_info struct? 
The control field is presently used as the input channel number, so 
maybe we should add a separate field for the input channel? I think 
maybe it's better that someone else fixes this, I'm kind of out of my 
element here.