From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46F44C05052 for ; Wed, 16 Aug 2023 08:23:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242872AbjHPIWy (ORCPT ); Wed, 16 Aug 2023 04:22:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242852AbjHPIWZ (ORCPT ); Wed, 16 Aug 2023 04:22:25 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 757551BE8; Wed, 16 Aug 2023 01:22:23 -0700 (PDT) Received: from kwepemi500012.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4RQgyC4yFrztRxt; Wed, 16 Aug 2023 16:18:43 +0800 (CST) Received: from [10.67.110.108] (10.67.110.108) by kwepemi500012.china.huawei.com (7.221.188.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Wed, 16 Aug 2023 16:22:19 +0800 Message-ID: Date: Wed, 16 Aug 2023 16:22:19 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH] cpufreq: cppc: Add missing error pointer check To: Viresh Kumar CC: , , References: <20230816030549.849824-1-liaochang1@huawei.com> <20230816034630.a4hvsj373q6aslk3@vireshk-i7> <8fea501c-b950-17bd-c710-c923b9af6e62@huawei.com> <20230816081708.o36cvwi3wwh62cmu@vireshk-i7> From: "Liao, Chang" In-Reply-To: <20230816081708.o36cvwi3wwh62cmu@vireshk-i7> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.110.108] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemi500012.china.huawei.com (7.221.188.12) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2023/8/16 16:17, Viresh Kumar 写道: > On 16-08-23, 15:27, Liao, Chang wrote: >> Hi Viresh, >> >> 在 2023/8/16 11:46, Viresh Kumar 写道: >>> On 16-08-23, 03:05, Liao Chang wrote: >>>> The function cppc_freq_invariance_init() may failed to create >>>> kworker_fie, make it more robust by checking the return value to prevent >>>> an invalid pointer dereference in kthread_destroy_worker(), which called >>>> from cppc_freq_invariance_exit(). >>>> >>>> Signed-off-by: Liao Chang >>>> --- >>>> drivers/cpufreq/cppc_cpufreq.c | 21 ++++++++++++++------- >>>> 1 file changed, 14 insertions(+), 7 deletions(-) >>> >>> I think why it was designed this way was to make the driver work, >>> without invariance support, in the worst case instead of just failing >>> completely. The invariance thing is a good to have feature, but not >>> really necessary and so failing probing the driver for that isn't >>> worth it. We should print all error messages though. >>> >> Thanks for pointing that out. I think you are right that the kworker created >> in the cppc driver is not the only arch_freq_scale updater, the ARCH provided >> updater has more priority than the driver, so the driver should still work even >> without kworker_fie supports. >> >> If that is the case, i think the best thing to do is checking the error pointer >> and printing an error message before calling kthread_destroy() in cppc_freq_invariance_exit(), >> this is because at that point, it is really necessary to ensure the kworker_fie has >> been initialized as expected, otherwise it will raise a NULL pointer exception. > > Or just set fie_disabled to true ? Yes, I agree. > >> I hope this makes sense, thanks. > > It does. > -- BR Liao, Chang