From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B80C1E0B9C for ; Fri, 26 Jun 2026 14:24:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782483874; cv=none; b=uUDSnT7JQkG5T4LWrUH/JYv7ApvUJr5ZlWgGablczPPJMbdD2DVqu64F7cnZ3QYSzeabn1/IsuFbYQUQkOdbdLh5odxIpHd1HrQwe6aK5dFvmVPCIFHzdaHesKWGDT8tzuA3IKOw6AwRQvQ9v4LWb2JIc1Ot3iTu541FmDpIFa0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782483874; c=relaxed/simple; bh=UWaYzKmDBEA22iwj68a4Plx+kNjCyEKYLA0FIAwljBc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XQ6vXgBj24GIJQiyoFctYcbBUS3qVQGcKRit8K7a9Jfukq5VnaVSJReKxT4j3QMOjcgVyznHnDrA+3FXvYsA658mBK81Hh/eLKjY17j/hn1jJh+hcFWUC4JhJMX0GV+nCJ86v2UFgjQ9QlwoRIcngvuJrw0GEwXpUxBeY0njvdY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=rSLpRLAF; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="rSLpRLAF" Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65QAIWUH2920246; Fri, 26 Jun 2026 14:24:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=NYYIYo vBck7UDc5uLG/RSmoG1q9+IFKkb38GwdD3t5w=; b=rSLpRLAFbRsJjAxDSrR8CT SJ4tQ/0tu8QqPKmlsO8MbojC3f1P+84EV/VT4Uhd0lN0FzwvmKsZ0/M+p16EYelh JzDSPj9ev176+JqyizzYl7Pm258OyHFt71z+2o+ptBuC8UO6Rv+dHrONKZxozbnF JmJoU96j6KqI8B9cM2Z6eC1KgpVWD2tFXM0/VhIqF0PPa5jId6cT2z64kEDKM9bZ yUALJGt7/k8TQf8Uqht7/rFumBbfy5LbyzBhABCi61s+tJrqf4llveeQpxaZvjYh ahy2NoAEV7/byfUleNER1mpyJKWiONf1HP1UVDIE8I1W0lc3taQ1H8RMGTQLFOZA == Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4ewjhr7b4a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 26 Jun 2026 14:24:18 +0000 (GMT) Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 65QEJeSx024768; Fri, 26 Jun 2026 14:24:17 GMT Received: from smtprelay05.wdc07v.mail.ibm.com ([172.16.1.72]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 4ex56qunv4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 26 Jun 2026 14:24:17 +0000 (GMT) Received: from smtpav01.dal12v.mail.ibm.com (smtpav01.dal12v.mail.ibm.com [10.241.53.100]) by smtprelay05.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 65QEOG2665077580 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 26 Jun 2026 14:24:17 GMT Received: from smtpav01.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BB36358059; Fri, 26 Jun 2026 14:24:16 +0000 (GMT) Received: from smtpav01.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5A55E58058; Fri, 26 Jun 2026 14:24:13 +0000 (GMT) Received: from [9.43.54.234] (unknown [9.43.54.234]) by smtpav01.dal12v.mail.ibm.com (Postfix) with ESMTP; Fri, 26 Jun 2026 14:24:13 +0000 (GMT) Message-ID: Date: Fri, 26 Jun 2026 19:54:11 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCHv2 04/17] nvme: add Clang context annotations for nvme_ns_head::requeue_list To: Christoph Hellwig Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, kbusch@kernel.org, sagi@grimberg.me, axboe@fb.com, bvanassche@acm.org, elver@google.com, gjoyce@linux.ibm.com References: <20260614131541.2017845-1-nilay@linux.ibm.com> <20260614131541.2017845-5-nilay@linux.ibm.com> <20260626063738.GD10731@lst.de> Content-Language: en-US From: Nilay Shroff In-Reply-To: <20260626063738.GD10731@lst.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Authority-Analysis: v=2.4 cv=I4VVgtgg c=1 sm=1 tr=0 ts=6a3e8b93 cx=c_pps a=bLidbwmWQ0KltjZqbj+ezA==:117 a=bLidbwmWQ0KltjZqbj+ezA==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=uAbxVGIbfxUO_5tXvNgY:22 a=QYz6wX4XndNIOmzJYU4A:9 a=QEXdDO2ut3YA:10 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjI2MDExOCBTYWx0ZWRfX/3PZy4O2i4YB fCBQ7g2DrQa/0+KCaSzdAPqWk8TOsR8CvCOEecxRjRomkrMtrj+craVJ/vMyq1iZPEqXs0aHP0b Pm/dxyYxEIWPXpYakyYa9V6toMHInfTSbbekqixKkEmU2VX4NcNxsEyXdP+BCG12NPTHN++KmPd nKqARS9vTLUiq3RU2koG1vIKajaf9n80VRtDBDLGg5W3dIm6UYdB8vkBRqxt9OIZESJ7M93YbZS G+OS8/eq0KrJtXt46LzTTm+5h9PjAhU61aGR3ZNKGFIrUfRLBU+wFcE2gnwWc8+8mdE81KHW6O5 RCK1bJ+8w799rGXr+A1UfZEQQUDbhTNxziqoywhmYkJffmlOqReW4FLukBdYtN155jj4sX3/j73 5/vKTGynRd7bYDX1e5Mct8Js8tEMhTmvfMHJM+QOGnnGab9nUIpltjLU5JeFthKG2R1gv5uIlTP 68yAkC9TzpymkMnxRrg== X-Proofpoint-GUID: FcbRUJVkMcE9AM29jiN1JheW8o7RPZxO X-Proofpoint-ORIG-GUID: hENgio2651hcLjrAZD6xN6AynR9oS6zE X-Proofpoint-Spam-Info: AW1haW4tMjYwNjI2MDExOCBTYWx0ZWRfX9q1EVVoS4/gD MTRaEdWCqR4StqcQ9oA/KFRdTNp5UMThDT7nNOA/3M2cciNFasNu9xVinVoOOdHgDnvzRbUOIeH IidgKbjIxzSChDjAV8+9LXcLyLOEzdQ= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-26_03,2026-06-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 malwarescore=0 clxscore=1015 impostorscore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 priorityscore=1501 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606260118 On 6/26/26 12:07 PM, Christoph Hellwig wrote: >> diff --git a/drivers/nvme/host/multipath.c b/drivers/nvme/host/multipath.c >> index a275c03e7c59..9e7f12fe8cd6 100644 >> --- a/drivers/nvme/host/multipath.c >> +++ b/drivers/nvme/host/multipath.c >> @@ -706,8 +706,8 @@ int nvme_mpath_alloc_disk(struct nvme_ctrl *ctrl, struct nvme_ns_head *head) >> struct queue_limits lim; >> >> mutex_init(&head->lock); >> - bio_list_init(&head->requeue_list); >> - spin_lock_init(&head->requeue_lock); >> + scoped_guard(spinlock_init, &head->requeue_lock) >> + bio_list_init(&head->requeue_list); > > We had that discussion before, but this kind of annotation is just > idiotic :( > Personally, I am also not a big fan of scoped_gurad(...) and friends... > We really to be able to just initialize fields without annotations > before they are first published. Now bio_list_init is actually a no-op > on a zero-allocated structure, so we could just drop it here, but this > is a more general problem. > Yes this one could be avoided by removing bio_list_init() here. Will update this in next patchset. Thanks, --Nilay