From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA6603A6B77 for ; Tue, 31 Mar 2026 10:30:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774953022; cv=none; b=lRoS715a1cvCMiGOWvTUXd10DPUNmOilpd0wfpj5/0TirsbdgbS24PZqaTBLUp933kivZaHlyvkVi8SmfWmQ4D/1n+TY7GFYFAIDAqiHNHmiBwPK/s3dZuKYXKJsx0wO42QgPa26BofD45pTKi8zgnuhu6bhagOJZCLV+uvBnSY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774953022; c=relaxed/simple; bh=sT/82INrgaQ47OcLWnhG2YToHJyu+l6v8Ft+2/PQFs4=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=nKJOrv6y6i+F+xap1Pz6qN/1kYjS7YDIYJFo6Ci8FyIwazwp66HGgo06isVNWfGilzBEGp7T8QFqwh/OLld0bYaNgZOS2Zst1GHJ5Wdn9MR8lBY/XSpK0N+NIdJa0N+GhaspE7eyPEQ1Cxos/s/iOif0DaPpO/eaccV8tWu26Uk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=TQE/cA33; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=B19BCBnZ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="TQE/cA33"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="B19BCBnZ" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62V6a6P62391425 for ; Tue, 31 Mar 2026 10:30:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= aYQnTO3P5TJN689qyQjjyJUE/WvHSMRLVAcSKMleW2M=; b=TQE/cA33jnncrQR7 9aueJB+7igAtKck0CD+hZbqvEQG07r8biZ1TWTl3u9vId9WGvZWEo0v+sgqnh3Yw v92NcOd3co23QDQ9jg9HEFC5EmKiH6wr9xDaMhxdPxODZry74YKbwBTy5/9P8sso annNJe4JblQMFfEJgWLZbVUCHc3FIatSfiCnn280jaAsoMfqwrvObLz4B6j9QxKi 40ewi9Ib6IJHm/ky0V/idNB3tGxGYiqd9BLwF5xLH0jzW5tvxhNptxGavBgt6ZBx xgnWsfunLj3EhEJ79okI4Plrp/tuHuemCZD1vzO7QeG9DAsAo8nLREn4y2Pzl2CV 8CKgOQ== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d7ue7m3ck-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 31 Mar 2026 10:30:20 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-89e9d327913so14856186d6.1 for ; Tue, 31 Mar 2026 03:30:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774953019; x=1775557819; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=aYQnTO3P5TJN689qyQjjyJUE/WvHSMRLVAcSKMleW2M=; b=B19BCBnZVllmAdYN5O8NA4KXIib/ninJH+tPJmVG81m9BCIWXxzgC0URHRLrJ+spDJ Wsd2o8U3KXKsUTc8oPHmuBkfqp5gyz2KptriD0cxr4jpQlZf+V4enMVpAmgJ+wGJtmlv gnCB0h9IZuvP4bkbvYzFkZy56fQwxKASEVqy4zH8jyhG7l/6gfOGe8MOFHElLNpsF9OY aQAFIIwQbc5YFEBftr/q6tCOKfhy6Y3Vp8zal0sSHgwvElvJN9+YQ1xBjjRjkTDChebd gbHtWgJy8Zj52eerfgSVXI826lnkCPK4VdU/1PJkl5k2VapZAHuw5F4MVlfakjMz5wxy aIqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774953019; x=1775557819; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=aYQnTO3P5TJN689qyQjjyJUE/WvHSMRLVAcSKMleW2M=; b=MyN8aSp04sfBQlI6oRrxCmM5sOKU1XBmbyhMZyBYxjV6WQb65/goTG1YS/xmWG2S1n VJbEVdT3+gFqilt40aeIyZUwV8Cu3MjQ1UN/X+QgAEunTcwILvvm2Jqhcqms1NkGjE8Y BHYB/iQk3sCLAubVOuoC3B8IfQQeBj5ChxM2TVCxUq28V6dnGU9/fm/ES4haJmF5RqTG gTxG2sRL3Frv10felVPEl7y/rozYwYnmpGRBEuFwf0SayE1eKTkQN8cv2vXzeOl7WLap 9thqr1Bi2nWd7AyDGLtmT2fWYNivpgU9cVqeNA8hs+R6GBuAt6MxE8T8kA/xyRZC6Xh+ 0zaA== X-Forwarded-Encrypted: i=1; AJvYcCX5l0pgikPyg5+1QxnQDySdb297JbRBpd94keEy/Zxx+nL692x2aOuT74adOrEK4tlbu8ASh9NBF617gsM=@vger.kernel.org X-Gm-Message-State: AOJu0YyhxxpwJi2Rt4tU1oFeqM0+lJ95pYMpGh9Ukp+mdUpytw/lXKDa 5YwKYxOvVTpquqt4WINgiSO8/vJSjOPRfhJ01vkP6fxW0TM+X1XYb2QPwW4SEPIFYWx8WyWjliD ps346EMnDsspPZARhfxH1fIQlVjTSDaKsuWNa/yAOq5IlEUobm0rVtODgYoUHLn4eXMo= X-Gm-Gg: ATEYQzwpyrdLXRtEZD4UXOsF3qmRdJZUAfNTpR/No4uprvWBnNPGdVGlf71fQdm6Bur CiuHUtEHmqZ9DLkEufbyAi7F9feuB3P5RbqwoJO6usZn8gdop5/vt3K9tsaCMVv23GTWqhJddjX ftuFHTSUXJdgyDCv4aT8MVKtteT5BepOZkQUJyv/ZmikUI7IsLW51RbH3qGDz8GKPdNlPZFYs0q zOQdLlFhB2eZiYaGrPtVgme98mOJetSh9NbH77vySuOxc7v0Sx2ey+X+fv4X84czeL4bpPJP6NW QOI6Mm1wJ7kNJpVGrU85UMfLnDYsMjRnUt/BwPxCLVbQ8Vlxee1b9GLQd1HGtKpnViMK7HDc8er AURgKAn71gkmcLIes+m+nnuN/5Y62VAWEmumCl/sLIG6sDBzQVye/tbBFULl2FszAoUMA1syI0V pGp64= X-Received: by 2002:a05:6214:2466:b0:89c:e075:9558 with SMTP id 6a1803df08f44-89ce8df76b9mr173233856d6.3.1774953019009; Tue, 31 Mar 2026 03:30:19 -0700 (PDT) X-Received: by 2002:a05:6214:2466:b0:89c:e075:9558 with SMTP id 6a1803df08f44-89ce8df76b9mr173233366d6.3.1774953018470; Tue, 31 Mar 2026 03:30:18 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9b7ae24d6bsm382655966b.6.2026.03.31.03.30.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Mar 2026 03:30:17 -0700 (PDT) Message-ID: Date: Tue, 31 Mar 2026 12:30:15 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] clk: qcom: Constify qcom_cc_driver_data To: Krzysztof Kozlowski , Bjorn Andersson , Michael Turquette , Stephen Boyd , Maxime Coquelin , Alexandre Torgue , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org References: <20260331091721.61613-3-krzysztof.kozlowski@oss.qualcomm.com> <6ca492d7-c041-42b0-8f41-cd29ab7b4bab@oss.qualcomm.com> <51a05279-1759-4c03-8bba-835a9e972ccb@oss.qualcomm.com> <445a53e3-f467-40fc-9b01-dc776555c3fb@oss.qualcomm.com> <7fece0e7-31b0-4b92-855e-bd9e210cc651@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <7fece0e7-31b0-4b92-855e-bd9e210cc651@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzMxMDEwMSBTYWx0ZWRfX1Zg4aNOH2G5v zkT1WGIhELDCOc/L2JfsZAm6eF73Frvr6SIio03VtvRDjcSsth/ciRrsEkxdQpH9uGDYVs+7lt1 324tRBvV367UMe5RkCb6/L70buvaDgccB2QuQ0eqBHLA9qE3Rtu3g44d0KbG6QNz+Q548xvzzfn G2pVHQYixLlox+wGWLVemdrlsoudrhnVtskH+QkVaH3cO4sVGxn9+9Ipt0VkQu/6Qac8QDj9vTO Hi2pfDI+zyQV6CwYRuwHvCgQFndacz07SuvXGfpN2HuS1MSFwuoldAvfRn2BhS5F63o+Mnhdgi3 OYplDaVWlUdWXA8ehUFfTFJBGoerHw/6iQvwUhoRGTXjuXD62bUmPOcR7L7Bhf8s5G9FaCSBzcz w0CihQd99qEPVz5ktaxpDOxFxZzvnEPAUsiAx2iAsHNvz3P4BBU2DtV070UDiIYz/0Bz7olecPE RiXHziG5c0yor96/dlg== X-Proofpoint-GUID: A_yFEKkdeqSIE6lZ9gBEBiXinuLTjhWE X-Authority-Analysis: v=2.4 cv=G7sR0tk5 c=1 sm=1 tr=0 ts=69cba23c cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=8ULpatOiM0j0TomVWBwA:9 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 X-Proofpoint-ORIG-GUID: A_yFEKkdeqSIE6lZ9gBEBiXinuLTjhWE X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-31_02,2026-03-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 malwarescore=0 lowpriorityscore=0 bulkscore=0 priorityscore=1501 spamscore=0 adultscore=0 impostorscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603310101 On 3/31/26 12:20 PM, Krzysztof Kozlowski wrote: > On 31/03/2026 12:13, Krzysztof Kozlowski wrote: >> On 31/03/2026 12:10, Konrad Dybcio wrote: >>> On 3/31/26 12:09 PM, Krzysztof Kozlowski wrote: >>>> On 31/03/2026 11:33, Konrad Dybcio wrote: >>>>> On 3/31/26 11:17 AM, Krzysztof Kozlowski wrote: >>>>>> The static 'struct qcom_cc_driver_data' contains probe match-like data >>>>>> and is not modified: neither by the driver defining it nor by common.c >>>>>> code using it. >>>>>> >>>>>> Make it const for code safety and code readability. >>>>>> >>>>>> Signed-off-by: Krzysztof Kozlowski >>>>>> --- >>>>> >>>>> [...] >>>>> >>>>>> --- a/drivers/clk/qcom/common.h >>>>>> +++ b/drivers/clk/qcom/common.h >>>>>> @@ -49,7 +49,7 @@ struct qcom_cc_desc { >>>>>> size_t num_icc_hws; >>>>>> unsigned int icc_first_node_id; >>>>>> bool use_rpm; >>>>>> - struct qcom_cc_driver_data *driver_data; >>>>>> + const struct qcom_cc_driver_data *driver_data; >>>>> >>>>> This can be a const ptr to const data, even >>>> >>>> None of other elements in 'qcom_cc_desc' is const pointer, even though >>>> they also could. If doing this change, let's make it consistent - so >>>> shall all of them be const? >>> >>> I thought about it, but then it turns out that videocc-sm8550.c has: >>> >>> video_cc_sm8550_driver_data.clk_cbcrs = video_cc_sm8650_critical_cbcrs >>> >>> So we'd have to duplicate the entire struct >> >> No, that's not a problem. Pointer is not modified and we speak here >> about const pointer. >> > > So to clarify what the code is doing now: I constified the pointed data. > Not the pointer. If you ask me to constify the pointer itself, it's > fine, it will compile/work as well, but do you want it? > > It allows only definition with initialization, no further changes later. > All existing drivers would be fine with it, so just confirm that's your > preferred expression. I'm actually a little on the verge. Maybe let's keep the current iteration of this patch after all, as it'd be a mess to undo if it turned out to be useful Reviewed-by: Konrad Dybcio Konrad