From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1541C433EF for ; Thu, 28 Oct 2021 08:02:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A5A27610CF for ; Thu, 28 Oct 2021 08:02:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229800AbhJ1IE1 (ORCPT ); Thu, 28 Oct 2021 04:04:27 -0400 Received: from s2.neomailbox.net ([5.148.176.60]:16156 "EHLO s2.neomailbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229950AbhJ1IEF (ORCPT ); Thu, 28 Oct 2021 04:04:05 -0400 X-Greylist: delayed 1598 seconds by postgrey-1.27 at vger.kernel.org; Thu, 28 Oct 2021 04:04:05 EDT Subject: Re: [PATCH net-next] batman-adv: Fix the wrong definition To: Yajun Deng , mareklindner@neomailbox.ch, sw@simonwunderlich.de, sven@narfation.org Cc: b.a.t.m.a.n@lists.open-mesh.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20211028072306.1351-1-yajun.deng@linux.dev> From: Antonio Quartulli Message-ID: Date: Thu, 28 Oct 2021 09:35:28 +0200 MIME-Version: 1.0 In-Reply-To: <20211028072306.1351-1-yajun.deng@linux.dev> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 28/10/2021 09:23, Yajun Deng wrote: > There are three variables that are required at most, > no need to define four variables. > > Fixes: 0fa4c30d710d ("batman-adv: Make sysfs support optional") > Signed-off-by: Yajun Deng NAK. kobject_uevent_env() does not know how many items are stored in the array and thus requires it to be NULL terminated. Please check the following for reference: https://elixir.bootlin.com/linux/v5.15-rc6/source/lib/kobject_uevent.c#L548 OTOH I guess we could still use '{}' for the initialization. Regards, -- Antonio Quartulli