From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from va-2-17.ptr.blmpb.com (va-2-17.ptr.blmpb.com [209.127.231.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC110397338 for ; Sun, 2 Aug 2026 12:49:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.127.231.17 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785674972; cv=none; b=Q93REiuIjoUlqW7sv0TKDMxipwyWygOTI0CEvTsZcV/uVRvQos6dOuvBmpJkfPPqhaGcTBwK1LJ5PFtb5NqXfpLxung82tvZ8EeX9W7bYoAmm09vQu44TMWnFJ89ng0Z5q9oskHgvTiigf6h6qfaUspOeckIYckl1GThA4d0Zho= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785674972; c=relaxed/simple; bh=GhyU+I4AObATmube0HVJJl5NTQHluwYkJadT+SOSx2g=; h=Subject:Mime-Version:Cc:Content-Type:From:Message-Id:References: To:Date:In-Reply-To; b=mXxulWrguR5t1STFWjMwPgCY9JuHy1pnXDwdBAbn1KJ++A2syaziCGRCUcGc3vugPeKs5yr9okLuyWO7ozio+HmnuXGghTLVteAjC4QFVUsu/iblg569l4ARSpDQGSYp4dgYumUI9gZF0q9t8mxmHiu7P1CMajTO4+sV4D6IknA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fygo.io; spf=pass smtp.mailfrom=fygo.io; dkim=pass (2048-bit key) header.d=fygo-io.20200929.dkim.larksuite.com header.i=@fygo-io.20200929.dkim.larksuite.com header.b=HpzolgWz; arc=none smtp.client-ip=209.127.231.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fygo.io Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fygo.io Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fygo-io.20200929.dkim.larksuite.com header.i=@fygo-io.20200929.dkim.larksuite.com header.b="HpzolgWz" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=s1; d=fygo-io.20200929.dkim.larksuite.com; t=1785674960; h=from:subject:mime-version:from:date:message-id:subject:to:cc: reply-to:content-type:mime-version:in-reply-to:message-id; bh=n9lZR9qf3kptXY4+jbcwUniPvs3a4Q+wtE0w9TCgWJI=; b=HpzolgWzd5pGnT2/ThxJoHKxhY8c7Z0myyXH35sZDkhMEO90bC3M8nyN/rirM9A6AVvfmP Q+cXNt5nOFDinypumHjapeowlBJuPsncNbxvRGDVpSN4NpcOVTSSkKP0J7m5Ynt1XNBIhj GmEoU36ca0EjEsjmO5qoExj4FNGfPLpKH5KpTVj8aaRKFW+cwvbSlx2lgVTZi/u97TvNoA LZd+Ri4yN5WO66j32PoizbmTiEkD0Gm+Lt6ok9tQeni6D0qSskEjdU4idiLqyp8IrWgK2G JHPnTxdXJwaeyJhfM/uNxpLyE21T7y8lDNzVckBesi3g0WDv14nwd5OByekXgA== X-Original-From: yu kuai Reply-To: yukuai@fygo.io Subject: Re: [PATCH] blk-throttle: remove dead field last_check_time from throtl_grp Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: , , , , , "Tao Cui" Content-Type: text/plain; charset=UTF-8 Received: from [192.168.1.104] ([39.182.0.181]) by smtp.larksuite.com with ESMTPS; Sun, 02 Aug 2026 12:49:19 +0000 Content-Transfer-Encoding: quoted-printable From: "yu kuai" Message-Id: X-Lms-Return-Path: References: <20260717054855.2018578-1-cui.tao@linux.dev> To: "Tao Cui" , , Date: Sun, 2 Aug 2026 20:49:15 +0800 In-Reply-To: <20260717054855.2018578-1-cui.tao@linux.dev> =E5=9C=A8 2026/7/17 13:48, Tao Cui =E5=86=99=E9=81=93: > From: Tao Cui > > The last_check_time field in throtl_grp was used by the > CONFIG_BLK_DEV_THROTTLING_LOW mechanism (in throtl_upgrade_check() and > the downgrade logic) to timestamp the last upgrade/downgrade check. > > Commit bf20ab538c81 ("blk-throttle: remove CONFIG_BLK_DEV_THROTTLING_LOW"= ) > removed all five of its uses in blk-throttle.c and the surrounding LOW > fields (latency_target, last_finish_time, checked_last_finish_time, > avg_idletime, idletime_threshold, bio_cnt, bad_bio_cnt, > bio_cnt_reset_time), but missed the field definition itself. > > It has been a dead field since then: zero references in blk-throttle.c > and the whole tree. Remove it. > > Signed-off-by: Tao Cui > --- > block/blk-throttle.h | 2 -- > 1 file changed, 2 deletions(-) Reviewed-by: Yu Kuai --=20 Thanks, Kuai