From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752234AbeACMbM (ORCPT + 1 other); Wed, 3 Jan 2018 07:31:12 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:34454 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751344AbeACMbJ (ORCPT ); Wed, 3 Jan 2018 07:31:09 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 9D5D6601D4 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org Subject: Re: [PATCH] misc: rtsx: release IRQ during shutdown To: "Rafael J. Wysocki" Cc: Lee Jones , Timur Tabi , chris2553@googlemail.com, Linux PCI , ACPI Devel Maling List , Bjorn Helgaas , "Rafael J. Wysocki" , Linux Kernel Mailing List References: <1514925904-24001-1-git-send-email-okaya@codeaurora.org> From: Sinan Kaya Message-ID: Date: Wed, 3 Jan 2018 07:31:06 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 1/3/2018 7:06 AM, Rafael J. Wysocki wrote: >> pci_disable_device(pcidev); >> + free_irq(pcr->irq, (void *)pcr); > Do you need to disable MSI here too? > Makes sense. I'll post V2 in a minute. -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.