From: Quentin Monnet <quentin.monnet@netronome.com>
To: Roman Gushchin <guro@fb.com>, netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel-team@fb.com, ast@kernel.org,
daniel@iogearbox.net, jakub.kicinski@netronome.com, kafai@fb.com,
David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH v4 net-next 0/4] bpftool: cgroup bpf operations
Date: Thu, 14 Dec 2017 12:22:16 +0000 [thread overview]
Message-ID: <da80166c-58a5-6337-5133-445697878bb3@netronome.com> (raw)
In-Reply-To: <20171213151854.21960-1-guro@fb.com>
2017-12-13 15:18 UTC+0000 ~ Roman Gushchin <guro@fb.com>
> This patchset adds basic cgroup bpf operations to bpftool.
>
> Right now there is no convenient way to perform these operations.
> The /samples/bpf/load_sock_ops.c implements attach/detacg operations,
> but only for BPF_CGROUP_SOCK_OPS programs. Bps (part of bcc) implements
> bpf introspection, but lacks any cgroup-related specific.
>
> I find having a tool to perform these basic operations in the kernel tree
> very useful, as it can be used in the corresponding bpf documentation
> without creating additional dependencies. And bpftool seems to be
> a right tool to extend with such functionality.
Thank you Roman for this series, and for documenting the new commands
and flags!
Reviewed-by: Quentin Monnet <quentin.monnet@netronome.com>
next prev parent reply other threads:[~2017-12-14 12:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-13 15:18 Roman Gushchin
2017-12-13 15:18 ` [PATCH v4 net-next 1/4] libbpf: add ability to guess program type based on section name Roman Gushchin
2017-12-13 15:18 ` [PATCH v4 net-next 2/4] libbpf: prefer global symbols as bpf program name source Roman Gushchin
2017-12-13 15:18 ` [PATCH v4 net-next 3/4] bpftool: implement prog load command Roman Gushchin
2017-12-13 15:18 ` [PATCH v4 net-next 4/4] bpftool: implement cgroup bpf operations Roman Gushchin
2017-12-13 16:13 ` David Ahern
2017-12-13 22:12 ` Jakub Kicinski
2017-12-14 12:22 ` Quentin Monnet [this message]
2017-12-14 12:45 ` [PATCH v4 net-next 0/4] bpftool: " Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da80166c-58a5-6337-5133-445697878bb3@netronome.com \
--to=quentin.monnet@netronome.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=dsahern@gmail.com \
--cc=guro@fb.com \
--cc=jakub.kicinski@netronome.com \
--cc=kafai@fb.com \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®