From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755158AbdKCRC7 (ORCPT ); Fri, 3 Nov 2017 13:02:59 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:48032 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752538AbdKCRCz (ORCPT ); Fri, 3 Nov 2017 13:02:55 -0400 X-Google-Smtp-Source: ABhQp+T2pDpPhaveLcWihMJit8rkvRPfVTyil8rHQvZ/tpIx6+5EQ3ErAbc5evxvCsWq1G1AXODF/w== Subject: Re: [PATCH v2 0/2] pinctrl: Allow indicating loss of state across suspend/resume To: Tony Lindgren , Charles Keepax Cc: linux-gpio@vger.kernel.org, Linus Walleij , Rob Herring , Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list , ckeepax@opensource.wolfsonmicro.com, swarren@nvidia.com, andy.shevchenko@gmail.com, alcooperx@gmail.com, bcm-kernel-feedback-list@broadcom.com, "Rafael J. Wysocki" , linux-pm@vger.kernel.org References: <20171102231551.16220-1-f.fainelli@gmail.com> <20171103103707.3e5wb3c7foxbuvvg@localhost.localdomain> <20171103161120.GH28152@atomide.com> From: Florian Fainelli Message-ID: Date: Fri, 3 Nov 2017 10:02:45 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20171103161120.GH28152@atomide.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/03/2017 09:11 AM, Tony Lindgren wrote: > * Charles Keepax [171103 10:38]: >> On Thu, Nov 02, 2017 at 04:15:49PM -0700, Florian Fainelli wrote: >>> Hello Linus, >>> >>> It's me again, so I have been thinking about the problem originally >>> reported in: [PATCH fixes v3] pinctrl: Really force states during suspend/resume >>> >>> and other similar patches a while ago, and this new version allows a platform >>> using pinctrl-single to specify whether its pins are going to lose their state >>> during a system deep sleep. >>> >>> Note that this is still checked at the pinctrl_select_state() because consumers >>> of the pinctrl API might be calling this from their suspend/resume functions >>> and should not have to know whether the provider does lose its pin states. >>> >> >> Still feels to me like it should be the providers job to the >> restore the state rather than expecting the consumer to >> re-request any state it had. But lets wait and see what Linus >> thinks. > > But isn't it the consumer device losing it's state here? Or the > pinctrl provider losing it's state? The pinctrl provider is losing its state, hence these two patches. > > Anyways, the context lost flag should be managed in the PM core for > the device, so adding linux-pm and Rafael to Cc. I don't think it's that simple but sure, why not. -- Florian