From: Grant Grundler <grundler@google.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: James Bottomley <James.Bottomley@hansenpartnership.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PATCH] firs round of SCSI bug fixes for 2.6.29-rc1
Date: Fri, 16 Jan 2009 11:02:12 -0800 [thread overview]
Message-ID: <da824cf30901161102r67b9c31euc12fc95fb8330a07@mail.gmail.com> (raw)
In-Reply-To: <20090116090928.e43c986e.akpm@linux-foundation.org>
On Fri, Jan 16, 2009 at 9:09 AM, Andrew Morton
<akpm@linux-foundation.org> wrote:
...
>> + CHIPREG_WRITE32(&ioc->chip->Doorbell, 0xC0FFEE00);
>> + panic("%s: Firmware is halted due to command timeout\n",
>> + ioc->name);
>> + }
>> +}
>> +EXPORT_SYMBOL(mpt_halt_firmware);
>
> Doing a panic() after we've already detected an error is plain nasty.
> Is there no way in which we can allow the kernel to continue?
Basically what James said. It's not long though: only 6 emails.
I started that thread thinking the same thing you did:
http://marc.info/?t=123123569200003&r=1&w=2
TBH, I still wouldn't implement it the way LSI maintainers did.
I'm happy they are the maintainers and it's their call.
grant
next prev parent reply other threads:[~2009-01-16 19:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-16 14:56 James Bottomley
2009-01-16 17:09 ` Andrew Morton
2009-01-16 18:48 ` James Bottomley
2009-01-16 19:07 ` Andrew Morton
2009-01-16 20:28 ` James Bottomley
2009-01-16 19:09 ` David Miller
2009-01-16 19:02 ` Grant Grundler [this message]
2009-01-16 19:10 ` David Miller
2009-01-16 20:09 ` Grant Grundler
2009-01-16 20:15 ` James Bottomley
2009-01-17 21:17 ` Matthew Wilcox
2009-02-11 4:08 ` Matthew Wilcox
2009-02-11 12:42 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da824cf30901161102r67b9c31euc12fc95fb8330a07@mail.gmail.com \
--to=grundler@google.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®