From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756416AbcK3JYV (ORCPT ); Wed, 30 Nov 2016 04:24:21 -0500 Received: from foss.arm.com ([217.140.101.70]:39670 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752818AbcK3JYS (ORCPT ); Wed, 30 Nov 2016 04:24:18 -0500 Subject: Re: [PATCH 3/3] ARM: dts: sunxi: enable SDIO Wi-Fi on Orange Pi Zero To: Icenowy Zheng , Alexey Kardashevskiy References: <20161129131922.JFbeipav@smtp2o.mail.yandex.net> Cc: Mark Rutland , Vishnu Patekar , devicetree@vger.kernel.org, linux-doc@vger.kernel.org, Hans de Goede , Jonathan Corbet , Arnd Bergmann , Russell King , Maxime Ripard , linux-arm-kernel@lists.infradead.org, LKML , Chen-Yu Tsai From: Andre Przywara Message-ID: Date: Wed, 30 Nov 2016 09:25:01 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161129131922.JFbeipav@smtp2o.mail.yandex.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 29/11/16 10:19, Icenowy Zheng wrote: > > 2016年11月29日 15:16于 Alexey Kardashevskiy 写道： >> >> >> >> On Wed, Nov 23, 2016 at 6:59 PM, Maxime Ripard > wrote: >>> >>> Hi, >>> >>> On Tue, Nov 22, 2016 at 12:24:21AM +0800, Icenowy Zheng wrote: >>> > There's a Allwinner's XR819 SDIO Wi-Fi module soldered on the board of >>> > Orange Pi Zero, which used a dedicated regulator to power. >>> > >>> > Add the device tree node of the regulator, the enable gpio (with >>> > mmc-pwrseq) and the sdio controller. >>> > >>> > There's a out-of-tree driver tested to work with this device tree. >> >> >> btw could you please give a pointer where to find a XR819 driver for > relatively recent kernel (4.8 may be, just not 3.4)? Thanks. > > https://github.com/Icenowy/xradio I was just curious, so pulled your tree and tried to just compile it. It still threw warnings at me for ARM, and even more so for arm64. I fixed all of them and put that on my github[1]. Feel free to just pick them from there or wait till I manage to clean them up and send you a pull request. And also just a a test, I quickly put it in drivers/net/wireless/xradio, where it compiled fine after registering it with the upper level Kconfig and Makefile. And while looking at it: This looks like typical AW code, not even remotely upstreameable and probably far too complicated. Enabling some Kconfig options made it complain about missing functions. Has anyone checked if this is close to an existing WiFi chip? That wouldn't be a first ;-) Cheers, Andre. [1] https://github.com/apritzel/xradio/commits/quickfixes