From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: Yao Zi <ziyao@disroot.org>, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Yanteng Si <si.yanteng@linux.dev>,
Huacai Chen <chenhuacai@kernel.org>,
"Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>,
Philipp Stanner <phasta@kernel.org>,
Tiezhu Yang <yangtiezhu@loongson.cn>,
Qunqin Zhao <zhaoqunqin@loongson.cn>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Furong Xu <0x1207@gmail.com>,
Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,
Jacob Keller <jacob.e.keller@intel.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 2/3] net: stmmac: loongson: Use generic PCI suspend/resume routines
Date: Thu, 30 Oct 2025 08:38:12 +0100 [thread overview]
Message-ID: <da8d9585-d464-4611-98c0-a10d84874297@bootlin.com> (raw)
In-Reply-To: <20251030041916.19905-3-ziyao@disroot.org>
Hi,
On 30/10/2025 05:19, Yao Zi wrote:
> Convert glue driver for Loongson DWMAC controller to use the generic
> platform suspend/resume routines for PCI controllers, instead of
> implementing its own one.
>
> Signed-off-by: Yao Zi <ziyao@disroot.org>
> ---
> drivers/net/ethernet/stmicro/stmmac/Kconfig | 1 +
> .../ethernet/stmicro/stmmac/dwmac-loongson.c | 36 ++-----------------
> 2 files changed, 4 insertions(+), 33 deletions(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/Kconfig b/drivers/net/ethernet/stmicro/stmmac/Kconfig
> index 598bc56edd8d..4b6911c62e6f 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/Kconfig
> +++ b/drivers/net/ethernet/stmicro/stmmac/Kconfig
> @@ -373,6 +373,7 @@ config DWMAC_LOONGSON
> default MACH_LOONGSON64
> depends on (MACH_LOONGSON64 || COMPILE_TEST) && STMMAC_ETH && PCI
> depends on COMMON_CLK
> + depends on STMMAC_LIBPCI
If we go with a dedicated module for this, "select STMMAC_LIBPCI" would
make more sense here I think. The same applies for the next patch.
Maxime
next prev parent reply other threads:[~2025-10-30 7:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-30 4:19 [PATCH net-next v2 0/3] Unify platform suspend/resume routines for PCI DWMAC glue Yao Zi
2025-10-30 4:19 ` [PATCH net-next v2 1/3] net: stmmac: Add generic suspend/resume helper for PCI-based controllers Yao Zi
2025-10-30 4:19 ` [PATCH net-next v2 2/3] net: stmmac: loongson: Use generic PCI suspend/resume routines Yao Zi
2025-10-30 7:38 ` Maxime Chevallier [this message]
2025-10-30 9:11 ` Yao Zi
2025-10-30 9:30 ` Russell King (Oracle)
2025-10-31 4:24 ` Yao Zi
2025-10-30 4:19 ` [PATCH net-next v2 3/3] net: stmmac: pci: " Yao Zi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da8d9585-d464-4611-98c0-a10d84874297@bootlin.com \
--to=maxime.chevallier@bootlin.com \
--cc=0x1207@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=chenhuacai@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hayashi.kunihiko@socionext.com \
--cc=jacob.e.keller@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=phasta@kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
--cc=si.yanteng@linux.dev \
--cc=vladimir.oltean@nxp.com \
--cc=yangtiezhu@loongson.cn \
--cc=zhaoqunqin@loongson.cn \
--cc=ziyao@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®