From: Soren Brinkmann <soren.brinkmann@xilinx.com>
To: Michal Simek <michal.simek@xilinx.com>, <monstr@monstr.eu>,
Russell King <linux@arm.linux.org.uk>,
Gregory CLEMENT <gregory.clement@free-electrons.com>,
Will Deacon <will.deacon@arm.com>,
Jason Cooper <jason@lakedaemon.net>,
Tony Lindgren <tony@atomide.com>
Cc: <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
Soren Brinkmann <soren.brinkmann@xilinx.com>
Subject: [PATCH RFC] arm: l2x0: Leverage power saving features
Date: Fri, 1 Mar 2013 10:51:26 -0800 [thread overview]
Message-ID: <da92149b-159b-40e3-87b4-a0a448d1da8b@CO1EHSMHS031.ehs.local> (raw)
Enable the 'dynamic clock stop' and 'standby mode' features in the
l2x0 disable path.
Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
---
Hi,
we are currently implementing a suspend to RAM like low power mode for
Zynq.
The code for entering suspend looks like this:
outer_disable();
cpu_suspend(0, zynq_pm_suspend);
outer_resume();
In our low power guidelines we mention the pl310's standby and clock stop
feature and that they should be enabled for low power modes. The question
arising here now is: Does the outer_disable() make these features redundant,
or does it make sense to add it like shown in this patch?
Thanks,
Sören
arch/arm/mm/cache-l2x0.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/arch/arm/mm/cache-l2x0.c b/arch/arm/mm/cache-l2x0.c
index c2f3739..3565df1 100644
--- a/arch/arm/mm/cache-l2x0.c
+++ b/arch/arm/mm/cache-l2x0.c
@@ -286,8 +286,20 @@ static void l2x0_flush_range(unsigned long start, unsigned long end)
static void l2x0_disable(void)
{
unsigned long flags;
+ unsigned long reg;
+ u32 l2x0_revision;
raw_spin_lock_irqsave(&l2x0_lock, flags);
+
+ l2x0_revision = readl_relaxed(l2x0_base + L2X0_CACHE_ID) &
+ L2X0_CACHE_ID_RTL_MASK;
+
+ if (l2x0_revision >= L2X0_CACHE_ID_RTL_R3P0) {
+ reg = readl_relaxed(l2x0_base + L2X0_POWER_CTRL);
+ reg |= L2X0_STNDBY_MODE_EN | L2X0_DYNAMIC_CLK_GATING_EN;
+ writel_relaxed(reg, l2x0_base + L2X0_POWER_CTRL);
+ }
+
__l2x0_flush_all();
writel_relaxed(0, l2x0_base + L2X0_CTRL);
dsb();
--
1.8.1.3
next reply other threads:[~2013-03-01 18:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-01 18:51 Soren Brinkmann [this message]
2013-03-04 4:19 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da92149b-159b-40e3-87b4-a0a448d1da8b@CO1EHSMHS031.ehs.local \
--to=soren.brinkmann@xilinx.com \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=tony@atomide.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®