From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50BAECA9EC0 for ; Mon, 28 Oct 2019 17:08:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2B340217D6 for ; Mon, 28 Oct 2019 17:08:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404039AbfJ1RIp (ORCPT ); Mon, 28 Oct 2019 13:08:45 -0400 Received: from mga04.intel.com ([192.55.52.120]:33512 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726851AbfJ1RIo (ORCPT ); Mon, 28 Oct 2019 13:08:44 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Oct 2019 10:08:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,240,1569308400"; d="scan'208";a="211490840" Received: from yoojae-mobl1.amr.corp.intel.com (HELO [10.7.153.148]) ([10.7.153.148]) by orsmga002.jf.intel.com with ESMTP; 28 Oct 2019 10:08:44 -0700 Subject: Re: [PATCH v2] media: aspeed-video: Fix memory leaks in aspeed_video_probe To: Navid Emamdoost Cc: Navid Emamdoost , Stephen McCamant , Kangjie Lu , Eddie James , Mauro Carvalho Chehab , Joel Stanley , Andrew Jeffery , linux-media@vger.kernel.org, openbmc@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, LKML References: <20191028165827.24949-1-navid.emamdoost@gmail.com> <6450dbb4-aa6f-627d-7e5d-21a20f560d60@linux.intel.com> From: Jae Hyun Yoo Message-ID: Date: Mon, 28 Oct 2019 10:08:44 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/28/2019 10:06 AM, Navid Emamdoost wrote: > On Mon, Oct 28, 2019 at 12:01 PM Jae Hyun Yoo > wrote: >> >> On 10/28/2019 9:58 AM, Navid Emamdoost wrote: >>> In the implementation of aspeed_video_probe() the allocated memory for >>> video should be released if either devm_ioremap_resource() >>> or aspeed_video_init() or aspeed_video_setup_video() fails. Replace >>> kzalloc() with devm_kzalloc to avoid explicit release for video. >>> >>> Fixes: d2b4387f3bdf ("media: platform: Add Aspeed Video Engine driver") >>> Signed-off-by: Navid Emamdoost >>> --- >>> Changes in v2: >>> -- replace kzalloc with devm_kzalloc based on Jae Hyun Yoo >>> suggestion >>> >>> drivers/media/platform/aspeed-video.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/media/platform/aspeed-video.c b/drivers/media/platform/aspeed-video.c >>> index eb12f3793062..2aa8ea2f9824 100644 >>> --- a/drivers/media/platform/aspeed-video.c >>> +++ b/drivers/media/platform/aspeed-video.c >>> @@ -1646,7 +1646,7 @@ static int aspeed_video_probe(struct platform_device *pdev) >>> { >>> int rc; >>> struct resource *res; >>> - struct aspeed_video *video = kzalloc(sizeof(*video), GFP_KERNEL); >>> + struct aspeed_video *video = devm_kzalloc(sizeof(*video), GFP_KERNEL); >> >> It can't be compiled. devm_kzalloc should have 3 parameters. >> > > Oops! my bad. Do you think such a list of parameters is fine: > devm_kzalloc(&pdev->dev, sizeof(*video), GFP_KERNEL); Yes, it's fine.