From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94946C28CF5 for ; Wed, 26 Jan 2022 13:46:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241441AbiAZNqq (ORCPT ); Wed, 26 Jan 2022 08:46:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235428AbiAZNqp (ORCPT ); Wed, 26 Jan 2022 08:46:45 -0500 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D6A5EC06161C; Wed, 26 Jan 2022 05:46:44 -0800 (PST) Received: by mail-wr1-x42a.google.com with SMTP id l25so25853793wrb.13; Wed, 26 Jan 2022 05:46:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=+qNIJvvHKV7eDL/T3CWPH2ozFCAPJs1i9a9glhAmF2g=; b=gpakliFilKKhzB7USQ+hEdd02PlBUTRm4spl5AEQzI+/kPKHt7QQlLuBOHir1ziyI5 pgGto2Dc+dSPM0goFM3gca9yAloPERy/qO5ZRJ55SL21cwNwBMfYf/BzkMJ9G+zefJrm 7jewM++0m/eGF8z+7X4goH8rh8rIbP4vN84VTBC9Fvg/2NO5mGrCjrnCPO86XIIMUlzn 4jwhIcmLMnn90znXHVdja0ZbHYz9ItWBEdPKLxszHITShsLZEppvPrN76d/q6DVTbfPJ bacnJ0Q9N/+KH1GLgqby6mgfXp+T9E480r9vNAgU/HQgHqL/EKd5+4QCuqPD4AdIAbsr sg1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=+qNIJvvHKV7eDL/T3CWPH2ozFCAPJs1i9a9glhAmF2g=; b=Ts7gwV1WkEVBGcPC1ZCjkVEHQdyh5ECz3PtT3ZMHkvwr3VyH6fNLqkCWrfBNXyda2H 2++Tm2N1NNmzZOg/c36oNebPtzQLq0l2nFPLNi9cfSwAOSql5Duyo4Q9Ujn3nDNVAsxV KaPCXVVucbyJ51cw4AzuZckp9K2g4BTd2162YIdgThTIvUUC+XQMPMiy7bi8+cHptPyq L72TWuj2qSG6fGOSbXMoOfZtSwXkkW/AuP+9MlypwaxFXG177xJWK5RhysuOrE4b0NNr Ff4M8Bjz+nPxkCRo6TyLXorX+XQfEaXr5XCIDpxHnDDZyiPIWclPJgIssCmnTaG249MZ QTHg== X-Gm-Message-State: AOAM531a/AO9Kn8Wz8/TqeMJA5M4rprw5plmjB49Egfz4DWJZz99N6EQ J/zM43/6R72Qz4jpViEeJzM= X-Google-Smtp-Source: ABdhPJzQej+hY+5a+CSgvvSIiVQMQeFHfTLi9dMwGkwb7Z2TKEDttw9k1/gumd61BDRV9FyAcNvn3w== X-Received: by 2002:adf:f749:: with SMTP id z9mr18622536wrp.341.1643204803243; Wed, 26 Jan 2022 05:46:43 -0800 (PST) Received: from ?IPV6:2003:ea:8f4d:2b00:bd02:e288:550c:1ac4? (p200300ea8f4d2b00bd02e288550c1ac4.dip0.t-ipconnect.de. [2003:ea:8f4d:2b00:bd02:e288:550c:1ac4]) by smtp.googlemail.com with ESMTPSA id i2sm3724649wmq.23.2022.01.26.05.46.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Jan 2022 05:46:42 -0800 (PST) Message-ID: Date: Wed, 26 Jan 2022 14:46:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: [PATCH net-next 1/1] r8169: enable RTL8125 ASPM L1.2 Content-Language: en-US To: Hau , "netdev@vger.kernel.org" Cc: nic_swsd , "linux-kernel@vger.kernel.org" References: <20220124181937.6331-1-hau@realtek.com> <5ec25f20-8acf-544d-30f6-f0eeecd9b2f1@gmail.com> <439ba7073446410da75509a5add95e03@realtek.com> From: Heiner Kallweit In-Reply-To: <439ba7073446410da75509a5add95e03@realtek.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26.01.2022 14:00, Hau wrote: >> On 24.01.2022 19:19, Chunhao Lin wrote: >>> This patch will enable RTL8125 ASPM L1.2 on the platforms that have >>> tested RTL8125 with ASPM L1.2 enabled. >>> Register mac ocp 0xc0b2 will help to identify if RTL8125 has been >>> tested on L1.2 enabled platform. If it is, this register will be set to 0xf. >>> If not, this register will be default value 0. >>> >>> Signed-off-by: Chunhao Lin >>> --- >>> drivers/net/ethernet/realtek/r8169_main.c | 99 >>> ++++++++++++++++++----- >>> 1 file changed, 79 insertions(+), 20 deletions(-) >>> >>> diff --git a/drivers/net/ethernet/realtek/r8169_main.c >>> b/drivers/net/ethernet/realtek/r8169_main.c >>> index 19e2621e0645..b1e013969d4c 100644 >>> --- a/drivers/net/ethernet/realtek/r8169_main.c >>> +++ b/drivers/net/ethernet/realtek/r8169_main.c >>> @@ -2238,21 +2238,6 @@ static void rtl_wol_enable_rx(struct >> rtl8169_private *tp) >>> AcceptBroadcast | AcceptMulticast | >> AcceptMyPhys); } >>> >>> -static void rtl_prepare_power_down(struct rtl8169_private *tp) -{ >>> - if (tp->dash_type != RTL_DASH_NONE) >>> - return; >>> - >>> - if (tp->mac_version == RTL_GIGA_MAC_VER_32 || >>> - tp->mac_version == RTL_GIGA_MAC_VER_33) >>> - rtl_ephy_write(tp, 0x19, 0xff64); >>> - >>> - if (device_may_wakeup(tp_to_dev(tp))) { >>> - phy_speed_down(tp->phydev, false); >>> - rtl_wol_enable_rx(tp); >>> - } >>> -} >>> - >>> static void rtl_init_rxcfg(struct rtl8169_private *tp) { >>> switch (tp->mac_version) { >>> @@ -2650,6 +2635,34 @@ static void rtl_pcie_state_l2l3_disable(struct >> rtl8169_private *tp) >>> RTL_W8(tp, Config3, RTL_R8(tp, Config3) & ~Rdy_to_L23); } >>> >>> +static void rtl_disable_exit_l1(struct rtl8169_private *tp) { >>> + /* Bits control which events trigger ASPM L1 exit: >>> + * Bit 12: rxdv >>> + * Bit 11: ltr_msg >>> + * Bit 10: txdma_poll >>> + * Bit 9: xadm >>> + * Bit 8: pktavi >>> + * Bit 7: txpla >>> + */ >>> + switch (tp->mac_version) { >>> + case RTL_GIGA_MAC_VER_34 ... RTL_GIGA_MAC_VER_36: >>> + rtl_eri_clear_bits(tp, 0xd4, 0x1f00); >>> + break; >>> + case RTL_GIGA_MAC_VER_37 ... RTL_GIGA_MAC_VER_38: >>> + rtl_eri_clear_bits(tp, 0xd4, 0x0c00); >>> + break; >>> + case RTL_GIGA_MAC_VER_40 ... RTL_GIGA_MAC_VER_53: >>> + rtl_eri_clear_bits(tp, 0xd4, 0x1f80); >>> + break; >>> + case RTL_GIGA_MAC_VER_60 ... RTL_GIGA_MAC_VER_63: >>> + r8168_mac_ocp_modify(tp, 0xc0ac, 0x1f80, 0); >>> + break; >>> + default: >>> + break; >>> + } >>> +} >>> + >>> static void rtl_enable_exit_l1(struct rtl8169_private *tp) { >>> /* Bits control which events trigger ASPM L1 exit: >>> @@ -2692,6 +2705,33 @@ static void rtl_hw_aspm_clkreq_enable(struct >> rtl8169_private *tp, bool enable) >>> udelay(10); >>> } >>> >>> +static void rtl_hw_aspm_l12_enable(struct rtl8169_private *tp, bool >>> +enable) { >>> + /* Don't enable L1.2 in the chip if OS can't control ASPM */ >>> + if (enable && tp->aspm_manageable) { >>> + r8168_mac_ocp_modify(tp, 0xe094, 0xff00, 0); >>> + r8168_mac_ocp_modify(tp, 0xe092, 0x00ff, BIT(2)); >>> + } else { >>> + r8168_mac_ocp_modify(tp, 0xe092, 0x00ff, 0); >>> + } >>> +} >>> + >>> +static void rtl_prepare_power_down(struct rtl8169_private *tp) { >>> + if (tp->dash_type != RTL_DASH_NONE) >>> + return; >>> + >>> + if (tp->mac_version == RTL_GIGA_MAC_VER_32 || >>> + tp->mac_version == RTL_GIGA_MAC_VER_33) >>> + rtl_ephy_write(tp, 0x19, 0xff64); >>> + >>> + if (device_may_wakeup(tp_to_dev(tp))) { >>> + rtl_disable_exit_l1(tp); >>> + phy_speed_down(tp->phydev, false); >>> + rtl_wol_enable_rx(tp); >>> + } >>> +} >>> + >>> static void rtl_set_fifo_size(struct rtl8169_private *tp, u16 rx_stat, >>> u16 tx_stat, u16 rx_dyn, u16 tx_dyn) { @@ - >> 3675,6 +3715,7 >>> @@ static void rtl_hw_start_8125b(struct rtl8169_private *tp) >>> rtl_ephy_init(tp, e_info_8125b); >>> rtl_hw_start_8125_common(tp); >>> >>> + rtl_hw_aspm_l12_enable(tp, true); >>> rtl_hw_aspm_clkreq_enable(tp, true); } >>> >>> @@ -5255,6 +5296,20 @@ static void rtl_init_mac_address(struct >> rtl8169_private *tp) >>> rtl_rar_set(tp, mac_addr); >>> } >>> >>> +/* mac ocp 0xc0b2 will help to identify if RTL8125 has been tested >>> + * on L1.2 enabled platform. If it is, this register will be set to 0xf. >>> + * If not, this register will be default value 0. >>> + */ >>> +static bool rtl_platform_l12_enabled(struct rtl8169_private *tp) { >>> + switch (tp->mac_version) { >>> + case RTL_GIGA_MAC_VER_60 ... RTL_GIGA_MAC_VER_63: >>> + return (r8168_mac_ocp_read(tp, 0xc0b2) & 0xf) ? true : false; >>> + default: >>> + return false; >>> + } >>> +} >>> + >>> static int rtl_init_one(struct pci_dev *pdev, const struct >>> pci_device_id *ent) { >>> struct rtl8169_private *tp; >>> @@ -5333,11 +5388,15 @@ static int rtl_init_one(struct pci_dev *pdev, >> const struct pci_device_id *ent) >>> * Chips from RTL8168h partially have issues with L1.2, but seem >>> * to work fine with L1 and L1.1. >>> */ >>> - if (tp->mac_version >= RTL_GIGA_MAC_VER_45) >>> - rc = pci_disable_link_state(pdev, PCIE_LINK_STATE_L1_2); >>> - else >>> - rc = pci_disable_link_state(pdev, PCIE_LINK_STATE_L1); >>> - tp->aspm_manageable = !rc; >>> + if (!rtl_platform_l12_enabled(tp)) { >>> + if (tp->mac_version >= RTL_GIGA_MAC_VER_45) >>> + rc = pci_disable_link_state(pdev, >> PCIE_LINK_STATE_L1_2); >>> + else >>> + rc = pci_disable_link_state(pdev, >> PCIE_LINK_STATE_L1); >>> + tp->aspm_manageable = !rc; >>> + } else { >>> + tp->aspm_manageable = pcie_aspm_enabled(pdev); >>> + } >>> >>> tp->dash_type = rtl_check_dash(tp); >>> >> >> Hi Hau, >> >> the following is a stripped-down version of the patch. Could you please >> check/test? > This patch is ok. > L1 substate lock can apply for both rtl8125a.rtl8125b. > if (enable && tp->aspm_manageable) { > RTL_W8(tp, Config5, RTL_R8(tp, Config5) | ASPM_en); > RTL_W8(tp, Config2, RTL_R8(tp, Config2) | ClkReqEn); > > if (tp->mac_version >= RTL_GIGA_MAC_VER_60) { > r8168_mac_ocp_modify(tp, 0xe094, 0xff00, 0); > r8168_mac_ocp_modify(tp, 0xe092, 0x00ff, BIT(2)); > } > } else { > if (tp->mac_version >= RTL_GIGA_MAC_VER_60) > r8168_mac_ocp_modify(tp, 0xe092, 0x00ff, 0); > > RTL_W8(tp, Config2, RTL_R8(tp, Config2) & ~ClkReqEn); > RTL_W8(tp, Config5, RTL_R8(tp, Config5) & ~ASPM_en); > } > >> If function rtl_disable_exit_l1() is actually needed, I'd prefer to add it in a >> separate patch (to facilitate bisecting). >> > If exit l1 mask is enabled, hardware will prone to exit l1. That will prevent hardware from > entering l1 substate. So It needs to disable l1 exist mask when device go to d3 state > for entering l1 substate.. > My understanding of PCI power management may be incomplete, but: If a device goes to D3, then doesn't the bus go to L2/L3? L1 exit criteria would be irrelevant then.