From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B9F234EEFD for ; Wed, 18 Mar 2026 10:28:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773829691; cv=none; b=WTASjB/xLz4pOxq99PQazB9U/1HSDEqTk/C0w+xe18jF+SDPT9gSb209Vg+zc1VTZmGSAHj/eWTISrKTjJZ7LuvGN+XFvtwiHQlWiGl4gienY0PDlzqKeLLNjTz5XfRRQyD5fm6w4AaNYOdkoJgRiTjRuOYaLuRBedVCo5YU8ec= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773829691; c=relaxed/simple; bh=g1lFkxgNM2As/FFnMkqSpkhOeaGI8P/etL2kdgY+BoA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OKvhVy5RxRKKpeklNFqpvCB+G4oDoXwR0RNukv1HpN3KIXhmPXQBsz468a40vdJbgGrFuMPFyF6KcJ/FwW8exu/9dNljlnB9xCCHwUvrpL3Bd7PTGjl7CTW8o424P2+Sbpf72HcEbNMtSfRrKvMIlBmG7Ez8GBhuJvZTXso/gpQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=NEbGASpk; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZJLDGBNO; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="NEbGASpk"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZJLDGBNO" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62I9o7J0402852 for ; Wed, 18 Mar 2026 10:28:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= jqFDE1/8OVok3M3UrRjh5fs8K+GKsgIiSCPlIEJkwOM=; b=NEbGASpkuBWvgiOh FlsLbn6FDLGrijNN1ThoOOf9V4wAXxddqtII8Pp7Tt+O43CpwmNR4kV8kt7HTyAA eAyuVF6FdksU5orRtCuTAKLvAHpuf4MN3T3aqJlpD3jmhxpDv8AEUP8hY8R/EStn fk1TMENAP1qzdWZmmuvv7Rv2kE9bMltdypWd1IeeURr6DOL5OJjw8D4pCl28Lc7w c6zZK0AA41jCHO5SwuGCYueZlivgWXk7Xpn9Ij0QjGCSBsDOyurSVOhylc/ncc5T VcWXhi+EkS3eehGc+ONl+HqYZPnzsViLw1FZanSvqYhzLnaPahFytSmfUCA6YyaZ LyehVQ== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cyc4dua86-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 18 Mar 2026 10:28:09 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8cb456d53a5so444291985a.2 for ; Wed, 18 Mar 2026 03:28:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773829688; x=1774434488; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jqFDE1/8OVok3M3UrRjh5fs8K+GKsgIiSCPlIEJkwOM=; b=ZJLDGBNO+szWo8uEZ5RRdgN9+qg70SJu6jBU2dvWd3eSNCZy7jYU7wobs2BUlE8bOj CleQT+moAhFpfSVtpq1xfJKyUkkiTc0bDZPNxUDQOMrsKixbH1LhrLk8QbV+SbDiFWTn OXmcI7mRpU55ZzE7mZWYS6wDp+dfNVuclhL/xjV05NfmM5qpEgfmD1xgFis7V/Z8Fk2e dlGRm9avoXMv+ba0q6lK0TAkzKu4NZ4TBKq59Ffrcqwnjxww/Q7/9ox/G1GJv+tSfsQz 7XXoMQUwGT5hmQYwpJEO4HhgG0HunjztAU6kax57zVgDp3TaOq5ItG2napjf9WNqK291 TPhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773829688; x=1774434488; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jqFDE1/8OVok3M3UrRjh5fs8K+GKsgIiSCPlIEJkwOM=; b=KGmA+m4o0DffXdZUpUHOdefpiUEo9vxF+HJ9EInUgMVyad2TWvD15YDKhP54xzfD8T JBbUDzXj4oyyvWPLj2uMPm1la2uU7itGqH9bxtNmfWEwX4Y0UE3rqB/FQ7rRSfBSlrk4 HEteFP2tZFx79R+P7OdvBnwHLJmWQeEau7N8yD7aKBWPRSPFtdi5WUvWLCkfcXhEwGbx wy7p91x6S6aM1kLXJzco/ajlwpp7jn3bZL6jEP4wsme7W3p5iACrJ0q8cjjdEf9NAz9y um44H5/h4ut8gKJ2oiR326SF4cj6HwwDnJ9jaW/ppBr50XICMAtotZCVulIh+OmtDWB7 oljQ== X-Forwarded-Encrypted: i=1; AJvYcCVuTWksoGYk3CSk9aHPqotkbNubqI/Qdl14D3uEs3nvfOAgmyuwJsDJmAHDi525gmHyXvUDryEe8/gpXiY=@vger.kernel.org X-Gm-Message-State: AOJu0YyXYZlV4gQ+jUmvv60zSlWVM3eJ/2+ZI9TZ7sQSb4/D0k9HwIZC aGEMq7W0i/S0HJNox9WbSwlg92fW6zEVIbLy08EqwFSTA4bLXoxGbNx8rHdoltYmObNYSL0LMwT d/ZAe3uNtKesq/bb5ukLBa4UH4H34VpTQQHZEsgS6ieXimIqEnI10xeDPG9XdYUJvxH0= X-Gm-Gg: ATEYQzz9kC011VSS+9b0+Hl4QZ2Olu6tUONHC5qjMWPlFDfRRucI8yMhO8K8Blj3069 lov5+Kvye5+F71C2RK1Fbiqn0O2r1EnRCIxy34KI0m4tUX+9jAfYhk8lFF36WGsVXHph2VhN6kc 8gxJlMiRvLHQ/m6rnXfu2T9webknrMcycwadncRMP14EdAtPp1p1kSFGjvqITx6nxkpJVutm7UA JcC43HPX7veVyJE40CNYOV3xWXVnGrmSFhnSQ/5iUbJ7IKvRAlqP1Xcs+rtannfAA9b89xH/oCR hbLN/M6q+bfVB6z8cfAww1VDrwlvKCLKyVJz8octOTcwOXLyBBbKuUQrgUcUQsOlGqzvj6XHIkk UwMwRGPP1FmUeoeC0YqEDquJ/A0ET5slQyD4IPhjmQbh+0PzRqcezLj7kvVYgqL3idcoJB0pva3 svFdw= X-Received: by 2002:a05:620a:404a:b0:8cd:7fc0:ee15 with SMTP id af79cd13be357-8cfad357f8fmr281966485a.5.1773829688552; Wed, 18 Mar 2026 03:28:08 -0700 (PDT) X-Received: by 2002:a05:620a:404a:b0:8cd:7fc0:ee15 with SMTP id af79cd13be357-8cfad357f8fmr281964185a.5.1773829688001; Wed, 18 Mar 2026 03:28:08 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-667b12ada68sm1602499a12.28.2026.03.18.03.28.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Mar 2026 03:28:07 -0700 (PDT) Message-ID: Date: Wed, 18 Mar 2026 11:28:05 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/2] arm64: dts: qcom: sm8250-asus-obiwan: Add ASUS ROG Phone 3 To: Alexander Koskovich , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kees Cook , Tony Luck , "Guilherme G. Piccoli" Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260310-sm8250-asus-obiwan-v3-0-9ed8f0e71e19@pm.me> <20260310-sm8250-asus-obiwan-v3-2-9ed8f0e71e19@pm.me> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260310-sm8250-asus-obiwan-v3-2-9ed8f0e71e19@pm.me> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE4MDA4OCBTYWx0ZWRfXyZesM/2Dz7NG 4vLArVy6Q+teqtyd084ssCsMKCwC0cxAO7jFb6LagSDsyBtn540Yi1g+69UoEUXhwFa0050ufeS oAnQThPrhruB315uG0AwauQlhJMSCuA5OD4oLt6HNHDPf1EvFVkw93K6ELbG8vXL8bURf9Wiy3Z 9Gl1F574CntWk7LbujTpJTW0Sckc7yzC16iGyaYCO2R5dvzS2wkHajOLipmr9Ktov77NQn1xkfl lZNJXDfXfzglQeffh5H4t+y51Lhv76I2DBrI26DwYYgjlnc8yC+NF2BLjpTgeoNta7FPTXaNdB0 0ybQRXZIzWqNwTnkySkD3UjgrXTDU1s97stzwjZQhvLuG7pYhBMZkohREeWunaz2nHvb1ei3qih rYNWJxVEoyNcnE9r9u7qdbx4Ry/75efFJH47iMUGyt5NZ4wOvyRUl9EHvCLzOg79YVnGLgr04lz VcYy5LU6lMiqvj5yENg== X-Proofpoint-GUID: XklxiWXmX-bqWGREswYmj-FxLHeRqXfZ X-Authority-Analysis: v=2.4 cv=DfQaa/tW c=1 sm=1 tr=0 ts=69ba7e39 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=OwnEAehHgkl8Ls2ekt0A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-ORIG-GUID: XklxiWXmX-bqWGREswYmj-FxLHeRqXfZ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-18_01,2026-03-17_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 suspectscore=0 impostorscore=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 clxscore=1015 spamscore=0 bulkscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603180088 On 3/11/26 3:43 AM, Alexander Koskovich wrote: > Supported functionality as of this initial submission: > * Armor Case & Dock Hall Sensors > * Camera flash/torch LED > * Display (Tianma TA066VVHM03) > * DisplayPort Alt Mode > * Macro Camera (OV8856) > * GPU (Adreno 650) > * NFC (NXP PN553) > * Power Button, Volume Keys > * Regulators > * Remoteprocs (ADSP, CDSP, SLPI) > * UFS > * USB > * Video Codec (Venus) > * Wi-Fi / Bluetooth (QCA6390) > > Signed-off-by: Alexander Koskovich > --- [...] > + /* > + * There are also ER & EVB boards, but those have meaningful hardware > + * differences that make them not compatible with this devicetree. > + */ > + qcom,board-id = <31 0>, /* ER2 */ > + <40 0>, /* PR */ > + <41 0>, /* PR2 */ > + <50 0>; /* MP */ I would guesstimate MP is Mass Production and everything before that is engineering samples.. perhaps that doesn't hurt - maybe some curious Asus engineer swings by one day! [...] > +&i2c1 { > + status = "okay"; Please ensure 'status' is the last property, preceded by a \n > + clock-frequency = <400000>; > + > + nfc@28 { > + compatible = "nxp,pn553", > + "nxp,nxp-nci-i2c"; > + reg = <0x28>; > + > + interrupt-parent = <&tlmm>; > + interrupts = <111 IRQ_TYPE_EDGE_RISING>; interrupts-extended = <&tlmm 111 ...> > + > + enable-gpios = <&tlmm 6 GPIO_ACTIVE_HIGH>; > + firmware-gpios = <&tlmm 110 GPIO_ACTIVE_HIGH>; > + > + pinctrl-0 = <&nfc_en_default>, > + <&nfc_clk_req_default>, > + <&nfc_firmware_default>, > + <&nfc_irq_default>; You can bunch them up into: nfc_default_state: xyz-abc-state { nfc-en-pins { pins = ".... ... }; nfc-clk-req-pins { pins = "... }; }; > + /* > + * When low the USB 2 data lanes are routed to the bottom USB port. > + * When high they are routed to the pogo port on the side of the device. > + */ > + usb2_mux_en: usb2-mux-en-default-state { > + pins = "gpio9"; > + function = PMIC_GPIO_FUNC_NORMAL; > + power-source = <0>; > + output-low; > + }; [...] > + source-pdos = + PDO_FIXED_DUAL_ROLE | > + PDO_FIXED_USB_COMM | > + PDO_FIXED_DATA_SWAP)>; > + > + sink-pdos = + PDO_FIXED_DUAL_ROLE | > + PDO_FIXED_USB_COMM | > + PDO_FIXED_DATA_SWAP) > + PDO_FIXED(9000, 3000, 0) > + PDO_FIXED(12000, 2250, 0)>; Both ports have the same PDOs - will this kaboom if you plug in two chargers? [...] > + wlan_en_default: wlan-default-state { > + pins = "gpio20"; > + function = "gpio"; > + drive-strength = <16>; > + output-low; > + bias-pull-up; > + }; > + > + bt_en_default: bt-default-state { > + pins = "gpio21"; > + function = "gpio"; > + drive-strength = <16>; > + output-low; > + bias-pull-up; > + }; you can drop output-low from both - the PMU driver will set it via the GPIO APIs [...] > +&usb_2 { > + pinctrl-0 = <&rt1715_mux_en>, <&usb2_mux_en>; > + pinctrl-names = "default"; > + > + /* > + * Disable USB3 clock requirement as the bottom port only supports USB2. > + * The USB3 lanes are routed through the pogo connector on this board for > + * use with accessories, so will need to revisit this when we start to add > + * support for those. > + */ > + qcom,select-utmi-as-pipe-clk; So, is that right? ┌───────┐ │ POGO │ └──┬──┬─┘ superspeed │ │ ┌─────────────────────────────┘ │ │ │ ┌──────┼─┐ highspeed │ │ DWC3_2 ┼─────────────────────┐ ┌────┴──┐ └────────┘ └───┤ MUX ┼───────PM8150_GPIO9 ┌─────────┐ └──┬────┘ │ GPIO170 │ │ └─────────┘ │ │ │ ┌────────┐ RXTX ┌───┴──┐ ┌───┴──┐ │ UART ┼────────│ MUX ┼────────┤USB-C2│ └────────┘ └──┬───┘ └──────┘ │ ▼ GND Konrad