From: Felix Kaechele <felix@kaechele.ca>
To: Conor Dooley <conor@kernel.org>
Cc: Job Noorman <job@noorman.info>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/5] dt-bindings: input: touchscreen: himax,hx83112b: add HX83100A
Date: Sat, 11 May 2024 10:10:08 -0400 [thread overview]
Message-ID: <dab1dddd-57ae-445e-bce7-879e8d73d809@kaechele.ca> (raw)
In-Reply-To: <20240511-passage-obstruct-70e4c3b37dbd@spud>
On 2024-05-11 08:38, Conor Dooley wrote:
> On Sat, May 11, 2024 at 08:12:22AM -0400, Felix Kaechele wrote:
>> Add a compatible string for the Himax HX83100A touch controller.
>>
>> Signed-off-by: Felix Kaechele <felix@kaechele.ca>
>
> Commit message should mention what makes this device incompatible with
> the existing device.
Thanks!
I have added this note in the commit message which will be part of a v3,
coming after I hopefully receive a few more comments on the other parts
of this change:
The HX83100A presents touch events on its internal bus rather than
offering a dedicated event register like the other chips in this family do.
Felix
next prev parent reply other threads:[~2024-05-11 14:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-11 12:12 [PATCH v2 0/5] input: himax_hx83112b: add support for HX83100A Felix Kaechele
2024-05-11 12:12 ` [PATCH v2 1/5] dt-bindings: input: touchscreen: himax,hx83112b: add HX83100A Felix Kaechele
2024-05-11 12:38 ` Conor Dooley
2024-05-11 14:10 ` Felix Kaechele [this message]
2024-05-12 12:04 ` Conor Dooley
2024-05-11 12:12 ` [PATCH v2 2/5] input: himax_hx83112b: use more descriptive register defines Felix Kaechele
2024-05-11 12:12 ` [PATCH v2 3/5] input: himax_hx83112b: implement MCU register reading Felix Kaechele
2024-05-13 23:01 ` Dmitry Torokhov
2024-05-14 9:46 ` Mark Brown
2024-05-14 14:01 ` Felix Kaechele
2024-05-29 23:07 ` Felix Kaechele
2024-05-11 12:12 ` [PATCH v2 4/5] input: himax_hx83112b: add himax_chip struct for multi-chip support Felix Kaechele
2024-05-11 12:12 ` [PATCH v2 5/5] input: himax_hx83112b: add support for HX83100A Felix Kaechele
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dab1dddd-57ae-445e-bce7-879e8d73d809@kaechele.ca \
--to=felix@kaechele.ca \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=job@noorman.info \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®