From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A619C3A5A9 for ; Sat, 2 May 2020 08:49:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 176F32137B for ; Sat, 2 May 2020 08:49:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727121AbgEBItn (ORCPT ); Sat, 2 May 2020 04:49:43 -0400 Received: from smtp03.smtpout.orange.fr ([80.12.242.125]:30878 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727088AbgEBItm (ORCPT ); Sat, 2 May 2020 04:49:42 -0400 Received: from [192.168.1.41] ([92.140.215.114]) by mwinf5d26 with ME id ZkpB2200V2Ug2Sc03kpK1y; Sat, 02 May 2020 10:49:36 +0200 X-ME-Helo: [192.168.1.41] X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Sat, 02 May 2020 10:49:36 +0200 X-ME-IP: 92.140.215.114 Subject: Re: [PATCH 4/4 v2] firmware: stratix10-svc: Slightly simplify code To: Richard Gong , gregkh@linuxfoundation.org, atull@kernel.org Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <8c505c686438c54da61ad4fe15e1eae722011153.1588142343.git.christophe.jaillet@wanadoo.fr> <1f8ae50d-6830-7fbb-e999-3e8110fe7cd6@linux.intel.com> <2a1de0d5-444a-2680-10b5-8578c2670d54@linux.intel.com> From: Christophe JAILLET Message-ID: Date: Sat, 2 May 2020 10:49:05 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <2a1de0d5-444a-2680-10b5-8578c2670d54@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 01/05/2020 à 18:55, Richard Gong a écrit : > Hi, > > On 5/1/20 10:48 AM, Christophe JAILLET wrote: >> Le 01/05/2020 à 17:40, Richard Gong a écrit : >>> Hi, >>> >>> On 4/29/20 1:52 AM, Christophe JAILLET wrote: >>>> Replace 'devm_kmalloc_array(... | __GFP_ZERO)' with the equivalent and >>>> shorter 'devm_kcalloc(...)'. >>>> >>> It doesn't make much sense. >>> Actually devm_kcalloc returns devm_kmalloc_array(.., flag | >>> __GFP_ZERO). >>> >> The only goal is to have a sightly less verbose code. >> This saves one line of code and there is no need to wonder why we >> explicitly pass __GFP_ZERO to kmalloc_array. >> >> Mostly a matter of taste. > I prefer this part remain unchanged. > The easiest would be just to ignore this patch entirely but if you need a v3 for the series, could you tell me if you have any comments on the 3 other patches? CJ > Regards, > Richard > >> >> 'devm_kcalloc' is inlined, so the binary should be exactly the same. > >> CJ >> >>>> 'ctrl->genpool' can not be NULL, so axe a useless test in the remove >>>> function. >>>> >>>> Signed-off-by: Christophe JAILLET >>>> --- >>>>   drivers/firmware/stratix10-svc.c | 6 ++---- >>>>   1 file changed, 2 insertions(+), 4 deletions(-) >>>> >>>> diff --git a/drivers/firmware/stratix10-svc.c >>>> b/drivers/firmware/stratix10-svc.c >>>> index 739004398877..c228337cb0a1 100644 >>>> --- a/drivers/firmware/stratix10-svc.c >>>> +++ b/drivers/firmware/stratix10-svc.c >>>> @@ -1002,8 +1002,7 @@ static int stratix10_svc_drv_probe(struct >>>> platform_device *pdev) >>>>       if (!controller) >>>>           return -ENOMEM; >>>>   -    chans = devm_kmalloc_array(dev, SVC_NUM_CHANNEL, >>>> -                   sizeof(*chans), GFP_KERNEL | __GFP_ZERO); >>>> +    chans = devm_kcalloc(dev, SVC_NUM_CHANNEL, sizeof(*chans), >>>> GFP_KERNEL); >>>>       if (!chans) >>>>           return -ENOMEM; >>>>   @@ -1086,8 +1085,7 @@ static int stratix10_svc_drv_remove(struct >>>> platform_device *pdev) >>>>           kthread_stop(ctrl->task); >>>>           ctrl->task = NULL; >>>>       } >>>> -    if (ctrl->genpool) >>>> -        gen_pool_destroy(ctrl->genpool); >>>> +    gen_pool_destroy(ctrl->genpool); >>>>       list_del(&ctrl->node); >>>>         return 0; >>>> >>> >>> Regards, >>> Richard >>> >> >