From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f47.google.com (mail-dl1-f47.google.com [74.125.82.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D39C013D891 for ; Sun, 22 Feb 2026 18:33:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771785214; cv=none; b=jkz6rWqXQ97nER8ckpHkpyfnCE/s2k9dvtXQfdLx+7euM9hSG6Q4yUAlnjhSNpj9oeJbTymLxhM/OJSYq5ss763JkTN+xuBADWOH5WDNa6NdDMZzJUQP8duSjMzqXsPuMLjwlyIOwBTYebGCLomO4U2jip5mVJlHhklU5U30OWU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771785214; c=relaxed/simple; bh=Gxa5A+tvgIFzLTNVZwkWDhuRkbCoNzau+xJzqZTG0Q4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=i15zTgzgDrfE9cFj/3MbKORQU6NyRSsXO+M5EZ6PgJ52l95/ynship0X6gyOchk6c4zsIevfWGSdFoUZSTbc6l9yBOUoWUh0NRjOZ1lidAZn5cQYchoLyLXfiElGH0WqkDrqmcZm9YuSw0qBXJUGIIFtpyldwaDXZ0gpSuRyg+E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HQF1VZ5S; arc=none smtp.client-ip=74.125.82.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HQF1VZ5S" Received: by mail-dl1-f47.google.com with SMTP id a92af1059eb24-126ea4b77adso4337485c88.1 for ; Sun, 22 Feb 2026 10:33:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771785212; x=1772390012; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=1GthVDsIOd+2sKUfi8Uh06K9+Ix22GSuy7Q9hscrocw=; b=HQF1VZ5SRDaaA2ftTv2oj1xY2pxGhqL+ZkbaxG8Cgr3cuihCvQdraxkNMRB9q0U9sJ h7lASR2c5P+HQhy7dlQHga0us3DpAJqjTfj12Fnd3RMZEu+S96k4B6o1sAyV8Qizmim0 7+dwvQQPfLnqWZD9EzvdUzoux9Yzvt5Y90eIaYatia74eKIXESQjiNqOnFlx9pNAAER9 I2L56tFde6u5CceL8ShKVUaV5nAaDJbVX6vt4G7JgNbywegF1MlKe79E+/GI9U2rTGzG Mbx4zI6dqrfzlDAdmanStTU6zjLv5uscEfS/l1DZdwUkZM1FX46CtJ5aSSGqHUiD8jEV IHTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771785212; x=1772390012; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=1GthVDsIOd+2sKUfi8Uh06K9+Ix22GSuy7Q9hscrocw=; b=JrObudVXhhn8iPvrrFXFgqMZe3QGsta+2Gzki1dxQ64BDQXDav/R5+SXLzyntcBKjf pAc3yIvoSyc/Chan8UM4n0wU1eYJSfW50MrVHZHlQLytTIS4ZtcWu3VzvZl+UuETTfRW 25rVaHdNo6F9d7VtGER3uak+KpkPzc39ofw8Axy9mtypTXCDaIVMW79LDRo7ZWxDqcY5 /kcmbDDDrMyzYyuHzfI2NKUGCAtTvqnOyTh0FWt7NfDjF0nwoL6ecHYYMTD38g0oLosI FzkqNZPc1LxrsPZOOTflT3y0MfQy81Hm5CHP7GXMR3B5h0aQDWhmR/bjIe0PS50SGQIO zpsQ== X-Forwarded-Encrypted: i=1; AJvYcCVwgqkTkox9aFch5t85GWhEV/WgbNLqrAzFikae6U9EKbY+l+Q7BArLn1e3ntq/AYGrW0L2Qw60OaLmAyw=@vger.kernel.org X-Gm-Message-State: AOJu0YxvuvxRD7L8LoNB/QooUWo4Dmv0T/e2pN3kXMByFQtje38JxCOL B02iuU3sZDjKnvhmW12z/NW8A37zABFBoAQsaJ3ybRGgR8FmJ09OswRn211D0jbN X-Gm-Gg: AZuq6aJqEWbdHz8Lf8aQARLNfcgCkTylfWKf9TdHpk3ULTnaDOOqXcT+8mMzloKH7bW h6pK9YdcC0q4RvzEFoqKu5zUmdZmgGg6zaPNgmySQ8dMCbXTfJR+1XhokfsM9PPCchuVsitOr5p 5SdFZ2kAcsFSeN30o0owen3VRqNygXkBHSJZPJtUkwE9/dgcrE7i18cO+oPADGDhZhA2NetvCFm qUjKSty/+6wAHwcqHpqaSKK442p23hPc7Wa+RbH6zOVmtol+zNsfI6pEDZdqqqW/lKLM90BWj0R OX3K1ty5IQhrR1h9zkTaTIGC9DxjCfrxh12v7ANtlPIcK/NmW42z+YarOyZycudghcthKsz9UUT fPnVmfU4Q8NIsJeNCcQaqaDjCfT3VVA1II5IauSZ9v77cq/NF0/NJT6tjbr4NxdJcAOTH/LHL5Z 3WLqMZEyDHgwWSb5zAjNpbk1LHBlSHji/PVHIw X-Received: by 2002:a05:7022:4387:b0:121:9f05:c4c2 with SMTP id a92af1059eb24-1276ad18ec5mr1966020c88.23.1771785211890; Sun, 22 Feb 2026 10:33:31 -0800 (PST) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1276af9f74bsm5158185c88.15.2026.02.22.10.33.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Feb 2026 10:33:31 -0800 (PST) Sender: Guenter Roeck Date: Sun, 22 Feb 2026 10:33:29 -0800 From: Guenter Roeck To: Hao Yu Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, jcdra1@gmail.com, akhilesh@ee.iitb.ac.in, linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/3] hwmon: (aht10) Fix initialization commands for AHT20 Message-ID: References: <20260222170332.1616-1-haoyufine@gmail.com> <20260222170332.1616-3-haoyufine@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260222170332.1616-3-haoyufine@gmail.com> On Mon, Feb 23, 2026 at 01:03:31AM +0800, Hao Yu wrote: > According to the AHT20 datasheet (updated to V1.0 after the 2023.09 > version), the initialization command for AHT20 is 0b10111110 (0xBE). > The previous sequence (0xE1) used in earlier versions is no longer > compatible with newer AHT20 sensors. Update the initialization > command to ensure the sensor is properly initialized. > > Fixes: d2abcb5cc885 ("hwmon: (aht10) Add support for compatible aht20") > Signed-off-by: Hao Yu Applied, since htis is a fix which doewsn't depend on the devicetree patches. Thanks, Guenter > --- > drivers/hwmon/aht10.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/hwmon/aht10.c b/drivers/hwmon/aht10.c > index 007befdba977..4ce019d2cc80 100644 > --- a/drivers/hwmon/aht10.c > +++ b/drivers/hwmon/aht10.c > @@ -37,7 +37,9 @@ > #define AHT10_CMD_MEAS 0b10101100 > #define AHT10_CMD_RST 0b10111010 > > -#define DHT20_CMD_INIT 0x71 > +#define AHT20_CMD_INIT 0b10111110 > + > +#define DHT20_CMD_INIT 0b01110001 > > /* > * Flags in the answer byte/command > @@ -341,7 +343,7 @@ static int aht10_probe(struct i2c_client *client) > data->meas_size = AHT20_MEAS_SIZE; > data->crc8 = true; > crc8_populate_msb(crc8_table, AHT20_CRC8_POLY); > - data->init_cmd = AHT10_CMD_INIT; > + data->init_cmd = AHT20_CMD_INIT; > break; > case dht20: > data->meas_size = AHT20_MEAS_SIZE;